[GitHub] spark pull request #23199: [SPARK-26245][SQL] Add Float literal

2018-12-06 Thread wangyum
Github user wangyum closed the pull request at: https://github.com/apache/spark/pull/23199 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23199: [SPARK-26245][SQL] Add Float literal

2018-12-02 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/23199#discussion_r238130900 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -1045,6 +1046,11 @@ DOUBLE_LITERAL | DECIMAL_DIGITS

[GitHub] spark pull request #23199: [SPARK-26245][SQL] Add Float literal

2018-12-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/23199#discussion_r238110252 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -1045,6 +1046,11 @@ DOUBLE_LITERAL |

[GitHub] spark pull request #23199: [SPARK-26245][SQL] Add Float literal

2018-12-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/23199#discussion_r238109668 --- Diff: sql/core/src/test/resources/sql-tests/inputs/literals.sql --- @@ -53,6 +53,10 @@ select .e3; -- very large decimals (overflowing double).

[GitHub] spark pull request #23199: [SPARK-26245][SQL] Add Float literal

2018-12-02 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/23199 [SPARK-26245][SQL] Add Float literal ## What changes were proposed in this pull request? This PR adds parser support for `Float` literals. Hive support this feature: