[GitHub] spark pull request #23261: [WIP][SPARK-23674][ML] Adds Spark ML Events

2018-12-08 Thread HyukjinKwon
Github user HyukjinKwon closed the pull request at: https://github.com/apache/spark/pull/23261 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #23261: [WIP][SPARK-23674][ML] Adds Spark ML Events

2018-12-08 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/23261#discussion_r239998861 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala --- @@ -163,7 +163,7 @@ abstract class MLWriter extends BaseReadWrite with

[GitHub] spark pull request #23261: [WIP][SPARK-23674][ML] Adds Spark ML Events

2018-12-08 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/23261#discussion_r239998855 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala --- @@ -210,7 +214,7 @@ abstract class PredictionModel[FeaturesType, M <: