Re: [sage-devel] Re: One year of Sage development on GitHub

2024-02-21 Thread Sebastian Oehms
> *By the way, an author of a PR needs also the ability to remove "needs work". Hence the author needs to be in the Triage team anyway in our workflow. * Not necessarily! If the *synchronizing trigger* is enabled then the bot would change needs work to needs review on a non draft PR each time a

[sage-devel] Re: One year of Sage development on GitHub

2024-02-21 Thread Kwankyu Lee
On Tuesday, February 20, 2024 at 12:26:50 PM UTC+9 Matthias Koeppe wrote: Can the status label sync workflow help with this transition, without getting in the way? For example, when the _author_ removes the "needs review" label (without setting "positive review"), set the PR to "draft"?

[sage-devel] Re: One year of Sage development on GitHub

2024-02-20 Thread seb....@gmail.com
> *Is this selective activation possible?* No! Activating the *labelled trigger* effects all state and priority labels. Even if restriced to the label s: needs review it could be affected by the GitHub bug, since the bot will remove a previously selected state label. > *Sorry. This one is

[sage-devel] Re: One year of Sage development on GitHub

2024-02-20 Thread Kwankyu Lee
If a draft is marked as *ready for review* the s: needs review label is added. Activate immediately. Sorry. This one is also affected by the github bug. Right? If so, not activate. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To

[sage-devel] Re: One year of Sage development on GitHub

2024-02-20 Thread Kwankyu Lee
On Wednesday, February 21, 2024 at 3:11:14 AM UTC+9 seb@gmail.com wrote: This is currently not implemented, but of course possible. But the converse can be activated immediately: If a user converts a ready PR to a draft, all status labels will be removed. Do not activate because of

[sage-devel] Re: One year of Sage development on GitHub

2024-02-20 Thread seb....@gmail.com
It must be done by a maintainer of the repository (see the desription of SYNC_LABELS_IGNORE_EVENTS in #35172 ). However, the restriction regarding the error in the web interface must then be accepted. Matthias Koeppe schrieb am

[sage-devel] Re: One year of Sage development on GitHub

2024-02-20 Thread Matthias Koeppe
On Tuesday, February 20, 2024 at 10:11:14 AM UTC-8 seb@gmail.com wrote: can be activated immediately: If a user converts a ready PR to a draft, all status labels will be removed. If a draft is marked as *ready for review* the s: needs review label is added. Also implemented (but not

[sage-devel] Re: One year of Sage development on GitHub

2024-02-20 Thread seb....@gmail.com
This is currently not implemented, but of course possible. But the converse can be activated immediately: If a user converts a ready PR to a draft, all status labels will be removed. If a draft is marked as *ready for review* the s: needs review label is added. Also implemented (but not

Re: [sage-devel] Re: One year of Sage development on GitHub

2024-02-20 Thread seb....@gmail.com
The bot uses gh edit to manipulate the labels (see the code here ). AFAIR I also tried with gh api leading to the same behavior in the web interface. In principle these commands work,

[sage-devel] Re: One year of Sage development on GitHub

2024-02-19 Thread Matthias Koeppe
On Monday, February 19, 2024 at 7:02:26 PM UTC-8 Kwankyu Lee wrote: *3. Are the labels on GitHub Issues / PRs helpful?* - Note that new contributors who are not in the Triage team cannot set/change labels! - This includes component labels, but also status labels such as "needs review". We

[sage-devel] Re: One year of Sage development on GitHub

2024-02-19 Thread Kwankyu Lee
*3. Are the labels on GitHub Issues / PRs helpful?* - Note that new contributors who are not in the Triage team cannot set/change labels! - This includes component labels, but also status labels such as "needs review". We may drop "needs review" label, and start to use github "draft"

Re: [sage-devel] Re: One year of Sage development on GitHub

2024-02-19 Thread Dima Pasechnik
On Mon, Feb 19, 2024 at 9:20 PM seb@gmail.com wrote: > > *Is it time for the next step with syncing status labels > (https://github.com/sagemath/sage/issues/35927 > )? * > > The reason this is blocked is because there is a bug in the GitHub web

[sage-devel] Re: One year of Sage development on GitHub

2024-02-19 Thread seb....@gmail.com
> *Is it time for the next step with syncing status labels (https://github.com/sagemath/sage/issues/35927 )? * The reason this is blocked is because there is a bug in the GitHub web interface that might cause confusion when labels are added or

[sage-devel] Re: One year of Sage development on GitHub

2024-02-16 Thread Matthias Koeppe
On Thursday, February 8, 2024 at 10:16:58 AM UTC-8 Matthias Koeppe wrote: On Wednesday, February 7, 2024 at 1:11:14 PM UTC-8 Matthias Koeppe wrote: Let's also use this anniversary as an opportunity to discuss what still needs improving in our development workflows. *1. We have a low

[sage-devel] Re: One year of Sage development on GitHub

2024-02-14 Thread 'Martin R' via sage-devel
The "math" activity might be useful, but the "documentation" label is currently also used for issues that have nothing to do with math. So either relabel those or exclude "documentation". On Tuesday 13 February 2024 at 08:34:32 UTC+1 Kwankyu Lee wrote: On Monday, February 12, 2024 at 3:42:55 

[sage-devel] Re: One year of Sage development on GitHub

2024-02-12 Thread Kwankyu Lee
On Monday, February 12, 2024 at 3:42:55 PM UTC+9 Matthias Koeppe wrote: On Thursday, February 8, 2024 at 10:16:58 AM UTC-8 Matthias Koeppe wrote: *2. Is our community aware of the sagemath/sage GitHub wiki?* https://github.com/sagemath/sage/wiki - Are the contents of the wiki front page

Re: [sage-devel] Re: One year of Sage development on GitHub

2024-02-12 Thread Matthias Koeppe
On Monday, February 12, 2024 at 10:06:59 AM UTC-8 David Lowry-Duda wrote: On 22:42 Sun 11 Feb 2024, Matthias Koeppe wrote: >*2. Is our community aware of the sagemath/sage GitHub wiki?* >https://github.com/sagemath/sage/wiki >- Are the contents of the wiki front page useful? I think the

Re: [sage-devel] Re: One year of Sage development on GitHub

2024-02-12 Thread Dima Pasechnik
On Mon, Feb 12, 2024 at 6:06 PM David Lowry-Duda wrote: > > On 22:42 Sun 11 Feb 2024, Matthias Koeppe wrote: > >*2. Is our community aware of the sagemath/sage GitHub wiki?* > >https://github.com/sagemath/sage/wiki > >- Are the contents of the wiki front page useful? > > I think the existence of

Re: [sage-devel] Re: One year of Sage development on GitHub

2024-02-12 Thread David Lowry-Duda
On 22:42 Sun 11 Feb 2024, Matthias Koeppe wrote: *2. Is our community aware of the sagemath/sage GitHub wiki?* https://github.com/sagemath/sage/wiki - Are the contents of the wiki front page useful? I think the existence of two wikis (i.e. the github wiki and https://wiki.sagemath.org/) is

[sage-devel] Re: One year of Sage development on GitHub

2024-02-12 Thread 'Martin R' via sage-devel
Found the page: https://github.com/sagemath/trac-to-github/blob/master/docs/Migration-Trac-to-Github.md On Monday 12 February 2024 at 14:18:12 UTC+1 Martin R wrote: > I suggest to remove "no dark arts required", because, at least to me, many > of the issues I struggle with actually do require

[sage-devel] Re: One year of Sage development on GitHub

2024-02-12 Thread 'Martin R' via sage-devel
I suggest to remove "no dark arts required", because, at least to me, many of the issues I struggle with actually do require very little knowledge of mathematics but a considerable amount of knowledge of the way sage works. Apart from that, I was looking for the tutorial telling me how to

[sage-devel] Re: One year of Sage development on GitHub

2024-02-08 Thread Kwankyu Lee
1. We have a low development velocity. For example, some simple PRs sit for weeks or months before receiving any review comments. What can we do to improve this? There have always been PRs or trac tickets with no comment for long time. I guess most of us had such tickets in trac era. I