subject:"\[sage\-devel\] VOTE\: disputed PRs"

Re: [sage-devel] VOTE: disputed PRs

2024-03-10 Thread seb....@gmail.com

+1

David Lowry-Duda schrieb am Samstag, 9. März 2024 um 00:18:12 UTC+1:

> +1
>
> - DLD
>
> On 03:23 Mon 04 Mar 2024, David Roe wrote:
> >With no further discussion on this thread
> >, I'm calling a 
> vote
> >on a new process for resolving disagreements on a PR.
> >
> >*Proposal*
> >It is now allowed to vote on disputed PRs directly on Github rather than
> >bringing them to sage-devel. Working things out amicably is preferable,
> >and anyone is welcome to ask on sage-devel for more eyes on a PR. If you
> >notice a serious issue with a PR, it is acceptable to change it to Needs
> >Work (and make a comment!) as an initial step, but if the author or
> >reviewer do not agree then process below should be followed instead. This
> >process is intended as a lower-intensity method for resolving
> >disagreements, and full votes on sage-devel override the process described
> >below.
> >a. When there is disagreement about whether a PR should be merged, anyone
> >may mark a PR as disputed.
> >b. There is no scheduled vote, but rather an ongoing poll based on 
> opinions
> >expressed by developers on the PR (these opinions can be expressed via
> >previous positive reviews or explicit comments giving approval). The PR
> >author is presumed to vote in favor; if they give up or no longer favor 
> the
> >PR they have the right to close the PR overall without any further voting.
> >c. If the total number of positive votes is at least twice the number of
> >negative votes, anyone involved may set the status to *positive review*; 
> if
> >the total number of positive votes is less than twice the number of
> >negative votes, anyone involved may set the status to *needs review*. When
> >either of these actions is taken, the person changing the status must list
> >the people they are counting as positive and negative votes in a comment
> >using @ mentions.
> >d. The final decision on merging a disputed PR remains with the release
> >manager, and we encourage the release manager to give enough time for
> >everyone to express an opinion.
> >
> >Voting will be open until Wednesday, March 13.
> >David
> >
> >-- 
> >You received this message because you are subscribed to the Google Groups 
> "sage-devel" group.
> >To unsubscribe from this group and stop receiving emails from it, send an 
> email to sage-devel+...@googlegroups.com.
> >To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sage-devel/CAChs6_n4az3_s16E%3DANOv_o%2B0SvavHwnpqKWYuOznGWTJoXqEg%40mail.gmail.com
> .
>
> -- 
> David Lowry-Duda  
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/dba73af4-4996-4357-bdee-b64944f73bcan%40googlegroups.com.

Re: [sage-devel] VOTE: disputed PRs

2024-03-08 Thread David Lowry-Duda

- DLD

On 03:23 Mon 04 Mar 2024, David Roe wrote:

With no further discussion on this thread
, I'm calling a vote
on a new process for resolving disagreements on a PR.

*Proposal*
It is now allowed to vote on disputed PRs directly on Github rather than
bringing them to sage-devel. Working things out amicably is preferable,
and anyone is welcome to ask on sage-devel for more eyes on a PR. If you
notice a serious issue with a PR, it is acceptable to change it to Needs
Work (and make a comment!) as an initial step, but if the author or
reviewer do not agree then process below should be followed instead. This
process is intended as a lower-intensity method for resolving
disagreements, and full votes on sage-devel override the process described
below.
a. When there is disagreement about whether a PR should be merged, anyone
may mark a PR as disputed.
b. There is no scheduled vote, but rather an ongoing poll based on opinions
expressed by developers on the PR (these opinions can be expressed via
previous positive reviews or explicit comments giving approval). The PR
author is presumed to vote in favor; if they give up or no longer favor the
PR they have the right to close the PR overall without any further voting.
c. If the total number of positive votes is at least twice the number of
negative votes, anyone involved may set the status to *positive review*; if
the total number of positive votes is less than twice the number of
negative votes, anyone involved may set the status to *needs review*. When
either of these actions is taken, the person changing the status must list
the people they are counting as positive and negative votes in a comment
using @ mentions.
d. The final decision on merging a disputed PR remains with the release
manager, and we encourage the release manager to give enough time for
everyone to express an opinion.

Voting will be open until Wednesday, March 13.
David

--
You received this message because you are subscribed to the Google Groups
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/sage-devel/CAChs6_n4az3_s16E%3DANOv_o%2B0SvavHwnpqKWYuOznGWTJoXqEg%40mail.gmail.com.

--
David Lowry-Duda

Re: [sage-devel] VOTE: disputed PRs

2024-03-04 Thread Dima Pasechnik

I think this doesn't work. E.g. the proposal talks about setting PRs to "needs 
work", but banned by the PR's author team members can't do this.

That's why, as I said already, bans break the normal workflow, be it reviewing 
or voting.

On 4 March 2024 22:08:29 GMT, kcrisman  wrote:
>
>
>
>Dima, I think that if anyone is incapable of posting to a particular PR, 
>they should send email to someone who can post and ask them to record the 
>person's vote, resulting in a comment like "I am posting to record 1 
>negative vote from X, 2 positive votes from Y and Z".
>
>
>Yes, that would also go for those who do not choose to use GH.   
>
>-- 
>You received this message because you are subscribed to the Google Groups 
>"sage-devel" group.
>To unsubscribe from this group and stop receiving emails from it, send an 
>email to sage-devel+unsubscr...@googlegroups.com.
>To view this discussion on the web visit 
>https://groups.google.com/d/msgid/sage-devel/0ae620d2-8a84-4290-bf03-66f2d0d03264n%40googlegroups.com.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/17148F09-3727-4760-88BC-924D13EA741B%40gmail.com.

Re: [sage-devel] VOTE: disputed PRs

2024-03-04 Thread kcrisman




Dima, I think that if anyone is incapable of posting to a particular PR, 
they should send email to someone who can post and ask them to record the 
person's vote, resulting in a comment like "I am posting to record 1 
negative vote from X, 2 positive votes from Y and Z".


Yes, that would also go for those who do not choose to use GH.   

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/0ae620d2-8a84-4290-bf03-66f2d0d03264n%40googlegroups.com.

Re: [sage-devel] VOTE: disputed PRs

2024-03-04 Thread John H Palmieri

Dima, I think that if anyone is incapable of posting to a particular PR, 
they should send email to someone who can post and ask them to record the 
person's vote, resulting in a comment like "I am posting to record 1 
negative vote from X, 2 positive votes from Y and Z".


On Monday, March 4, 2024 at 5:27:21 AM UTC-8 Dima Pasechnik wrote:

> David, 
> how about team members who are blocked on GitHub.
> For GitHub voting to work, this has to be sorted out first.
>
> Dima
>
> On Mon, Mar 4, 2024 at 8:23 AM David Roe  wrote:
>
>> With no further discussion on this thread 
>> , I'm calling a 
>> vote on a new process for resolving disagreements on a PR.
>>
>> *Proposal*
>> It is now allowed to vote on disputed PRs directly on Github rather than 
>> bringing them to sage-devel.  Working things out amicably is preferable, 
>> and anyone is welcome to ask on sage-devel for more eyes on a PR.  If you 
>> notice a serious issue with a PR, it is acceptable to change it to Needs 
>> Work (and make a comment!) as an initial step, but if the author or 
>> reviewer do not agree then process below should be followed instead. This 
>> process is intended as a lower-intensity method for resolving 
>> disagreements, and full votes on sage-devel override the process described 
>> below.
>> a. When there is disagreement about whether a PR should be merged, anyone 
>> may mark a PR as disputed.
>> b. There is no scheduled vote, but rather an ongoing poll based on 
>> opinions expressed by developers on the PR (these opinions can be expressed 
>> via previous positive reviews or explicit comments giving approval).  The 
>> PR author is presumed to vote in favor; if they give up or no longer favor 
>> the PR they have the right to close the PR overall without any further 
>> voting.
>> c. If the total number of positive votes is at least twice the number of 
>> negative votes, anyone involved may set the status to *positive review*; 
>> if the total number of positive votes is less than twice the number of 
>> negative votes, anyone involved may set the status to *needs review*.  
>> When either of these actions is taken, the person changing the status must 
>> list the people they are counting as positive and negative votes in a 
>> comment using @ mentions.
>> d. The final decision on merging a disputed PR remains with the release 
>> manager, and we encourage the release manager to give enough time for 
>> everyone to express an opinion.
>>
>> Voting will be open until Wednesday, March 13.
>> David
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "sage-devel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to sage-devel+...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/sage-devel/CAChs6_n4az3_s16E%3DANOv_o%2B0SvavHwnpqKWYuOznGWTJoXqEg%40mail.gmail.com
>>  
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/f5e76b29-0011-428e-bf97-43fc16c2f6e9n%40googlegroups.com.

Re: [sage-devel] VOTE: disputed PRs

2024-03-04 Thread Vincent Delecroix

+1

On Mon, 4 Mar 2024 at 20:20, G. M.-S.  wrote:
>
>
> +1
>
> Guillermo
>
> On Mon, 4 Mar 2024 at 09:23, David Roe  wrote:
>>
>> With no further discussion on this thread, I'm calling a vote on a new 
>> process for resolving disagreements on a PR.
>>
>> Proposal
>> It is now allowed to vote on disputed PRs directly on Github rather than 
>> bringing them to sage-devel.  Working things out amicably is preferable, and 
>> anyone is welcome to ask on sage-devel for more eyes on a PR.  If you notice 
>> a serious issue with a PR, it is acceptable to change it to Needs Work (and 
>> make a comment!) as an initial step, but if the author or reviewer do not 
>> agree then process below should be followed instead. This process is 
>> intended as a lower-intensity method for resolving disagreements, and full 
>> votes on sage-devel override the process described below.
>> a. When there is disagreement about whether a PR should be merged, anyone 
>> may mark a PR as disputed.
>> b. There is no scheduled vote, but rather an ongoing poll based on opinions 
>> expressed by developers on the PR (these opinions can be expressed via 
>> previous positive reviews or explicit comments giving approval).  The PR 
>> author is presumed to vote in favor; if they give up or no longer favor the 
>> PR they have the right to close the PR overall without any further voting.
>> c. If the total number of positive votes is at least twice the number of 
>> negative votes, anyone involved may set the status to positive review; if 
>> the total number of positive votes is less than twice the number of negative 
>> votes, anyone involved may set the status to needs review.  When either of 
>> these actions is taken, the person changing the status must list the people 
>> they are counting as positive and negative votes in a comment using @ 
>> mentions.
>> d. The final decision on merging a disputed PR remains with the release 
>> manager, and we encourage the release manager to give enough time for 
>> everyone to express an opinion.
>>
>> Voting will be open until Wednesday, March 13.
>> David
>
>
>
> --
> You received this message because you are subscribed to the Google Groups 
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sage-devel/CANnG189YucyTQqiSYM7%2BBbgDHSauYdzsP9G%3DDP5gXYhgp15KTQ%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAGEwAAmCE2QRbey4%2B42mXhA%3D8e7gz1zJO1%2BcF5fgYEpARMt1vQ%40mail.gmail.com.

Re: [sage-devel] VOTE: disputed PRs

2024-03-04 Thread G. M.-S.

+1

Guillermo

On Mon, 4 Mar 2024 at 09:23, David Roe  wrote:

> With no further discussion on this thread
> , I'm calling a
> vote on a new process for resolving disagreements on a PR.
>
> *Proposal*
> It is now allowed to vote on disputed PRs directly on Github rather than
> bringing them to sage-devel.  Working things out amicably is preferable,
> and anyone is welcome to ask on sage-devel for more eyes on a PR.  If you
> notice a serious issue with a PR, it is acceptable to change it to Needs
> Work (and make a comment!) as an initial step, but if the author or
> reviewer do not agree then process below should be followed instead. This
> process is intended as a lower-intensity method for resolving
> disagreements, and full votes on sage-devel override the process described
> below.
> a. When there is disagreement about whether a PR should be merged, anyone
> may mark a PR as disputed.
> b. There is no scheduled vote, but rather an ongoing poll based on
> opinions expressed by developers on the PR (these opinions can be expressed
> via previous positive reviews or explicit comments giving approval).  The
> PR author is presumed to vote in favor; if they give up or no longer favor
> the PR they have the right to close the PR overall without any further
> voting.
> c. If the total number of positive votes is at least twice the number of
> negative votes, anyone involved may set the status to *positive review*;
> if the total number of positive votes is less than twice the number of
> negative votes, anyone involved may set the status to *needs review*.
> When either of these actions is taken, the person changing the status must
> list the people they are counting as positive and negative votes in a
> comment using @ mentions.
> d. The final decision on merging a disputed PR remains with the release
> manager, and we encourage the release manager to give enough time for
> everyone to express an opinion.
>
> Voting will be open until Wednesday, March 13.
> David
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CANnG189YucyTQqiSYM7%2BBbgDHSauYdzsP9G%3DDP5gXYhgp15KTQ%40mail.gmail.com.

Re: [sage-devel] VOTE: disputed PRs

2024-03-04 Thread Dima Pasechnik

David,
how about team members who are blocked on GitHub.
For GitHub voting to work, this has to be sorted out first.

Dima

On Mon, Mar 4, 2024 at 8:23 AM David Roe  wrote:

> With no further discussion on this thread
> , I'm calling a
> vote on a new process for resolving disagreements on a PR.
>
> *Proposal*
> It is now allowed to vote on disputed PRs directly on Github rather than
> bringing them to sage-devel.  Working things out amicably is preferable,
> and anyone is welcome to ask on sage-devel for more eyes on a PR.  If you
> notice a serious issue with a PR, it is acceptable to change it to Needs
> Work (and make a comment!) as an initial step, but if the author or
> reviewer do not agree then process below should be followed instead. This
> process is intended as a lower-intensity method for resolving
> disagreements, and full votes on sage-devel override the process described
> below.
> a. When there is disagreement about whether a PR should be merged, anyone
> may mark a PR as disputed.
> b. There is no scheduled vote, but rather an ongoing poll based on
> opinions expressed by developers on the PR (these opinions can be expressed
> via previous positive reviews or explicit comments giving approval).  The
> PR author is presumed to vote in favor; if they give up or no longer favor
> the PR they have the right to close the PR overall without any further
> voting.
> c. If the total number of positive votes is at least twice the number of
> negative votes, anyone involved may set the status to *positive review*;
> if the total number of positive votes is less than twice the number of
> negative votes, anyone involved may set the status to *needs review*.
> When either of these actions is taken, the person changing the status must
> list the people they are counting as positive and negative votes in a
> comment using @ mentions.
> d. The final decision on merging a disputed PR remains with the release
> manager, and we encourage the release manager to give enough time for
> everyone to express an opinion.
>
> Voting will be open until Wednesday, March 13.
> David
>
> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/CAChs6_n4az3_s16E%3DANOv_o%2B0SvavHwnpqKWYuOznGWTJoXqEg%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAAWYfq1%3D7Lo-WvhuOaQxubMX%3D2Vx%3DPcjACSivLQM3p4r786s%2Bw%40mail.gmail.com.

[sage-devel] VOTE: disputed PRs

2024-03-04 Thread David Roe

With no further discussion on this thread
, I'm calling a vote
on a new process for resolving disagreements on a PR.

Voting will be open until Wednesday, March 13.
David

Re: [sage-devel] VOTE: disputed PRs

Re: [sage-devel] VOTE: disputed PRs

Re: [sage-devel] VOTE: disputed PRs

Re: [sage-devel] VOTE: disputed PRs

Re: [sage-devel] VOTE: disputed PRs

Re: [sage-devel] VOTE: disputed PRs

Re: [sage-devel] VOTE: disputed PRs

Re: [sage-devel] VOTE: disputed PRs

[sage-devel] VOTE: disputed PRs

9 matches

Site Navigation

Mail list logo

Footer information