Re: RFR: 8319332: Security properties files inclusion [v12]

2024-05-02 Thread Martin Balao
On Thu, 2 May 2024 21:07:03 GMT, Weijun Wang wrote: > The revised text is much clearer. For the last sentence, I would suggest > rephrasing "In order to prevent profile properties from being overridden" to > "In order to override properties defined in the main file". Isn't that your > real

Re: RFR: 8319332: Security properties files inclusion [v13]

2024-05-02 Thread Francisco Ferrari Bihurriet
> The implementation of this proposal is based on the requirements, > specification and design choices described in the [JDK-8319332] ticket and > its respective CSR [JDK-8319333]. What follows are implementation notes > organized per functional component, with the purpose of assisting to

Re: RFR: 8319332: Security properties files inclusion [v12]

2024-05-02 Thread Weijun Wang
On Thu, 2 May 2024 20:34:22 GMT, Francisco Ferrari Bihurriet wrote: >> The implementation of this proposal is based on the requirements, >> specification and design choices described in the [JDK-8319332] ticket and >> its respective CSR [JDK-8319333]. What follows are implementation notes >>

Re: Potential issues with javax.crypto under StructuredTaskScope/JDK22

2024-05-02 Thread Wei-Jun Wang
Can you try recording the challenge and the answer in each round and then recalculate them in a plain single thread standalone program to verify if the answers are still the same? (Hopefully this calculation is deterministic). --Weijun > On May 2, 2024, at 4:18 PM, Chris Marshall wrote: > >

Re: RFR: 8319332: Security properties files inclusion [v11]

2024-05-02 Thread Martin Balao
On Thu, 2 May 2024 19:07:50 GMT, Weijun Wang wrote: >> src/java.base/share/conf/security/java.security line 69: >> >>> 67: # statement will override any matching property defined in a profile. >>> In order >>> 68: # to avoid this behavior, the include statement may be placed at the >>> end of

Re: RFR: 8319332: Security properties files inclusion [v12]

2024-05-02 Thread Francisco Ferrari Bihurriet
> The implementation of this proposal is based on the requirements, > specification and design choices described in the [JDK-8319332] ticket and > its respective CSR [JDK-8319333]. What follows are implementation notes > organized per functional component, with the purpose of assisting to

Re: Potential issues with javax.crypto under StructuredTaskScope/JDK22

2024-05-02 Thread Chris Marshall
Hi Alan, The code is completely unchanged between JDK21 and JDK22; it is using virtual threads and StructuredTaskScope in both cases (and also, via a different path, platform threads in both cases). I should perhaps have given a bit more background about why I think that the crypto classes

Re: RFR: 8319332: Security properties files inclusion [v11]

2024-05-02 Thread Martin Balao
On Thu, 2 May 2024 19:09:07 GMT, Weijun Wang wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Profiles documentation adjustments. >> >> Co-authored-by: Francisco Ferrari >> Co-authored-by:

Re: RFR: 8319332: Security properties files inclusion [v11]

2024-05-02 Thread Weijun Wang
On Thu, 2 May 2024 19:06:00 GMT, Weijun Wang wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Profiles documentation adjustments. >> >> Co-authored-by: Francisco Ferrari >> Co-authored-by:

Re: RFR: 8319332: Security properties files inclusion [v11]

2024-05-02 Thread Weijun Wang
On Thu, 2 May 2024 16:45:09 GMT, Francisco Ferrari Bihurriet wrote: >> The implementation of this proposal is based on the requirements, >> specification and design choices described in the [JDK-8319332] ticket and >> its respective CSR [JDK-8319333]. What follows are implementation notes >>

Re: Potential issues with javax.crypto under StructuredTaskScope/JDK22

2024-05-02 Thread Alan Bateman
On 02/05/2024 19:33, Chris Marshall wrote: : Last week I upgraded the application to be compiled by JDK22, and run on JDK22. Immediately, we started to see failures from within the User-SRP auth code /only when it was run on a virtual thread from within a StructuredTaskScope./ The failures

Integrated: 8328864: NullPointerException in sun.security.jca.ProviderList.getService()

2024-05-02 Thread Ben Perez
On Thu, 11 Apr 2024 16:29:00 GMT, Ben Perez wrote: > Updated `getService` to check whether `getProvider` returns null when > checking for preferred providers and `continue` the loop if that is the case. > Added `NullPreferredList` test. This pull request has now been integrated. Changeset:

Potential issues with javax.crypto under StructuredTaskScope/JDK22

2024-05-02 Thread Chris Marshall
Hi, I work for an organisation which runs a number of applications inside an EKS cluster hosted in AWS. In order for the applications to communicate, they obtained bearer tokens from the AWS Cognito library, and in order to obtain the tokens, we have coded up User-SRP auth. This code has been

Re: RFR: 8319332: Security properties files inclusion [v10]

2024-05-02 Thread Francisco Ferrari Bihurriet
On Thu, 2 May 2024 15:57:36 GMT, Weijun Wang wrote: > Another comment: now that the backward compatibility code is added, is it > still necessary to update the `DynStatic.java` test? @wangweij: it's no longer strictly necessary. However, we decided to leave it that way in order to lead by

Re: RFR: 8319332: Security properties files inclusion [v10]

2024-05-02 Thread Martin Balao
On Thu, 2 May 2024 14:59:54 GMT, Weijun Wang wrote: > In the new `java.security` text, you have "the file profile.security must > exist". This is not necessary, right? I think what you meant to say is that > "if the system property is not defined, then it will be expanded to an empty > string

Re: RFR: 8319332: Security properties files inclusion [v11]

2024-05-02 Thread Francisco Ferrari Bihurriet
> The implementation of this proposal is based on the requirements, > specification and design choices described in the [JDK-8319332] ticket and > its respective CSR [JDK-8319333]. What follows are implementation notes > organized per functional component, with the purpose of assisting to

Re: RFR: 8319332: Security properties files inclusion [v10]

2024-05-02 Thread Weijun Wang
On Thu, 2 May 2024 14:07:13 GMT, Francisco Ferrari Bihurriet wrote: >> The implementation of this proposal is based on the requirements, >> specification and design choices described in the [JDK-8319332] ticket and >> its respective CSR [JDK-8319333]. What follows are implementation notes >>

Re: RFR: 8319332: Security properties files inclusion [v10]

2024-05-02 Thread Weijun Wang
On Thu, 2 May 2024 14:07:13 GMT, Francisco Ferrari Bihurriet wrote: >> The implementation of this proposal is based on the requirements, >> specification and design choices described in the [JDK-8319332] ticket and >> its respective CSR [JDK-8319333]. What follows are implementation notes >>

Re: RFR: 8319332: Security properties files inclusion [v10]

2024-05-02 Thread Weijun Wang
On Thu, 2 May 2024 14:07:13 GMT, Francisco Ferrari Bihurriet wrote: >> The implementation of this proposal is based on the requirements, >> specification and design choices described in the [JDK-8319332] ticket and >> its respective CSR [JDK-8319333]. What follows are implementation notes >>

Re: RFR: 8319332: Security properties files inclusion [v10]

2024-05-02 Thread Francisco Ferrari Bihurriet
> The implementation of this proposal is based on the requirements, > specification and design choices described in the [JDK-8319332] ticket and > its respective CSR [JDK-8319333]. What follows are implementation notes > organized per functional component, with the purpose of assisting to