Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

2018-10-23 Thread David Holmes
On 24/10/2018 8:30 AM, dean.l...@oracle.com wrote: On 10/23/18 2:51 PM, David Holmes wrote: Hi Dean, On 24/10/2018 4:05 AM, dean.l...@oracle.com wrote: On 10/23/18 9:46 AM, dean.l...@oracle.com wrote: On 10/22/18 3:31 PM, David Holmes wrote: Sorry Dean I'm concerned about a thread

Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

2018-10-23 Thread Mandy Chung
On 10/23/18 3:30 PM, dean.l...@oracle.com wrote: On 10/23/18 2:51 PM, David Holmes wrote: OK, but even if the regular benchmarks don't show a difference, I'd feel better if microbenchmarks were not affected.  What if I go back to the original approach and add locking:    static jlong

Re: The failure

2018-10-23 Thread serguei . spitsyn
Okay, thanks! Serguei On 10/23/18 4:58 PM, David Holmes wrote: I should have looked further before sending this. Many threads are in smr_delete. David On 24/10/2018 9:56 AM, David Holmes wrote: Hi Serguei, Robbin, One thing I noticed which Robbin should be able to expand upon is that

Re: The failure

2018-10-23 Thread David Holmes
I should have looked further before sending this. Many threads are in smr_delete. David On 24/10/2018 9:56 AM, David Holmes wrote: Hi Serguei, Robbin, One thing I noticed which Robbin should be able to expand upon is that Thread 101 is terminating and has called

Re: The failure

2018-10-23 Thread David Holmes
Hi Serguei, Robbin, One thing I noticed which Robbin should be able to expand upon is that Thread 101 is terminating and has called ThreadsSMRSupport::smr_delete and is blocked here: // Wait for a release_stable_list() call before we check again. No // safepoint check, no timeout, and not

Re: The failure

2018-10-23 Thread serguei . spitsyn
Please, skip it - sorry for the noise. It is hard to prove anything with current dump. Thanks, Serguei On 10/23/18 9:09 AM, serguei.spit...@oracle.com wrote: Hi David and Robbin, I have an idea that needs to be checked. It can be almost the same deadlock scenario that I've already explained

Re: The failure

2018-10-23 Thread serguei . spitsyn
Hi David and Robbin, On 10/23/18 7:38 AM, Robbin Ehn wrote: Hi, On 10/23/18 10:34 AM, David Holmes wrote: Hi Serguei, The VMThread is executing VM_HandshakeAllThreads which is not a safepoint operation. There's no real way to tell from the stacks what it's stuck on. Good point. We

Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

2018-10-23 Thread dean . long
On 10/23/18 2:51 PM, David Holmes wrote: Hi Dean, On 24/10/2018 4:05 AM, dean.l...@oracle.com wrote: On 10/23/18 9:46 AM, dean.l...@oracle.com wrote: On 10/22/18 3:31 PM, David Holmes wrote: Sorry Dean I'm concerned about a thread termination bottleneck with this. A simple microbenchmark

Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

2018-10-23 Thread David Holmes
Hi Dean, On 24/10/2018 4:05 AM, dean.l...@oracle.com wrote: On 10/23/18 9:46 AM, dean.l...@oracle.com wrote: On 10/22/18 3:31 PM, David Holmes wrote: Sorry Dean I'm concerned about a thread termination bottleneck with this. A simple microbenchmark that creates 500,000 threads that have to

Re: 8196989: Revamp G1 JMX MemoryPool and GarbageCollector MXBean definitions

2018-10-23 Thread Man Cao
Hi Paul, I looked at the code in detail, and didn't find any major problem. A few small issues below. I'm not a Reviewer, though. File Separator-- In

Re: JDK-8211013: TESTBUG] nsk/jdb/kill/kill002 wait for message and prompt

2018-10-23 Thread Daniil Titov
Hi Gary, This change looks OK to me. Bets regards, Daniil On 10/23/18, 11:08 AM, "serviceability-dev on behalf of Gary Adams" wrote: Could I get a second reviewer for this change. On 10/15/18, 3:16 PM, Chris Plummer wrote: > Hi Gary, > > I think the simple prompt is

Re: RFR: JDK-8211013: TESTBUG] nsk/jdb/kill/kill002 wait for message and prompt

2018-10-23 Thread JC Beyler
Hi Gary, Looks good to me (not an official reviewer though), Jc On Tue, Oct 23, 2018 at 11:08 AM Gary Adams wrote: > Could I get a second reviewer for this change. > > On 10/15/18, 3:16 PM, Chris Plummer wrote: > > Hi Gary, > > > > I think the simple prompt is meant to indicate that execution

Re: RFR: JDK-8211013: TESTBUG] nsk/jdb/kill/kill002 wait for message and prompt

2018-10-23 Thread Gary Adams
Could I get a second reviewer for this change. On 10/15/18, 3:16 PM, Chris Plummer wrote: Hi Gary, I think the simple prompt is meant to indicate that execution is suspended, but there is no current thread. I don't think that is the case here, so probably best not to use your alternate

Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

2018-10-23 Thread dean . long
On 10/23/18 9:46 AM, dean.l...@oracle.com wrote: On 10/22/18 3:31 PM, David Holmes wrote: Sorry Dean I'm concerned about a thread termination bottleneck with this. A simple microbenchmark that creates 500,000 threads that have to run and terminate, shows a 15+% slowdown on my Linux box. I

Re: RFR(S) 8021335: Missing synchronization when reading counters for live threads and peak thread count

2018-10-23 Thread dean . long
On 10/22/18 3:31 PM, David Holmes wrote: Sorry Dean I'm concerned about a thread termination bottleneck with this. A simple microbenchmark that creates 500,000 threads that have to run and terminate, shows a 15+% slowdown on my Linux box. I tried to find some kind of real benchmarks that

Re: The failure

2018-10-23 Thread serguei.spit...@oracle.com
Hi David and Robbin, I have an idea that needs to be checked. It can be almost the same deadlock scenario that I've already explained but more sophisticated. I suspect a scenario with JvmtiThreadState_lock that the flag Monitor::_safepoint_check_always does not help much. It can be verified by

Re: RFR (M) 8212771: Remove remaining spaces before/after () for vmTestbase

2018-10-23 Thread Hohensee, Paul
Thanks for filing the new RFEs! Paul From: JC Beyler Date: Tuesday, October 23, 2018 at 7:49 AM To: "Hohensee, Paul" Cc: "serguei.spit...@oracle.com" , "serviceability-dev@openjdk.java.net" Subject: Re: RFR (M) 8212771: Remove remaining spaces before/after () for vmTestbase Hi Paul,

Re: The failure

2018-10-23 Thread Robbin Ehn
Hi, On 10/23/18 10:34 AM, David Holmes wrote: Hi Serguei, The VMThread is executing VM_HandshakeAllThreads which is not a safepoint operation. There's no real way to tell from the stacks what it's stuck on. I cannot find a thread that is not considered safepoint safe or is_ext_suspended

Re: RFR: 8196989: Revamp G1 JMX MemoryPool and GarbageCollector MXBean definitions

2018-10-23 Thread Thomas Schatzl
Hi Paul, sorry for the long wait. On Mon, 2018-10-08 at 23:49 +, Hohensee, Paul wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8196989 > CSR: https://bugs.openjdk.java.net/browse/JDK-8196991 > Webrev: http://cr.openjdk.java.net/~phh/8196989/webrev.02/ Note that I reviewed the

Re: RFR 8211736: jdb doesn't print prompt when breakpoint is hit and suspend policy is STOP_EVENT_THREAD

2018-10-23 Thread Gary Adams
Thanks for checking. I think it is Ok if the tests are only supported in the default locale. I think that restriction should be documented somewhere. If there is a simple way to check at runtime, we could issue a warning message. Definitely out of scope for this specific changeset. I wonder if

Re: The failure

2018-10-23 Thread David Holmes
Hi Serguei, The VMThread is executing VM_HandshakeAllThreads which is not a safepoint operation. There's no real way to tell from the stacks what it's stuck on. David On 23/10/2018 5:58 PM, serguei.spit...@oracle.com wrote: Hi David, You are right, thanks. It means, this deadlock needs

Re: The failure

2018-10-23 Thread David Holmes
Hi Serguei, The JvmtiThreadState_lock is always acquired with safepoint checks enabled, so all JavaThreads blocked trying to acquire it will be _thread_blocked and so safepoint-safe and so won't be holding up the safepoint. David On 23/10/2018 5:21 PM, serguei.spit...@oracle.com wrote:

Re: The failure

2018-10-23 Thread serguei.spit...@oracle.com
Hi, I've added the seviceability-dev mailing list. It can be interesting for the SVC folks. :) On 10/22/18 22:14, Leonid Mesnik wrote: Hi Seems last version also crashes with 2 other