Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd

2016-06-21 Thread Kevin Walls
150900/webrev.01/ Regards, Cheleswer From: Cheleswer Sahu Sent: Wednesday, May 11, 2016 2:29 PM To: Christian Thalinger Cc: Kevin Walls; Gerard Ziemski; serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: RE: RFR[9u-dev]: 8150900: Implement diagnostic_pd

Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd

2016-06-21 Thread Vladimir Kozlov
Walls; Gerard Ziemski; serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: RE: RFR[9u-dev]: 8150900: Implement diagnostic_pd Thanks Christian for review. I will correct the alignment. Regards, Cheleswer From: Christian Thalinger Sent: Wednesday, May 11, 2016 1

Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd

2016-05-24 Thread Kevin Walls
untime-...@openjdk.java.net Subject: RE: RFR[9u-dev]: 8150900: Implement diagnostic_pd Thanks Christian for review. I will correct the alignment. Regards, Cheleswer From: Christian Thalinger Sent: Wednesday, May 11, 2016 1:00 AM To: Cheleswer Sahu Cc: Kevin Walls; Gerard Ziemski; serviceabili

Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd

2016-05-24 Thread Gerard Ziemski
Regards, > Cheleswer > > From: Cheleswer Sahu > Sent: Wednesday, May 11, 2016 2:29 PM > To: Christian Thalinger > Cc: Kevin Walls; Gerard Ziemski; serviceability-dev@openjdk.java.net; > hotspot-runtime-...@openjdk.java.net > Subject: RE: RFR[9u-dev]: 8150900: I

RE: RFR[9u-dev]: 8150900: Implement diagnostic_pd

2016-05-24 Thread Cheleswer Sahu
Walls; Gerard Ziemski; serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: RE: RFR[9u-dev]: 8150900: Implement diagnostic_pd   Thanks Christian for review. I will correct the alignment.   Regards, Cheleswer   From: Christian Thalinger Sent: Wednesday, May 11

RE: RFR[9u-dev]: 8150900: Implement diagnostic_pd

2016-05-11 Thread Cheleswer Sahu
quot;d...@openjdk.java.net Subject: Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd Thanks Cheleswer, looks good to me too, have been over the macros as much as I can! Thanks Kevin On 03/05/2016 07:34, Cheleswer Sahu wrote: Hi Gerard, -Original Message- From: Gerard Ziem

Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd

2016-05-10 Thread Christian Thalinger
ge- >> From: Kevin Walls >> Sent: Friday, May 06, 2016 3:53 PM >> To: Cheleswer Sahu; Gerard Ziemski >> Cc: serviceability-dev@openjdk.java.net; hotspot-runtime- >> d...@openjdk.java.net >> Subject: Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd >> &

RE: RFR[9u-dev]: 8150900: Implement diagnostic_pd

2016-05-10 Thread Cheleswer Sahu
viceability-dev@openjdk.java.net; hotspot-runtime- > d...@openjdk.java.net > Subject: Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd > > > Thanks Cheleswer, looks good to me too, have been over the macros as > much as I can! > > Thanks > Kevin > > > > On

Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd

2016-05-06 Thread Kevin Walls
-...@openjdk.java.net; serviceability- d...@openjdk.java.net Subject: Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd hi Cheleswer, #1 Shouldn’t the following files be modified as well? : open: src/cpu/sparc/vm/globals_sparc.hpp src/cpu/x86/vm/globals_x86.hpp src/cpu/zero/vm/globals_zero.hpp closed: cpu

RE: RFR[9u-dev]: 8150900: Implement diagnostic_pd

2016-05-03 Thread Cheleswer Sahu
Hi Gerard, > -Original Message- > From: Gerard Ziemski > Sent: Monday, May 02, 2016 9:07 PM > To: Cheleswer Sahu > Cc: hotspot-runtime-...@openjdk.java.net; serviceability- > d...@openjdk.java.net > Subject: Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd > &g

Re: RFR[9u-dev]: 8150900: Implement diagnostic_pd

2016-05-02 Thread Gerard Ziemski
hi Cheleswer, #1 Shouldn’t the following files be modified as well? : open: src/cpu/sparc/vm/globals_sparc.hpp src/cpu/x86/vm/globals_x86.hpp src/cpu/zero/vm/globals_zero.hpp closed: cpu/arm/vm/globals_arm.hpp share/vm/runtime/globals_ext.hpp share/vm/runtime/os_ext.hpp #2 Bunch of header

RFR[9u-dev]: 8150900: Implement diagnostic_pd

2016-05-02 Thread Cheleswer Sahu
Hi, Please review the code changes for https://bugs.openjdk.java.net/browse/JDK-8150900. Webrev Link: http://cr.openjdk.java.net/~csahu/8150900/webrev.00/ Enhancement Brief: A new variant of flag "diagnostic_pd" is implemented. All flags which are diagnostic in nature and platform