On Fri, 17 May 2024 03:49:21 GMT, Quan Anh Mai wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: corrected the nullptr clarification
>
> src/hotspot/share/prims/jvmti.xml line 1007:
>
>> 1005:
On Fri, 31 May 2024 01:43:35 GMT, Serguei Spitsyn wrote:
> Okay. I've made a fix to replace in the docs nullptr with null pointer as you
> suggested.
What I suggested was
> returns _a_ null pointer
in place of
> returns `nulllptr`
but "a null pointer" doesn't always look right either e.g.
On Fri, 17 May 2024 04:34:22 GMT, Kim Barrett wrote:
> But this clarification doesn't actually clarify that the rest of the spec
> uses nullptr. Based on the proposed wording I would expect things like:
>
> The function may return nullptr
>
> to say
>
> The function may return a null pointer
On Fri, 17 May 2024 04:34:22 GMT, Kim Barrett wrote:
> So JDK-8324680 was somewhat mistaken about what needed to be done, and what
was done.
The `jvmti.xml` is used to generate several things with the XSL scripts:
- JVMTI spec (`jvm.html`)
- JVMTI api (`jvmti.h`)
- `jvmtiEnter.cpp`,
On Fri, 17 May 2024 00:38:07 GMT, Serguei Spitsyn wrote:
>> src/hotspot/share/prims/jvmti.xml line 1008:
>>
>>> 1006: function descriptions. Empty lists, arrays, sequences, etc are
>>> 1007: returned as nullptr which is C programming language
>>> 1008: null pointer.
>>
>> Perhaps
On Fri, 17 May 2024 02:00:29 GMT, David Holmes wrote:
> But this clarification doesn't actually clarify that the rest of the spec
> uses `nullptr`. Based on the proposed wording I would expect things like:
>
> ```
> The function may return nullptr
> ```
>
> to say
>
> ```
> The function may
On Fri, 17 May 2024 00:43:18 GMT, Serguei Spitsyn wrote:
>> The following RFE was fixed recently:
>> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
>> nullptr in JVMTI generated code
>>
>> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
>>
On Fri, 17 May 2024 00:43:18 GMT, Serguei Spitsyn wrote:
>> The following RFE was fixed recently:
>> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
>> nullptr in JVMTI generated code
>>
>> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
>>
On Fri, 17 May 2024 00:43:18 GMT, Serguei Spitsyn wrote:
>> The following RFE was fixed recently:
>> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
>> nullptr in JVMTI generated code
>>
>> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
>>
> The following RFE was fixed recently:
> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
> nullptr in JVMTI generated code
>
> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
> agents can be developed in C or C++.
> This update is to make it
On Thu, 16 May 2024 07:59:51 GMT, Kim Barrett wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: corrected the nullptr clarification
>
> src/hotspot/share/prims/jvmti.xml line 1008:
>
>> 1006:
On Thu, 16 May 2024 19:26:07 GMT, Chris Plummer wrote:
>> src/hotspot/share/prims/jvmti.xml line 1008:
>>
>>> 1006: function descriptions. Empty lists, arrays, sequences, etc are
>>> 1007: returned as nullptr which is C programming language
>>> 1008: null pointer.
>>
>> Shouldn't
12 matches
Mail list logo
