On Thu, 16 May 2024 19:26:07 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> src/hotspot/share/prims/jvmti.xml line 1008: >> >>> 1006: function descriptions. Empty lists, arrays, sequences, etc are >>> 1007: returned as <code>nullptr</code> which is C programming language >>> 1008: <code>null</code> pointer. >> >> Shouldn't this be "NULL"? In any case, I think it would be helpful to >> expand this a bit to make it clear that usages of "nullptr" in parameter and >> error descriptions should be read or treated as "NULL" when developing an >> agent in C rather than C++. > > Yes, I think it should by NULL. Thank you for suggestions. I've changed it as Kim suggested below. Please, let me know if it is not good enough, or some additions are needed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19257#discussion_r1604211567
