RFR: 8322065: Initial nroff manpage generation for JDK 23

2023-12-13 Thread David Holmes
Updated the version to 23-ea and year to 2024. This initial generation also picks up the unpublished changes from: - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool & jarsigner) - [JDK-8290702](https://bugs.openjdk.org/browse/JDK-8290702) (javadoc) (JDK 23 backport) -

Re: RFR: JDK-8318563: GetClassFields should not use random access to field

2023-12-13 Thread Serguei Spitsyn
On Wed, 13 Dec 2023 21:32:50 GMT, Alex Menkov wrote: > FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate > class fields in the reverse order and use field indexes to access instead of > forward iteration. This is performance ineffective (see >

Re: RFR: 8321404: Limit the number of heap dumps triggered by HeapDumpBeforeFullGC/AfterFullGC

2023-12-13 Thread Denghui Dong
On Wed, 6 Dec 2023 04:00:51 GMT, David Holmes wrote: >> Hi, >> >> Could I have a review of this patch? >> >> In the current implementation, HeapDumpBeforeFullGC/AfterFullGC will >> generate dumps for every FGC, increasing the risk of disk full. >> >> This patch introduces a new option

RFR: JDK-8318563: GetClassFields should not use random access to field

2023-12-13 Thread Alex Menkov
FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate class fields in the reverse order and use field indexes to access instead of forward iteration. This is performance ineffective (see [JDK-8317692](https://bugs.openjdk.org/browse/JDK-8317692) for details). The change

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v8]

2023-12-13 Thread Chris Plummer
On Wed, 13 Dec 2023 20:51:36 GMT, Dean Long wrote: > The man page says "no default value" but then right below describes the > default value, which is confusing. I would remove "no default value". This was copied from VM.cds, which pretty much does the same thing (says "no default value" and

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v8]

2023-12-13 Thread Dean Long
On Mon, 11 Dec 2023 22:41:56 GMT, Yi-Fan Tsai wrote: >> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: >> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a >> file name. >> >> `jcmd PID help Compiler.perfmap` shows the following usage. >> >>

Integrated: JDK-8321565: [REDO] Heap dump does not contain virtual Thread stack references

2023-12-13 Thread Alex Menkov
On Fri, 8 Dec 2023 22:29:12 GMT, Alex Menkov wrote: > Original fix for JDK-8299426 (Heap dump does not contain virtual Thread stack > references, #16665) caused failures of new test (added while #16665 was under > review): > test/hotspot/jtreg/compiler/c2/TestReduceAllocationAndHeapDump.java