On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
> agent_common.hpp.
>
> The #include updates were performed mechanically, and builds would fail if
>
On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
> agent_common.hpp.
>
> The #include updates were performed mechanically, and builds would fail if
>
On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
> agent_common.hpp.
>
> The #include updates were performed mechanically, and builds would fail if
>
On Fri, 23 Feb 2024 04:29:47 GMT, Kim Barrett wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/jvmti/Deallocate/dealloc001/dealloc001.cpp
>> line 28:
>>
>>> 26: #include "jvmti.h"
>>> 27: #include "agent_common.hpp"
>>> 28: #include "JVMTITools.h"
>>
>> Why don't you change all of these together?
On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
> agent_common.hpp.
>
> The #include updates were performed mechanically, and builds would fail if
>
On Fri, 23 Feb 2024 06:11:29 GMT, Julian Waters wrote:
> > Please review this trivial change
>
> This doesn't look trivial at all :P
While there are a lot of files being touched, the changes to all but one are
purely mechanical, no thinking required.
-
PR Comment:
On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett wrote:
> Please review this trivial change
This doesn't look trivial at all :P
-
Marked as reviewed by jwaters (Committer).
PR Review: https://git.openjdk.org/jdk/pull/17970#pullrequestreview-1897425509
On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
> agent_common.hpp.
>
> The #include updates were performed mechanically, and builds would fail if
>
On Thu, 22 Feb 2024 20:06:50 GMT, Coleen Phillimore wrote:
>> Please review this trivial change that renames the file
>> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
>> agent_common.hpp.
>>
>> The #include updates were performed mechanically, and builds would
On Fri, 23 Feb 2024 02:07:02 GMT, Dean Long wrote:
> If we wanted to minimize changes, we could have agent_common.h include
> agent_common.hpp. Then we don't have to change all the .cpp files, which have
> other problems, like the includes not being sorted.
The purpose of this exercise is to
On Fri, 23 Feb 2024 00:36:43 GMT, Serguei Spitsyn wrote:
> Looks good. I have a minor concern about the Copyright headers in 547 files.
> What is the ways to make sure they are updated?
Here's the bash script I used:
#!/usr/bin/env bash
for f in `git diff master --name-only`;
do
sed -i \
On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
> agent_common.hpp.
>
> The #include updates were performed mechanically, and builds would fail if
>
On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
> agent_common.hpp.
>
> The #include updates were performed mechanically, and builds would fail if
>
On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
> agent_common.hpp.
>
> The #include updates were performed mechanically, and builds would fail if
>
Please review this trivial change that renames the file
test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
agent_common.hpp.
The #include updates were performed mechanically, and builds would fail if
there were mistakes.
The copyright updates were similarly performed
15 matches
Mail list logo
