Nice job.
I found a minor nag inline while skimming but it makes sense for ack or bjorn
to have another look.
Diff comments:
> diff --git a/src/maasserver/utils/tests/test_fast_client.py
> b/src/maasserver/utils/tests/test_fast_client.py
> new file mode 100644
> index 000..676c9f0
> ---
Review: Approve
looking good!
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/443428
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:token-csv-export.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
lgtm!
One thing: We could also test if get_active_tokens is getting only active tokens
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/443428
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:token-csv-export.
--
Mailing
Review: Needs Information
Thanks for that idea and the pointer to DEBUG being enabled.
As discussed on Mattermost, it might be simpler to try with DEBUG turned off
first (assuming this is the simpler change and does also turn off all sql
logging).
--
The proposal to merge
~thorsten-merten/maas-site-manager:1529-add-name-unique-property2 into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/442
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:1529-add-name-unique-property2 into
maas-site-manager:main.
Commit message:
feat: add name_duplicate column
* add column
* remove uniqueness constraint on name
* update test data and import script
Requested reviews
The proposal to merge
~thorsten-merten/maas-site-manager:1529-add-name-unique-property into
maas-site-manager:main has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/442
Review: Needs Resubmitting
messed up my git history
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/442834
Your team MAAS Committers is subscribed to branch
~thorsten-merten/maas-site-manager:1529-add-name-unique-property.
--
Mailing list: https
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:1529-add-name-unique-property into
maas-site-manager:main.
Commit message:
feat: add name_unique property
also remove uniqueness of the name column
Requested reviews:
MAAS Committers (maas-committers)
For more details
Review: Approve
+1
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442742
Your team MAAS Committers is subscribed to branch
~petermakowski/maas-site-manager:add-total_machines-key.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
+1
--
https://code.launchpad.net/~adam-collard/maas/+git/maas-release-tools/+merge/442591
Your team MAAS Committers is subscribed to branch
~maas-committers/maas/+git/maas-release-tools:main.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
nice refactor.
Small note: While scrolling through I noticed that Sites are defined quite
often in the same way. Maybe we can add a place to import some fixture
definitions from.
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/442485
Your team MAAS
Review: Approve
LGTM
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/442480
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:api-naming-consistency.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
+1
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/442474
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:row-count-helper.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
+1
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/442472
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:pending-sites-action.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Needs Fixing code
One idea for the future, one idea for naming and one improvement for the tests
inline.
Diff comments:
> diff --git a/backend/msm/db/queries.py b/backend/msm/db/queries.py
> index 3e51fbb..b46f105 100644
> --- a/backend/msm/db/queries.py
> +++
one first idea inline
Diff comments:
> diff --git a/frontend/src/components/Navigation/Navigation.tsx
> b/frontend/src/components/Navigation/Navigation.tsx
> index 701e93c..1b39a24 100644
> --- a/frontend/src/components/Navigation/Navigation.tsx
> +++
Review: Approve
+1
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/442139
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:tox-shell-env-fix.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
lgtm, thanks for pinning
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/442135
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:tox-ini-pin-deps.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
The proposal to merge
~thorsten-merten/maas-site-manager:change-login-to-send-json into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/441
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:change-login-to-send-json into
maas-site-manager:main.
Commit message:
refactor: change login credentials
change test data to be compatible with backend test data.
This way the playwright test succeeds against the mock
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:fix-users-me-2 into maas-site-manager:main.
Commit message:
fix: derive UserWithPassword from User to include id
fixes /users/me url
Requested reviews:
Jack Lloyd-Walters (lloydwaltersj)
MAAS Lander (maas-lander
The proposal to merge ~thorsten-merten/maas-site-manager:fix-users-me into
maas-site-manager:main has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/441751
--
Your team M
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:fix-users-me into maas-site-manager:main.
Commit message:
fix: derive UserWithPassword from User to include id
fixes /users/me url
Requested reviews:
Jack Lloyd-Walters (lloydwaltersj)
MAAS Lander (maas-lander
The proposal to merge ~thorsten-merten/maas-site-manager:fix-users-me into
maas-site-manager:main has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/441700
--
Your team M
looks more complicated than it is because the order was changed, actually only
UserWithPassword changed to be derived from User instead of ReadUser
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/441700
Your team MAAS Committers is requested
The proposal to merge ~thorsten-merten/maas-site-manager:fix-users-me into
maas-site-manager:main has been updated.
Description changed to:
fix: derive UserWithPassword from User to include id
fixes /users/me url
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:fix-users-me into maas-site-manager:main.
Commit message:
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager
The proposal to merge ~thorsten-merten/maas-site-manager:fix-compose-env into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/441682
--
Your t
jenkins: !test
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/441682
Your team MAAS Committers is subscribed to branch
~thorsten-merten/maas-site-manager:fix-compose-env.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:fix-compose-env into maas-site-manager:main.
Commit message:
fix: typo
add stylelint MAASENG-1594
- add stylelint, stylelint-config-standard-scss, vite-plugin-stylelint
refactor: remove duplicated await
Requested
Could you also add negative tests (i.e. login without correct password should
not work, get with incorrect token should not work).
--
https://code.launchpad.net/~lloydwaltersj/maas-site-manager/+git/site-manager/+merge/440870
Your team MAAS Committers is requested to review the proposed merge of
Review: Approve
+1
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441663
Your team MAAS Committers is subscribed to branch
~petermakowski/maas-site-manager:docs-readme-path.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
nicer
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/441556
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:uvicorn-deps-pyproject.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
lgtm
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/441547
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:timezone-text.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
The proposal to merge
~thorsten-merten/maas-site-manager:make-tox-rebuild-reqs-add-healthcheck into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+me
Review: Approve
TIL - BaseSettings. Nice, also nice that you have Fields in here. Thought for
the future inline.
Diff comments:
> diff --git a/backend/msm/user_api/_setup.py b/backend/msm/user_api/_setup.py
> index 03b9d18..29d8437 100644
> --- a/backend/msm/user_api/_setup.py
> +++
Review: Approve
+1
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/441168
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:filters-group.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Review: Needs Fixing
Diff comments:
> diff --git a/backend/msm/db/queries.py b/backend/msm/db/queries.py
> index 8a3bd32..c8369f9 100644
> --- a/backend/msm/db/queries.py
> +++ b/backend/msm/db/queries.py
> @@ -30,7 +33,7 @@ from ._tables import (
>
> def filters_from_arguments(
>
please see my comments above and latest changes
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/441106
Your team MAAS Committers is requested to review the proposed merge of
~thorsten-merten/maas-site-manager:make-tox-rebuild-reqs-add-healthcheck
Sure. In the one we're currently using in the current version. Python will
always need to be included.
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/441106
Your team MAAS Committers is requested to review the proposed merge of
~thorsten-merten
://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/441106
Your team MAAS Committers is requested to review the proposed merge of
~thorsten-merten/maas-site-manager:make-tox-rebuild-reqs-add-healthcheck into
maas-site-manager:main.
--
Mailing list: https
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:make-tox-rebuild-reqs-add-healthcheck into
maas-site-manager:main.
Commit message:
chore: tox should rebuild dependencies on --build
also adds healthcheck
Requested reviews:
MAAS Committers (maas-committers)
For more
Review: Approve
very good
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/441105
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:uvicorn-deps.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
+1
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/441070
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:varchar-to-text.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
one minor slash inline
Diff comments:
> diff --git a/.env b/.env
> index 797df3b..5407c53 100644
> --- a/.env
> +++ b/.env
> @@ -1,2 +1,3 @@
> VITE_UI_PORT=8405
> VITE_API_URL=http://localhost:8000
> +VITE_SENTRY_DSN="https://7236de0eb0354e2099b7efd7d310a...@sentry.is.canonical.com//60;
a
Review: Approve
+1
While reading the update I noticed that we're not really validating and
checking validation (especially now that we're using strings for lat/long we
could add some validation to the schema). But that's for a different MP.
--
Review: Approve
looking good. Nice to have sqlalchemy queries
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/440968
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:count-queries.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post
Review: Approve
+1
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/440941
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:site-stats.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Review: Approve
+1
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/440940
Your team MAAS Committers is subscribed to branch
~petermakowski/maas-site-manager:set-correct-fonts-path.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
+1
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/440927
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:import-data-script-cleanups.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
+1
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/440854
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:move-backend-tests.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
+1
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/440847
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:tox-ini-fmt.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Diff comments:
> diff --git a/frontend/src/components/NoRegions/NoRegions.tsx
> b/frontend/src/components/NoRegions/NoRegions.tsx
> new file mode 100644
> index 000..a857257
> --- /dev/null
> +++ b/frontend/src/components/NoRegions/NoRegions.tsx
> @@ -0,0 +1,50 @@
> +import { Link } from
Review: Approve
Awesome! I feel that this works for now.
As discussed, we should think about how we can improve tests running and factor
out stuff in a base image (or even use multiple/smaller images as are having
quite some dependencies due to the mono repo).
--
Review: Approve
much nicer structure
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/439741
Your team MAAS Committers is subscribed to branch
~petermakowski/maas-site-manager:move-sites-components-to-folders.
--
Mailing list:
The proposal to merge
~thorsten-merten/maas-site-manager:MAASENG-1497-pagination into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/439629
--
Y
The proposal to merge
~thorsten-merten/maas-site-manager:MAASENG-1497-pagination into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/439629
--
Y
jenkins: !test
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/439629
Your team MAAS Committers is subscribed to branch
~thorsten-merten/maas-site-manager:MAASENG-1497-pagination.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post
changed to be single _ vars.
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/439629
Your team MAAS Committers is subscribed to branch
~thorsten-merten/maas-site-manager:MAASENG-1497-pagination.
--
Mailing list: https://launchpad.net/~sts-sponsors
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:MAASENG-1497-pagination into
maas-site-manager:main.
Commit message:
feat: WIP add pagination and update tests
* add window function to get total count
* change tests to use async httpx client
so we can make multiple
jenkins: !test
more timeouts
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/439607
Your team MAAS Committers is requested to review the proposed merge of
~ack/maas-site-manager:drop-setup-py-cfg into maas-site-manager:main.
--
Mailing list:
Review: Approve
all in favor :)
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/439604
Your team MAAS Committers is subscribed to branch
~petermakowski/maas-site-manager:eslint-restrict-enum.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to
CSV files available that can be used as test data.
> +
> +If you are running the app in docker you can easily load those
> +
> +- go to the test data directory `cd ../testdata`
> +- run the loading script `./import.sh`
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+
The proposal to merge
~thorsten-merten/maas-site-manager:MAASENG-1486-add-testdata into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/439
> -identifier: str
> city: str | None
> -latitude: str | None
> -longitude: str | None
> +latitude: str | Decimal | None
Changing to string only as it is used to convert incoming data automatically
(coming as strings from via JSON)
> +longitude: str | Decimal | No
does not help to find actual problems.
That is why I am trying this approach. (You can also scale up tables with faker
in a later step).
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/439266
Your team MAAS Committers is subscribed to branch
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:MAASENG-1486-add-testdata into
maas-site-manager:main.
Commit message:
feat: add test data and import tools
docs: add documentation wrt test data
* how to clear db
* how to add test data
feat: make datamodel reflect input
Review: Approve
I understand this as a first step and that we can transfer more deps to this
image in a next step (e.g. yarnpkg).
One minor nag line.
Diff comments:
> diff --git a/Dockerfile b/Dockerfile
> index fdbc3c6..18e89d6 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -22,23 +19,17
Site.c.note,
> +Site.c.region,
> +Site.c.street,
> +Site.c.timezone,
> + Site.c.url,
> +).where(where)
> +result = await session.execute(stmt)
> +return (row._asdict() for row in result.all())
> +
> +
> async def get_site
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:MAASENG-1290-add-filter-to-sites into
maas-site-manager:main.
Commit message:
feat: add filters to sites list view
see MAASENG-1390 and MAASENG-1290
Requested reviews:
MAAS Committers (maas-committers)
For more
The proposal to merge
~thorsten-merten/maas-site-manager:MAASENG-1465-add-cors-middleware into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/438
@adam-collard: true, removed
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/438465
Your team MAAS Committers is subscribed to branch
~thorsten-merten/maas-site-manager:MAASENG-1465-add-cors-middleware.
--
Mailing list: https://launchpad.net/~sts
in this
file.
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/438465
Your team MAAS Committers is requested to review the proposed merge of
~thorsten-merten/maas-site-manager:MAASENG-1465-add-cors-middleware into
maas-site-manager:main.
--
Mailing list
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:MAASENG-1465-add-cors-middleware into
maas-site-manager:main.
Commit message:
feat: add CORS middleware and allow dev env
basically makes this work:
curl -H "Access-Control-Request-Method: GET" -H "Origin:
h
The proposal to merge
~thorsten-merten/maas-site-manager:MAASENG-1451-setup-docker-compose into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+me
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:MAASENG-1451-setup-docker-compose into
maas-site-manager:main.
Commit message:
feat: add docker-compose to easily run backend + db
* add docker-compose.yaml
* add .env.dev file to share db secrets
* add backend Dockerfiles
The proposal to merge ~thorsten-merten/maas-site-manager:install-node-from-snap
into maas-site-manager:main has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/438132
--
Y
Review: Disapprove
Docker and snaps do not seem to play nicely together.
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/438132
Your team MAAS Committers is subscribed to branch
~thorsten-merten/maas-site-manager:install-node-from-snap
The proposal to merge ~petermakowski/maas-site-manager:update-fe-lint into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/438119
--
Your team MAAS
retrying landing with new configuration
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/438127
Your team MAAS Committers is subscribed to branch
~thorsten-merten/maas-site-manager:fix-readme.
--
Mailing list: https://launchpad.net/~sts-sponsors
The proposal to merge ~thorsten-merten/maas-site-manager:fix-readme into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/438127
--
Your team M
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:install-node-from-snap into
maas-site-manager:main.
Commit message:
ci: install node from snap
this way we can change CI back to use Ubuntu LTS instead of 22.10
Requested reviews:
MAAS Committers (maas-committers
The proposal to merge ~thorsten-merten/maas-site-manager:fix-readme into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/438127
--
Your team M
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:fix-readme into maas-site-manager:main.
Commit message:
docs: fix readme
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:fix-readme into maas-site-manager:main.
Commit message:
docs: fix readme
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas
just a test of git-lp-tools. will resubmit
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/438124
Your team MAAS Committers is requested to review the proposed merge of
~thorsten-merten/maas-site-manager:fix-readme into maas-site-manager:main
Review: Needs Resubmitting
As discussed, please resubmit the changes to the new monorepo
--
https://code.launchpad.net/~maas-committers/maas-site-manager/+git/maas-site-manager-frontend/+merge/437941
Your team MAAS Committers is subscribed to branch
frontend/main
with frontend pointing to
git+ssh://...@git.launchpad.net/~maas-committers/maas-site-manager/+git/maas-site-manager-frontend
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/437943
Your team MAAS Committers is subscribed to branch
~thorsten
jenkins: !test
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/437943
Your team MAAS Committers is requested to review the proposed merge of
~thorsten-merten/maas-site-manager:MAASENG-1285-merge-frontend into
maas-site-manager:main.
--
Mailing
jenkins: !test
Please try it with 22.10 my friend.
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/437943
Your team MAAS Committers is requested to review the proposed merge of
~thorsten-merten/maas-site-manager:MAASENG-1285-merge-frontend
@Nick: Yeah, I will check if we can run a more recent Ubuntu version and/or
find other ways to run it.
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/437943
Your team MAAS Committers is requested to review the proposed merge of
~thorsten-merten
The proposal to merge ~thorsten-merten/maas-site-manager:MAASENG-1285-monorepo
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/437893
--
Y
Thorsten Merten has proposed merging
~thorsten-merten/maas-site-manager:MAASENG-1285-monorepo into
maas-site-manager:main.
Commit message:
chore: move everything to backend dir to prepare mono repo
We will soon merge the frontend and agent into this codebase
to the backend has to make room
The proposal to merge
~maas-committers/maas-site-manager/+git/maas-site-manager-frontend:setup-e2e-tests-MAASENG-1397
into ~maas-committers/maas-site-manager/+git/maas-site-manager-frontend:main
has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
awesome!
--
https://code.launchpad.net/~maas-committers/maas-site-manager/+git/maas-site-manager-frontend/+merge/437877
Your team MAAS Committers is requested to review the proposed merge of
The proposal to merge
~thorsten-merten/maas-site-manager:MAASENG-1290-extend-models-and-views into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+me
Review: Needs Information
Did you try to run the iPhone safari test on Linux? In case that does not work,
we will need to create a condition as it would also break CI.
--
https://code.launchpad.net/~maas-committers/maas-site-manager/+git/maas-site-manager-frontend/+merge/437877
Your team MAAS
Review: Approve
Small inline ask for comment.
I guess I will ask for lots of comments in the near future. But maybe we'll get
more react NOOBs and my nagging will help them, too :)
Diff comments:
> diff --git a/src/test-utils.tsx b/src/test-utils.tsx
> new file mode 100644
> index
+Column("id", Integer, primary_key=True, index=True),
> +Column(
> + "site_id", Integer, ForeignKey("site.id"), index=True, nullable=False
> +),
> +Column("total_machines", Integer),
> +Column("occupied_machines", Int
1 - 100 of 117 matches
Mail list logo
