Hi everyone,
Could you please review and sponsor tracker-miners in the below
Launchpad bug for Denison and I? We have been working on this for a
while, and we finally have the right service ordering in place.
https://bugs.launchpad.net/ubuntu/+source/tracker-miners/+bug/1779890
Thanks,
Matthew
** Changed in: tang (Ubuntu Focal)
Status: In Progress => Incomplete
--
You received this bug notification because you are a member of SE
("STS") Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1930203
Title:
ordering cycle after reboot
Status in tang
It's probably also worth adding to the Test Plan to ensure the
configuration is indeed the same in both cases.
--
You received this bug notification because you are a member of SE
("STS") Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1930203
Title:
ordering
> +-WantedBy=multi-user.target
> ++WantedBy=sockets.target
The above is in the Install section. I checked what happens on upgrade,
and found that /etc/systemd/system/multi-user.target.wants/tangd.socket
does not get replaced with
/etc/systemd/system/sockets.target.wants/tangd.socket. So this SRU
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: arm64
* Pocket: UPDATES
* State: Failed to build
* Duration: 15 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: ppc64el
* Pocket: UPDATES
* State: Failed to build
* Duration: 10 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: s390x
* Pocket: UPDATES
* State: Failed to build
* Duration: 10 minutes
* Build Log:
The proposal to merge ~troyanov/maas:maas-agent into maas:master has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/441357
--
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list:
Review: Approve
UNIT TESTS
-b maas-agent lp:~troyanov/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: 6dc8c92a062398930dcd4e1584d5b156af562cde
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/441357
Your team MAAS Committers is subscribed to branch
The proposal to merge ~troyanov/maas:maas-agent into maas:master has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/441357
--
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list:
Review: Approve
+1
--
https://code.launchpad.net/~igor-brovtsin/maas/+git/maas/+merge/441474
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
UNIT TESTS
-b dgx-clarity-renames lp:~igor-brovtsin/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2351/consoleText
COMMIT: 2c8ed42a9514ffa7688b9da33fe3f8b97373b797
--
Igor Brovtsin has proposed merging ~igor-brovtsin/maas:dgx-clarity-renames into
maas:master.
Commit message:
Clarity renames for kernel-related methods
Requested reviews:
MAAS Maintainers (maas-maintainers)
For more details, see:
The proposal to merge ~ack/maas-site-manager:settings-module into
maas-site-manager:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/441473
--
Your team MAAS Committers is subscribed to
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: arm64
* Pocket: UPDATES
* State: Failed to build
* Duration: 15 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: ppc64el
* Pocket: UPDATES
* State: Failed to build
* Duration: 10 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: s390x
* Pocket: UPDATES
* State: Failed to build
* Duration: 10 minutes
* Build Log:
Review: Approve
UNIT TESTS
-b settings-module lp:~ack/maas-site-manager/+git/site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: 14f51c8598f77670d5b22697440f10c2adff7872
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/441473
The proposal to merge ~ack/maas-site-manager:settings-module into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/441473
--
Your team MAAS Committers is subscribed to
The proposal to merge
~petermakowski/maas-site-manager:settings-subnavigation-MAASENG-1508 into
maas-site-manager:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441449
--
Your
Review: Approve
TIL - BaseSettings. Nice, also nice that you have Fields in here. Thought for
the future inline.
Diff comments:
> diff --git a/backend/msm/user_api/_setup.py b/backend/msm/user_api/_setup.py
> index 03b9d18..29d8437 100644
> --- a/backend/msm/user_api/_setup.py
> +++
The proposal to merge ~troyanov/maas:go-style-doc into maas:master has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/440865
--
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list:
Review: Needs Fixing
UNIT TESTS
-b add-login lp:~lloydwaltersj/maas-site-manager/+git/site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/390/consoleText
COMMIT: 4d0c63d072af0e4650dabfa10fba084f2b464916
--
The proposal to merge
~petermakowski/maas-site-manager:settings-subnavigation-MAASENG-1508 into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441449
--
E2E test sounds like a good idea, I might look into this once all recent
changes get merged to make this easier.
Diff comments:
> diff --git a/frontend/src/routes/routes.tsx b/frontend/src/routes/routes.tsx
> index 8b6e071..466ac30 100644
> --- a/frontend/src/routes/routes.tsx
> +++
Alberto Donato has proposed merging ~ack/maas-site-manager:settings-module into
maas-site-manager:main.
Commit message:
collect global setings for the application in a module.
This allows overriding default values via MSM_-prefixed vars and makes
allowed_origins configurable
Requested
Review: Approve
This is good to merge IMO. One comment below but this is optional. Might also
be worth writing an E2E test for the secondary nav behaviour but I'll leave
that up to you
Diff comments:
> diff --git a/frontend/src/routes/routes.tsx b/frontend/src/routes/routes.tsx
> index
Review: Needs Fixing
UNIT TESTS
-b 1570-fix-login-navbar
lp:~jonesogolo/maas-site-manager/+git/maas-site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/389/consoleText
COMMIT:
The proposal to merge ~troyanov/maas:go-style-doc into maas:master has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/440865
--
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing
Review: Approve
UNIT TESTS
-b settings-subnavigation-MAASENG-1508
lp:~petermakowski/maas-site-manager/+git/site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: 6ad8cfdedbd394c209f474affd4caf531d2e5325
--
Review: Approve
UNIT TESTS
-b go-style-doc lp:~troyanov/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: 463577335b7421919d36a166a2ada8fc8078c9d7
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/440865
Your team MAAS Committers is subscribed to branch
Review: Approve
+1 nice work
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/440865
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
jenkins: !test
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/440865
Your team MAAS Maintainers is requested to review the proposed merge of
~troyanov/maas:go-style-doc into maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
The proposal to merge ~ack/maas-site-manager:timezone-filter-fix into
maas-site-manager:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/441168
--
Your team MAAS Committers is subscribed to
Review: Approve
UNIT TESTS
-b settings-subnavigation-MAASENG-1508
lp:~petermakowski/maas-site-manager/+git/site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: de87c42f31b96ba8f52b02c326d395fa0c2242d4
--
The proposal to merge ~ack/maas-site-manager:timezone-filter-fix into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/441168
--
Your team MAAS Committers is
The proposal to merge ~petermakowski/maas-site-manager:add-404-element into
maas-site-manager:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441350
--
Your team MAAS Committers is
The proposal to merge
~petermakowski/maas-site-manager:sidenav-collapse-on-route-change-MAASENG-1576
into maas-site-manager:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441338
Review: Needs Fixing
UNIT TESTS
-b go-style-doc lp:~troyanov/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2348/consoleText
COMMIT: 463577335b7421919d36a166a2ada8fc8078c9d7
--
Review: Needs Fixing
UNIT TESTS
-b settings-subnavigation-MAASENG-1508
lp:~petermakowski/maas-site-manager/+git/site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/378/consoleText
COMMIT:
The proposal to merge ~petermakowski/maas-site-manager:add-404-element into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441350
--
Your team MAAS
The proposal to merge
~petermakowski/maas-site-manager:sidenav-collapse-on-route-change-MAASENG-1576
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
Diff comments:
> diff --git a/frontend/src/components/Navigation/Navigation.test.tsx
> b/frontend/src/components/Navigation/Navigation.test.tsx
> index e0609fc..a5715e2 100644
> --- a/frontend/src/components/Navigation/Navigation.test.tsx
> +++
Review: Approve
UNIT TESTS
-b 1570-fix-login-navbar
lp:~jonesogolo/maas-site-manager/+git/maas-site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: a99db858288914df77601162152c7eea6603ab78
--
Review: Approve
+1
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/441168
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:filters-group.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Jones Ogolo has proposed merging
~jonesogolo/maas-site-manager:1570-fix-login-navbar into maas-site-manager:main.
Commit message:
Enable sidebar on login page
Requested reviews:
MAAS Lander (maas-lander): unittests
MAAS Committers (maas-committers)
For more details, see:
Review: Needs Fixing
UNIT TESTS
-b settings-subnavigation-MAASENG-1508
lp:~petermakowski/maas-site-manager/+git/site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/376/consoleText
COMMIT:
Review: Approve code, qa
LGTM
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441350
Your team MAAS Committers is subscribed to branch
~petermakowski/maas-site-manager:add-404-element.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve code, qa
LGTM
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441338
Your team MAAS Committers is subscribed to branch
~petermakowski/maas-site-manager:sidenav-collapse-on-route-change-MAASENG-1576.
--
Mailing list:
Diff comments:
> diff --git a/backend/msm/db/queries.py b/backend/msm/db/queries.py
> index 8a3bd32..c8369f9 100644
> --- a/backend/msm/db/queries.py
> +++ b/backend/msm/db/queries.py
> @@ -30,7 +33,7 @@ from ._tables import (
>
> def filters_from_arguments(
> table: Table,
> -
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:settings-subnavigation-MAASENG-1508 into
maas-site-manager:main.
Commit message:
add settings sub-nav MAASENG-1508
- fix baseline top margin MAASENG-1573
- fix invalid scss file import
Requested reviews:
MAAS Committers
The proposal to merge
~petermakowski/maas-site-manager:settings-subnavigation-MAASENG-1508 into
maas-site-manager:main has been updated.
Description changed to:
QA Steps
Login go to settings
Ensure the secondary navigation is shown and you can use it to navigate to both
Tokens and Requests
The proposal to merge
~petermakowski/maas-site-manager:settings-subnavigation-MAASENG-1508 into
maas-site-manager:main has been updated.
Commit message changed to:
add settings sub-nav MAASENG-1508
- fix baseline top margin MAASENG-1573
- fix invalid scss file import
For more details, see:
The proposal to merge
~petermakowski/maas-site-manager:settings-subnavigation-MAASENG-1508 into
maas-site-manager:main has been updated.
Commit message changed to:
add settings sub-nav MAASENG-1508
- fix baseline top margin MAASENG-1573
For more details, see:
Review: Needs Fixing
UNIT TESTS
-b add-login lp:~lloydwaltersj/maas-site-manager/+git/site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/373/consoleText
COMMIT: 70b3a3b75dbb3e444fd2d11d7748975822b39ee8
--
Review: Approve
UNIT TESTS
-b maas-agent lp:~troyanov/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: 698de23028f5dda899dd31d48583af71ee76b98d
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/441357
Your team MAAS Committers is subscribed to branch
Review: Approve
UNIT TESTS
-b 1562-fix-pagination-component
lp:~jonesogolo/maas-site-manager/+git/maas-site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: f78459664c12f5f527ecaa7612c6b124b004126a
--
Review: Approve
UNIT TESTS
-b go-style-doc lp:~troyanov/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: a3426452f624125451709cad1ab5c5d69376cb5f
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/440865
Your team MAAS Maintainers is requested to review
Jones Ogolo has proposed merging
~jonesogolo/maas-site-manager:1562-fix-pagination-component into
maas-site-manager:main.
Commit message:
fix pagination component on MAAS site manager
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
jenkins: !test
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/441357
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
jenkins: !test
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/440865
Your team MAAS Maintainers is requested to review the proposed merge of
~troyanov/maas:go-style-doc into maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Diff comments:
> diff --git a/Makefile b/Makefile
> index ad5452d..86cccb6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -54,7 +54,7 @@ ci-backend-build: # nothing to do since everything is run
> in tox envs
> .PHONY: ci-backend-build
>
> ci-backend-lint:
> - env -C backend tox -e
Review: Needs Fixing
Diff comments:
> diff --git a/backend/msm/db/queries.py b/backend/msm/db/queries.py
> index 8a3bd32..c8369f9 100644
> --- a/backend/msm/db/queries.py
> +++ b/backend/msm/db/queries.py
> @@ -30,7 +33,7 @@ from ._tables import (
>
> def filters_from_arguments(
>
please see my comments above and latest changes
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/441106
Your team MAAS Committers is requested to review the proposed merge of
~thorsten-merten/maas-site-manager:make-tox-rebuild-reqs-add-healthcheck
Diff comments:
> diff --git a/docker-compose.yaml b/docker-compose.yaml
> index b1dbec9..38e90ad 100644
> --- a/docker-compose.yaml
> +++ b/docker-compose.yaml
> @@ -30,6 +30,11 @@ services:
>- "8000:8000"
> links:
>- "postgres:db"
> +healthcheck:
> + test:
Review: Approve
UNIT TESTS
-b timezone-filter-fix lp:~ack/maas-site-manager/+git/site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: 0f0c85c4688a4ae291fa42f1f640384f794a7fd6
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/441168
This is looking great! Just one thing:
- Tooltips should be activated via a button allowing keyboard access. You will
need to wrap each element that's meant to trigger a tooltip with a plain
button. Refer to maas-ui where we do similar thing.
--
Review: Needs Fixing
UNIT TESTS
-b maas-agent lp:~troyanov/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2345/consoleText
COMMIT: 698de23028f5dda899dd31d48583af71ee76b98d
--
Sure. In the one we're currently using in the current version. Python will
always need to be included.
--
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/441106
Your team MAAS Committers is requested to review the proposed merge of
> I think launchpad ate my comment: @ack: I removed the .status and the http
> call fails on non-success status codes (returning a non 0 exit code). This way
> we don't have to introduce curl/wget as additional dependency to the image (in
> case the base image does not have it included).
Curl
70 matches
Mail list logo
