[PATCH] efi_loader: address coverity report 492766 for dead code

2024-04-22 Thread Ilias Apalodimas
The check of the return code is already done a few lines above. Although it doesn't cause any functional issues, remove the superfluous checks Addresses-Coverity-ID: 492766 Control flow issues (DEADCODE) Signed-off-by: Ilias Apalodimas --- lib/efi_loader/efi_var_mem.c | 2 -- 1 file changed, 2

Re: RISC-V u-boot unable to boot QEMU using '-cpu max'

2024-04-22 Thread Leo Liang
On Mon, Apr 22, 2024 at 04:43:59PM -0300, Daniel Henrique Barboza wrote: > [EXTERNAL MAIL] > > Hi, > > In QEMU we have a 'max' type CPU that implements (almost) all extensions that > QEMU > is able to emulate. Recently, in QEMU commit 249e0905d05, we bumped the > extensions > for this CPU. >

[PATCH] mmc: Change the frequency to MMC_HS_52 when selecting hs400

2024-04-22 Thread Venkatesh Yadav Abbarapu
Per JESD84-B51 P47, host need to change frequency to <=52MHz after setting HS_TIMING to 0x1, and host need to set the 8-bit DDR buswidth. Currently setting the frequency to 26MHz and trying to switch 8-bit DDR buswidth resulting timeouts. mmc dev 1 0 Select HS400 failed -110 switch to partitions

Re: BTRFS use-after-free bug at free_extent_buffer_internal

2024-04-22 Thread Sachi King
On Monday 22 April 2024 5:15:50 PM AEST Qu Wenruo wrote: > > 在 2024/4/22 16:07, Sachi King 写道: > > Hi, > > > > I've hit a bug with u-boot on my BTRFS filesystem, and I'm fairly certain > > it's a bug and not a corruption issue. > > > > A bit of history on the filesystem. It is a fairly new

Re: [PATCH] usb: dwc3: support USB 3.1 controllers

2024-04-22 Thread Marek Vasut
On 4/22/24 12:53 PM, Caleb Connolly wrote: On 21/04/2024 22:38, Marek Vasut wrote: On 4/11/24 6:05 PM, Caleb Connolly wrote: The revision is different for these, add the additional check as in xhci-dwc3 core_init code. Signed-off-by: Caleb Connolly Is there a matching Linux kernel patch ,

Re: [PATCH] usb: dwc2: update reset method for host and device mode

2024-04-22 Thread Marek Vasut
On 4/22/24 7:31 AM, Kongyang Liu wrote: [...] @@ -167,9 +168,20 @@ static void dwc_otg_core_reset(struct udevice *dev, dev_info(dev, "%s: Timeout!\n", __func__); /* Core Soft Reset */ + snpsid = readl(>gsnpsid); writel(DWC2_GRSTCTL_CSFTRST, >grstctl); -

Re: [PATCH 1/2] rockchip: rk3588: add support for UART2 M1 and M2 in SPL

2024-04-22 Thread Kever Yang
Hi Quentin, On 2024/4/23 00:41, Quentin Schulz wrote: From: Quentin Schulz UART2 controller is the controller in the reference design for debug console. The default mux is M0 in that reference design. Until now, all boards seemed to be using UART2M0 but RK3588 Tiger for example will be using

Re: [PATCH 1/2] arm: dts: k3-j721e-binman: Add support for HSSE2.0 and HSFS1.1

2024-04-22 Thread Neha Malcom Francis
Hi Andrew, On 22-Apr-24 3:37 AM, Andrew Davis wrote: On 4/22/24 4:40 PM, Neha Malcom Francis wrote: J721E has SR1.1 and SR2.0 having three variants of each GP, HS-FS and HS-SE. Current build does not generate HS-SE SR2.0 and HS-FS SR1.1 so add support for them. Reported-by: Suman Anna

Re: [PATCH 1/2] arm: dts: k3-j721e-binman: Add support for HSSE2.0 and HSFS1.1

2024-04-22 Thread Andrew Davis
On 4/22/24 4:40 PM, Neha Malcom Francis wrote: J721E has SR1.1 and SR2.0 having three variants of each GP, HS-FS and HS-SE. Current build does not generate HS-SE SR2.0 and HS-FS SR1.1 so add support for them. Reported-by: Suman Anna Signed-off-by: Neha Malcom Francis ---

Fwd: New Defects reported by Coverity Scan for Das U-Boot

2024-04-22 Thread Tom Rini
Here's the latest report. -- Forwarded message - From: Date: Mon, Apr 22, 2024 at 3:23 PM Subject: New Defects reported by Coverity Scan for Das U-Boot To: Hi, Please find the latest report on new defect(s) introduced to Das U-Boot found with Coverity Scan. 2 new defect(s)

[PATCH 2/2] arm: dts: k3-j7200-binman: Add support for HSSE1.0 and HSFS1.0

2024-04-22 Thread Neha Malcom Francis
J7200 has SR1.0 and SR2.0 having three variants of each GP, HS-FS and HS-SE. Current build does not generate HS-SE SR1.0 and HS-FS SR1.0 so add support for them. Reported-by: Suman Anna Reported-by: Aniket Limaye Signed-off-by: Neha Malcom Francis --- arch/arm/dts/k3-j7200-binman.dtsi | 95

[PATCH 0/2] Generate all SR boot binaries

2024-04-22 Thread Neha Malcom Francis
Add support for missing HS SRs in the build for J721E and J7200. Boot logs: https://gist.github.com/nehamalcom/e652752623537aced8cf31308015d7c9 Neha Malcom Francis (2): arm: dts: k3-j721e-binman: Add support for HSSE2.0 and HSFS1.1 arm: dts: k3-j7200-binman: Add support for HSSE1.0 and

[PATCH 1/2] arm: dts: k3-j721e-binman: Add support for HSSE2.0 and HSFS1.1

2024-04-22 Thread Neha Malcom Francis
J721E has SR1.1 and SR2.0 having three variants of each GP, HS-FS and HS-SE. Current build does not generate HS-SE SR2.0 and HS-FS SR1.1 so add support for them. Reported-by: Suman Anna Signed-off-by: Neha Malcom Francis --- arch/arm/dts/k3-j721e-binman.dtsi | 201

[ANN] U-Boot v2024.07-rc1 released

2024-04-22 Thread Tom Rini
Hey all, It's release day and here is -rc1. Looking at my own queue, I think things are overall good. There's a few changes I want to pull in still (mainly moving more things to OF_UPSTREAM) but since they were recently posted I'll wait a little bit. In terms of a changelog, git log --merges

RISC-V u-boot unable to boot QEMU using '-cpu max'

2024-04-22 Thread Daniel Henrique Barboza
Hi, In QEMU we have a 'max' type CPU that implements (almost) all extensions that QEMU is able to emulate. Recently, in QEMU commit 249e0905d05, we bumped the extensions for this CPU. And after this commit this CPU is now unable to boot a guest using upstream u-boot. Here's the error being

[PATCH 1/1] doc: correct description of 'env print -e'

2024-04-22 Thread Heinrich Schuchardt
If 'env print -e' is invoked without variable name, all UEFI variables are listed. Describe that 'env print -e' requires CONFIG_HEXDUMP=y to print content of UEFI variables. Signed-off-by: Heinrich Schuchardt --- doc/usage/cmd/env.rst | 10 +++--- 1 file changed, 7 insertions(+), 3

Re: [PATCH v2 2/3] configs/rock5b: Set NET_PREFER_ROM_MAC_ADDR to y

2024-04-22 Thread Marek Vasut
On 4/22/24 3:56 PM, Detlev Casanova wrote: --- configs/rock5b-rk3588_defconfig | 1 + 1 file changed, 1 insertion(+) This patch seems to be missing commit message and SoB line

Re: [PATCH v2 1/3] net: eth-uclass: Introduce NET_PREFER_ROM_MAC_ADDR

2024-04-22 Thread Marek Vasut
On 4/22/24 3:56 PM, Detlev Casanova wrote: On some boards, a MAC address is set based on the CPU ID or other information. This is usually done in the misc_init_r() function. This becomes a problem for net devices that are probed after the call to misc_init_r(), for example, when the ethernet is

Re: [PATCH v2 0/5] Kconfig: some cleanups

2024-04-22 Thread Tom Rini
On Tue, 16 Apr 2024 08:55:14 +0200, Michal Simek wrote: > I looked as cleaning up some dependencies and I found that qconfig is > reporting some issues. This series is fixing some of them. But there are > still some other pending. That's why please go and fix them if they are > related to your

Re: [PATCH v2 0/5] configs: apple: Switch to standard boot + small adjustments

2024-04-22 Thread Tom Rini
On Thu, 18 Apr 2024 21:00:24 +0200, Janne Grunau wrote: > This series contains a few misc config changes for Apple silicon > systems: > - switch from the deprecated distro boot scripts to standard boot > - allows EFI console resizing based on the video console size > - enables 16x32 bitmap fonts

Re: Pull request: u-boot-sunxi/master for v2024.07

2024-04-22 Thread Tom Rini
On Mon, Apr 22, 2024 at 05:22:49PM +0100, Andre Przywara wrote: > Hi Tom, > > as per the usual late ;-) please pull the sunxi/master branch, containing > some 2024.07 changes for Allwinner. Not many and nothing really exciting > this time: there are more patches in fly, but they are not ready

Re: [PATCH] doc: release_cycle: Note when next branch opens

2024-04-22 Thread Tom Rini
On Mon, 22 Apr 2024 10:44:54 -0600, Tom Rini wrote: > While I have said this in various release emails, it should be > documented here as well that the next branch opens with the second > release candidate. > > Applied to u-boot/master, thanks! -- Tom

[PATCH v2] mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops

2024-04-22 Thread Greg Malysa
From: Ian Roberts Add this hook so that it can be overridden with driver specific implementations. We also let the original sdhci_adma_write_desc() accept so that the function can set its new value. Then export the function so that it could be reused by driver's specific implementations. The

[PATCH v2] cmd: gpt: initialize partition table

2024-04-22 Thread Kishan Dudhatra
Change in v2: - Fix applies to all block devices, not just MMC. If partition init is not completed within the gpt write, the gpt partition list will not be updated. Signed-off-by: Kishan Dudhatra diff --git a/cmd/gpt.c b/cmd/gpt.c index d7e96529a6..7aaf1889a5 100644 --- a/cmd/gpt.c +++

Re: [PATCH 2/2] rockchip: add support for Theobroma Systems SOM-RK3588-Q7 Tiger module

2024-04-22 Thread Jonas Karlman
Hi Quentin, On 2024-04-22 18:41, Quentin Schulz wrote: > From: Quentin Schulz > > The RK3588-Q7 SoM is a Qseven-compatible (70mm x 70mm, MXM-230 > connector) system-on-module from Theobroma Systems, featuring the > Rockchip RK3588. > > It provides the following feature set: > * up to 16GB

Re: [PATCH 1/2] rockchip: rk3588: add support for UART2 M1 and M2 in SPL

2024-04-22 Thread Jonas Karlman
Hi Quentin, On 2024-04-22 18:41, Quentin Schulz wrote: > From: Quentin Schulz > > UART2 controller is the controller in the reference design for debug > console. The default mux is M0 in that reference design. Until now, all > boards seemed to be using UART2M0 but RK3588 Tiger for example will

Re: [PATCH] cmd: gpt: initialize partition table

2024-04-22 Thread Tom Rini
On Mon, Apr 22, 2024 at 10:53:35PM +0530, Kishan Dudhatra wrote: > If partition init is not completed within the gpt write, > the gpt partition list will not be updated. > > Signed-off-by: Kishan Dudhatra > > diff --git a/cmd/gpt.c b/cmd/gpt.c > index d7e96529a6..2d652f480a 100644 > ---

[PATCH] cmd: gpt: initialize partition table

2024-04-22 Thread Kishan Dudhatra
If partition init is not completed within the gpt write, the gpt partition list will not be updated. Signed-off-by: Kishan Dudhatra diff --git a/cmd/gpt.c b/cmd/gpt.c index d7e96529a6..2d652f480a 100644 --- a/cmd/gpt.c +++ b/cmd/gpt.c @@ -643,6 +643,10 @@ static int gpt_default(struct blk_desc

[PATCH] doc: release_cycle: Note when next branch opens

2024-04-22 Thread Tom Rini
While I have said this in various release emails, it should be documented here as well that the next branch opens with the second release candidate. Signed-off-by: Tom Rini --- doc/develop/release_cycle.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/develop/release_cycle.rst

[PATCH 2/2] rockchip: add support for Theobroma Systems SOM-RK3588-Q7 Tiger module

2024-04-22 Thread Quentin Schulz
From: Quentin Schulz The RK3588-Q7 SoM is a Qseven-compatible (70mm x 70mm, MXM-230 connector) system-on-module from Theobroma Systems, featuring the Rockchip RK3588. It provides the following feature set: * up to 16GB LPDDR4x * on-module eMMC * SD card (on a baseboard) via edge connector *

[PATCH 1/2] rockchip: rk3588: add support for UART2 M1 and M2 in SPL

2024-04-22 Thread Quentin Schulz
From: Quentin Schulz UART2 controller is the controller in the reference design for debug console. The default mux is M0 in that reference design. Until now, all boards seemed to be using UART2M0 but RK3588 Tiger for example will be using UART2M2 instead. Therefore, let's add support for

[PATCH 0/2] rockchip: add support for Theobroma Systems SOM-RK3588-Q7 Tiger module

2024-04-22 Thread Quentin Schulz
The RK3588-Q7 SoM is a Qseven-compatible (70mm x 70mm, MXM-230 connector) system-on-module from Theobroma Systems, featuring the Rockchip RK3588. It provides the following feature set: * up to 16GB LPDDR4x * on-module eMMC * SD card (on a baseboard) via edge connector * Gigabit Ethernet with

Re: Please pull u-boot-tegra staging

2024-04-22 Thread Tom Rini
On Mon, Apr 22, 2024 at 03:15:02PM +0300, Svyatoslav Ryhel wrote: > Dear Tom, > > The following changes since commit 1dd659fd626204bb6a6b4f330c27b11a7823bbb0: > > Merge tag 'video-20240421' of > https://source.denx.de/u-boot/custodians/u-boot-video (2024-04-21 08:54:20 > -0600) > > are

Pull request: u-boot-sunxi/master for v2024.07

2024-04-22 Thread Andre Przywara
Hi Tom, as per the usual late ;-) please pull the sunxi/master branch, containing some 2024.07 changes for Allwinner. Not many and nothing really exciting this time: there are more patches in fly, but they are not ready yet. I will also send some DT updates and new board defconfig files later,

[PATCH v2] stm32mp: Reserve OPTEE area in EFI memory map

2024-04-22 Thread Patrice Chotard
Since commit 7b78d6438a2b3 ("efi_loader: Reserve unaccessible memory") memory region above ram_top is tagged in EFI memory map as EFI_BOOT_SERVICES_DATA. In case of STM32MP1/STM32MP13 platforms, above ram_top, there is one reserved-memory region tagged "no-map" dedicated to OP-TEE : _

Re: [PATCH v1 2/3] board: sifive: Call spl_dram_init() for DRAM initialization

2024-04-22 Thread E Shattow
On Mon, Apr 22, 2024 at 6:16 AM wrote: > > From: Lukas Funke > > Call spl_dram_init() since this is commonly used for dram initialization > in u-boot. > > Signed-off-by: Lukas Funke > --- > > board/sifive/unleashed/spl.c | 4 ++-- > board/sifive/unmatched/spl.c | 4 ++-- > 2 files changed, 4

Re: [PATCH 01/10] board: ti: am62x: Init DRAM size in R5/A53 SPL

2024-04-22 Thread Tom Rini
On Mon, Apr 22, 2024 at 04:46:04PM +0530, Chintan Vankar wrote: > > > On 17/04/24 21:34, Tom Rini wrote: > > On Wed, Apr 17, 2024 at 05:48:31PM +0530, Sughosh Ganu wrote: > > > hi Chintan, > > > > > > On Wed, 17 Apr 2024 at 13:21, Chintan Vankar wrote: > > > > > > > > > > > > > > > > On

Re: [PATCH v1] tee: sandbox: check for buffer size

2024-04-22 Thread Oleksandr Suvorov
On Sun, Apr 21, 2024 at 11:48 PM Igor Opaniuk wrote: > > Add additional check for buffer size when reading out persistent > storage value and provide back actual value size. > > Signed-off-by: Igor Opaniuk Reviewed-by: Oleksandr Suvorov > --- > > drivers/tee/sandbox.c | 10 +++--- > 1

Re: [Uboot-stm32] [PATCH] stm32mp: Reserve OPTEE area in EFI memory map

2024-04-22 Thread Patrice CHOTARD
On 4/19/24 09:44, Patrice CHOTARD wrote: > > > On 4/17/24 09:45, Heinrich Schuchardt wrote: >> On 17.04.24 09:25, Patrick DELAUNAY wrote: >>> Hi, >>> >>> On 3/8/24 11:12, Patrice Chotard wrote: Since commit 7b78d6438a2b3 ("efi_loader: Reserve unaccessible memory") memory region

[PATCH v2 3/3] net: eth-uclass: Add driver source possibility

2024-04-22 Thread Detlev Casanova
Some net driver, like rtl8169, can set/get the MAC address from the registers and store it in pdata->enetaddr. When that happens, if there is a mismatch with the environment MAC address, u-boot will show that the MAC address source is DT. This patch ensures that the shown source is "driver"

[PATCH v2 2/3] configs/rock5b: Set NET_PREFER_ROM_MAC_ADDR to y

2024-04-22 Thread Detlev Casanova
--- configs/rock5b-rk3588_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig index 58c7c44fb4f..4cd4d369561 100644 --- a/configs/rock5b-rk3588_defconfig +++ b/configs/rock5b-rk3588_defconfig @@ -106,3 +106,4 @@

[PATCH v2 1/3] net: eth-uclass: Introduce NET_PREFER_ROM_MAC_ADDR

2024-04-22 Thread Detlev Casanova
On some boards, a MAC address is set based on the CPU ID or other information. This is usually done in the misc_init_r() function. This becomes a problem for net devices that are probed after the call to misc_init_r(), for example, when the ethernet is on a PCI port, which needs to be enumerated.

[PATCH v2 0/3] Introduce NET_PREFER_ROM_MAC_ADDR config

2024-04-22 Thread Detlev Casanova
When there is a MAC address mismatch between ROM and environment, u-boot chooses the one from the environment. This config allows to prefer the MAC address from the ROM instead of the environment. See the first commit message for details. Changes since v1: - Simplify implementation with a

[PATCH 1/1] cmd: CONFIG_CMD_BLOBLIST must depend on CONFIG_BLOBLIST

2024-04-22 Thread Heinrich Schuchardt
With CONFIG_CMD_BLOBLIST=y, CONFIG_BLOBLIST=n linker errors occur: usr/bin/ld: cmd/bloblist.o: in function `do_bloblist_list': cmd/bloblist.c:27:(.text.do_bloblist_list+0x6): undefined reference to `bloblist_show_list' /usr/bin/ld: cmd/bloblist.o: in function `do_bloblist_info':

[PATCH v1 0/3] riscv: Rename spl_soc_init() to spl_dram_init()

2024-04-22 Thread lukas . funke-oss
From: Lukas Funke This patch series renames spl_soc_init() to spl_dram_init() since the purpose of the function is to initialization the DRAM on sifive/starfive boards. spl_dram_init() is a commonly used function for this purpose. Lukas Funke (3): arch: riscv: Rename spl_soc_init() to

[PATCH v1 2/3] board: sifive: Call spl_dram_init() for DRAM initialization

2024-04-22 Thread lukas . funke-oss
From: Lukas Funke Call spl_dram_init() since this is commonly used for dram initialization in u-boot. Signed-off-by: Lukas Funke --- board/sifive/unleashed/spl.c | 4 ++-- board/sifive/unmatched/spl.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v1 3/3] board: starfive: Call spl_dram_init() for DRAM initialization

2024-04-22 Thread lukas . funke-oss
From: Lukas Funke Call spl_dram_init() since this is commonly used for dram initialization in u-boot. Signed-off-by: Lukas Funke --- board/starfive/visionfive2/spl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/board/starfive/visionfive2/spl.c

[PATCH v1 1/3] arch: riscv: Rename spl_soc_init() to spl_dram_init()

2024-04-22 Thread lukas . funke-oss
From: Lukas Funke Rename spl_soc_init() to spl_dram_init() because the generic function name does not reflect what the function is actually doing. In addition spl_dram_init() is commonly used for dram initialization and should be called from board_init_f(). Signed-off-by: Lukas Funke ---

BTRFS use-after-free bug at free_extent_buffer_internal

2024-04-22 Thread Sachi King
Hi, I've hit a bug with u-boot on my BTRFS filesystem, and I'm fairly certain it's a bug and not a corruption issue. A bit of history on the filesystem. It is a fairly new filesystem as it was being used to give me access to test a wayland application on a Raspberry Pi. The filesystem was

Re: [PATCH] usb: dwc2: update reset method for host and device mode

2024-04-22 Thread Kongyang Liu
Marek Vasut 于2024年4月22日周一 04:45写道: > > On 3/28/24 2:14 PM, Kongyang Liu wrote: > > [...] > > > @@ -464,12 +464,26 @@ static void reconfig_usbd(struct dwc2_udc *dev) > > { > > /* 2. Soft-reset OTG Core and then unreset again. */ > > int i; > > - unsigned int uTemp =

Please pull u-boot-tegra staging

2024-04-22 Thread Svyatoslav Ryhel
Dear Tom, The following changes since commit 1dd659fd626204bb6a6b4f330c27b11a7823bbb0: Merge tag 'video-20240421' of https://source.denx.de/u-boot/custodians/u-boot-video (2024-04-21 08:54:20 -0600) are available in the Git repository at:

[PATCH v2 5/5] pinctrl: qcom: ipq4019: support all pin functions

2024-04-22 Thread Robert Marko
Currently, IPQ4019 pinctrl driver supports only a very limited number of pin functions and is not fully DT compatible with Linux pinctrl nodes. IPQ40xx SoC-s sometimes use different pin function numbers for the same function depending on the pin number, so for example I2C0 on GPIO58 uses function

[PATCH v2 4/5] pinctrl: qcom: ipq4019: enable DM_FLAG_PRE_RELOC

2024-04-22 Thread Robert Marko
If compiled with logging and debug UART support, the following is printed: serial_msm serial@78af000: pinctrl_select_state_full: uclass_get_device_by_phandle_id: err=-19 This is due to the fact that IPQ4019 pinctrl driver is not available prior to relocation and thus MSM serial will fail probing

[PATCH v2 3/5] pinctrl: qcom: ipq4019: adapt pin name lookup to upstream DTS

2024-04-22 Thread Robert Marko
We want to use OF_UPSTREAM on IPQ40XX as its well supported upstream, so as a preparation update pinctrl driver to look for the upstream pin format. Signed-off-by: Robert Marko Reviewed-by: Caleb Connolly --- drivers/pinctrl/qcom/pinctrl-ipq4019.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 2/5] mach-ipq40xx: import GPIO header from mach-snapgradon

2024-04-22 Thread Robert Marko
Pinctrl driver was refactored and moved, but the required header that it depends on was not included. Fixes: 24d2908e987a ("pinctrl: qcom: move ipq4019 driver from mach-ipq40xx") Signed-off-by: Robert Marko --- arch/arm/mach-ipq40xx/include/mach/gpio.h | 37 +++ 1 file

[PATCH v2 1/5] pinctrl: qcom: allow selecting with ARCH_IPQ40XX

2024-04-22 Thread Robert Marko
IPQ4019 pinctrl driver was moved to the dedicated Qualcomm pinctrl directory, but the KConfig depends on ARCH_SNAPDRAGON only and thus PINCTRL_QCOM_IPQ4019 cannot be selected when ARCH_IPQ40XX is used. Fixes: 24d2908e987a ("pinctrl: qcom: move ipq4019 driver from mach-ipq40xx") Signed-off-by:

Re: [PATCH] clk: imx8mn: add video clocks support

2024-04-22 Thread Fabio Estevam
Hi Michael, On Mon, Apr 22, 2024 at 7:36 AM Michael Nazzareno Trimarchi wrote: > Are you considering if I wrap properly with VIDEO IS_ENABLED? I prefer you resend this patch as part of a complete series that adds panel support to an imx8mn board target. Otherwise, if this gets in as-is, it

Re: [PATCH 01/10] board: ti: am62x: Init DRAM size in R5/A53 SPL

2024-04-22 Thread Chintan Vankar
On 17/04/24 21:34, Tom Rini wrote: On Wed, Apr 17, 2024 at 05:48:31PM +0530, Sughosh Ganu wrote: hi Chintan, On Wed, 17 Apr 2024 at 13:21, Chintan Vankar wrote: On 16/04/24 22:30, Tom Rini wrote: On Tue, Apr 16, 2024 at 05:52:58PM +0530, Chintan Vankar wrote: On 12/04/24 03:37, Tom

Re: [PATCH] usb: dwc3: support USB 3.1 controllers

2024-04-22 Thread Caleb Connolly
On 21/04/2024 22:38, Marek Vasut wrote: On 4/11/24 6:05 PM, Caleb Connolly wrote: The revision is different for these, add the additional check as in xhci-dwc3 core_init code. Signed-off-by: Caleb Connolly Is there a matching Linux kernel patch , or does Linux do some other check ? I

Re: [PATCH] clk: imx8mn: add video clocks support

2024-04-22 Thread Michael Nazzareno Trimarchi
Hi Fabio On Sun, Apr 21, 2024 at 10:54 PM Michael Nazzareno Trimarchi wrote: > > Hi Fabio > > On Sun, Apr 21, 2024 at 10:24 PM Fabio Estevam wrote: > > > > Hi Michael, > > > > On Sun, Apr 21, 2024 at 11:07 AM Michael Trimarchi > > wrote: > > > > > > Add clocks support for the video subsystem.

Re: [PATCH] efi_loader: do not install dtb if bootmgr fails

2024-04-22 Thread Ilias Apalodimas
On Mon, 22 Apr 2024 at 12:16, Heinrich Schuchardt wrote: > > If the UEFI boot manager fails, there is no point in installing the > device-tree as a configuration table. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_bootmgr.c | 8 > 1 file changed, 4 insertions(+), 4

Re: [PATCH 0/3] qcom: switch to OF_UPSTREAM

2024-04-22 Thread Sumit Garg
On Thu, 18 Apr 2024 at 10:24, Caleb Connolly wrote: > > This series does the initial switch to OF_UPSTREAM for Qualcomm > platforms. The DT files we have in U-Boot are outdated by now, so drop > them and move to upstream. > > Patch 2 drops all the Qualcomm dts files that are now provided in >

[PATCH v4 5/5] power: regulator: tps65941: Add TPS65224 PMIC regulator support

2024-04-22 Thread Bhargav Raviprakash
Reuse TPS65941 regulator driver to adds support for TPS65224 PMIC's regulators. 4 BUCKs and 3 LDOs, where BUCK1 and BUCK2 can be configured in dual phase mode. Signed-off-by: Bhargav Raviprakash --- drivers/power/regulator/tps65941_regulator.c | 280 ++- 1 file changed, 267

[PATCH v4 4/5] power: regulator: tps65941: use function callbacks for conversion ops

2024-04-22 Thread Bhargav Raviprakash
Use function callbacks for volt2val, val2volt and slewrate lookups. This makes it easier to add support for TPS65224 PMIC regulators. Signed-off-by: Bhargav Raviprakash Reviewed-by: Jaehoon Chung --- drivers/power/regulator/tps65941_regulator.c | 61 +++- 1 file changed, 48

[PATCH v4 3/5] power: regulator: tps65941: Added macros for BUCK ID

2024-04-22 Thread Bhargav Raviprakash
Adds macros for buck and ldo ids and switched to using switch case instead of if else in probe functions. Helps in adding support for TPS65224 PMIC. Signed-off-by: Bhargav Raviprakash Reviewed-by: Dhruva Gole Reviewed-by: Jaehoon Chung --- drivers/power/regulator/tps65941_regulator.c | 54

[PATCH v4 2/5] power: pmic: tps65941: Add TI TPS65224 PMIC

2024-04-22 Thread Bhargav Raviprakash
Adds compatible and data field values of TPS65224 driver in TPS65941 PMIC driver. Signed-off-by: Bhargav Raviprakash Reviewed-by: Dhruva Gole Reviewed-by: Jaehoon Chung --- drivers/power/pmic/tps65941.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/power/pmic/tps65941.c

[PATCH v4 1/5] power: tps65941: Add macros of TPS65224 PMIC

2024-04-22 Thread Bhargav Raviprakash
Re-use the TPS65941 PMIC driver for TPS65224 PMIC. Add additional macros of TPS65224 to aid in the driver re-use. Signed-off-by: Bhargav Raviprakash Reviewed-by: Dhruva Gole Reviewed-by: Jaehoon Chung --- include/power/tps65941.h | 30 ++ 1 file changed, 30

[PATCH v4 0/5] Add support for TI TPS65224 PMIC

2024-04-22 Thread Bhargav Raviprakash
TPS65224 is a Power Management IC which provides regulators and others features like GPIOs, RTC, watchdog, ADC, ESMs (Error Signal Monitor), and PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can communicate through the I2C. Data Sheet for TPS65224:

Re: [PATCH 1/1] Makefile: don't add -Wno-maybe-uninitialized twice

2024-04-22 Thread Quentin Schulz
Hi Heinrich, On 4/16/24 09:35, Heinrich Schuchardt wrote: Avoid adding the same flag to KBUILD_CFLAGS twice. Fixes: 8602d97ca2cf ("Makefile: avoid false positive -Wmaybe-uninitialized") Signed-off-by: Heinrich Schuchardt Reviewed-by: Quentin Schulz Thanks, Quentin

[PATCH v2 1/2] i2c: Add support for Qualcomm Generic Interface (GENI) I2C controller

2024-04-22 Thread Neil Armstrong
Add Support for the Qualcomm Generic Interface (GENI) I2C interface found on newer Qualcomm SoCs. The Generic Interface (GENI) is a firmware based Qualcomm Universal Peripherals (QUP) Serial Engine (SE) Wrapper which can support multiple bus protocols depending on the firmware type loaded at

[PATCH v2 2/2] configs: qcom_defconfig: enable GENI I2C Driver

2024-04-22 Thread Neil Armstrong
Enable the GENI I2C driver in the default Qualcomm defconfig. Reviewed-by: Caleb Connolly Signed-off-by: Neil Armstrong --- configs/qcom_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig index 1abb57345ff..8d440b23625 100644 ---

[PATCH v2 0/2] i2c: Add support for Qualcomm Generic Interface (GENI) I2C controller

2024-04-22 Thread Neil Armstrong
Add Support for the Qualcomm Generic Interface (GENI) I2C interface found on newer Qualcomm SoCs. The Generic Interface (GENI) is a firmware based Qualcomm Universal Peripherals (QUP) Serial Engine (SE) Wrapper which can support multiple bus protocols depending on the firmware type loaded at

Re: [PATCH 1/2] i2c: Add support for Qualcomm Generic Interface (GENI) I2C controller

2024-04-22 Thread Neil Armstrong
On 19/04/2024 13:47, Caleb Connolly wrote: Hi Neil, On 18/04/2024 23:47, Neil Armstrong wrote: Add Support for the Qualcomm Generic Interface (GENI) I2C interface found on newer Qualcomm SoCs. \o/ The Generic Interface (GENI) is a firmware based Qualcomm Universal Peripherals (QUP) Serial

Re: [PATCH] board: rk3288: simplify the DT file list in MAINTAINERS

2024-04-22 Thread Dragan Simic
On 2024-04-22 10:24, Kever Yang wrote: On 2024/4/18 15:06, Dragan Simic wrote: Use a wildcard to simplify the list of board DT files in the MAINTAINERS file for the Radxa Rock 2 Square board. Signed-off-by: Dragan Simic Reviewed-by: Kever Yang Thanks! ---

Re: [PATCH v2 11/14] rockchip: rk3308-evb: Update defconfig

2024-04-22 Thread Jonas Karlman
Hi Kever, On 2024-04-22 10:50, Kever Yang wrote: > Hi Jonas, > > On 2024/4/9 02:14, Jonas Karlman wrote: >> Update defconfig for rk3308-evb with new defaults. >> >> Add OF_LIBFDT_OVERLAY=y to support device tree overlays. >> >> Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL.

[PATCH] efi_loader: do not install dtb if bootmgr fails

2024-04-22 Thread Heinrich Schuchardt
If the UEFI boot manager fails, there is no point in installing the device-tree as a configuration table. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_bootmgr.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/efi_loader/efi_bootmgr.c

Re: BTRFS use-after-free bug at free_extent_buffer_internal

2024-04-22 Thread Qu Wenruo
在 2024/4/22 16:45, Qu Wenruo 写道: [...] I added a print statement to free_extent_buffer_internal that prints the start address of the extent_buffer as I'm not sure what to be looking for here.  This print statement is before the decrement. printf("free_extent_buffer_internal: eb->start[%llx]

Re: [PATCH v2 14/14] rockchip: rk3308: Move cru and grf include files to arch-rockchip

2024-04-22 Thread Kever Yang
On 2024/4/9 02:14, Jonas Karlman wrote: Move cru_rk3308.h and grf_rk3308.h to arch-rockchip to match path used for all other Rockchip SoCs. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: New patch --- .../arm/include/asm/{arch-rk3308 =>

Re: [PATCH v2 12/14] rockchip: rk3308-roc-cc: Update defconfig

2024-04-22 Thread Kever Yang
On 2024/4/9 02:14, Jonas Karlman wrote: Update defconfig for rk3308-roc-cc with new defaults. Add OF_LIBFDT_OVERLAY=y to support device tree overlays. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Remove BOOTDELAY=0, SYS_CONSOLE_INFO_QUIET=y and enable more CMD to

Re: [PATCH v2 13/14] rockchip: rk3308-rock-pi-s: Update defconfig

2024-04-22 Thread Kever Yang
On 2024/4/9 02:14, Jonas Karlman wrote: Update defconfig for rk3308-rock-pi-s with new defaults. Add OF_LIBFDT_OVERLAY=y to support device tree overlays. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Remove BOOTDELAY=0, SYS_CONSOLE_INFO_QUIET=y and enable more CMD to

Re: [PATCH v3 07/11] rockchip: evb_rk3588 et al.: use DRAM banks from ATAGS

2024-04-22 Thread Kever Yang
On 2024/4/15 22:17, Quentin Schulz wrote: From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. Since ft_board_setup isn't defined anymore, there's no need for selecting

Re: [PATCH v2 11/14] rockchip: rk3308-evb: Update defconfig

2024-04-22 Thread Kever Yang
Hi Jonas, On 2024/4/9 02:14, Jonas Karlman wrote: Update defconfig for rk3308-evb with new defaults. Add OF_LIBFDT_OVERLAY=y to support device tree overlays. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Use DEBUG_UART_BASE=0xFF0E and disable DEBUG_UART_BOARD_INIT

Re: [PATCH v2 10/14] rockchip: rk3308: Sync device tree from linux v6.8

2024-04-22 Thread Kever Yang
On 2024/4/9 02:14, Jonas Karlman wrote: Sync device tree from linux v6.8 and rename the rockchip,rk3308-mac compatible in gmac_rockchip driver to match upstream linux. Also move rk3308-roc-cc gmac node to u-boot.dtsi to not break features not enabled in upstream device tree. Signed-off-by:

Re: [PATCH v2 09/14] phy: rockchip-inno-usb2: Add support for RK3308

2024-04-22 Thread Kever Yang
On 2024/4/9 02:14, Jonas Karlman wrote: Add clkout_ctl and phy_sus regs to support USB2PHY for RK3308. Based on linux commit 31f840e7ff3e ("phy: phy-rockchip-inno-usb2: add support for RK3308 USB phy"). Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: No

Re: [PATCH v2 08/14] clk: rockchip: rk3308: Add dummy support for USB480M clock

2024-04-22 Thread Kever Yang
On 2024/4/9 02:14, Jonas Karlman wrote: Add dummy support for setting parent of USB480M clock. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: No change --- drivers/clk/rockchip/clk_rk3308.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH v2 07/14] clk: rockchip: rk3308: Add support for SCLK_RTC32K clock

2024-04-22 Thread Kever Yang
On 2024/4/9 02:14, Jonas Karlman wrote: From: Finley Xiao Add support to get and set the SCLK_RTC32K clock rate. Signed-off-by: Finley Xiao [jo...@kwiboo.se: Update commit message] Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: No change ---

Re: [PATCH v2 06/14] rockchip: rk3308: Fix loading FIT from SD-card when booting from eMMC

2024-04-22 Thread Kever Yang
On 2024/4/9 02:14, Jonas Karlman wrote: When RK3308 boards run SPL from eMMC and fail to load FIT from eMMC due to it being missing or checksum validation fails there can be a fallback to read FIT from SD-card. However, without proper pinctrl configuration reading FIT from SD-card may fail:

Re: [PATCH v2 05/14] rockchip: rk3308: Enable random generator

2024-04-22 Thread Kever Yang
On 2024/4/9 02:14, Jonas Karlman wrote: The RK3308 SoC contain a crypto engine block that can generate random numbers. Add rng node to soc u-boot.dtsi and enable Kconfig options to take advantage of the random generator. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, -

Re: [PATCH v2 04/14] rockchip: rk3308: Generate ethaddr based on cpu id

2024-04-22 Thread Kever Yang
On 2024/4/9 02:14, Jonas Karlman wrote: Like other Rockchip SoCs the RK3308 has cpu id programmed into OTP memory. The rockchip_otp driver already support the RK3308 variant. However, the device tree is missing a node to enable use of OTP. Add the missing otp node to soc u-boot.dtsi, enable

Re: [PATCH v2 03/14] rockchip: rk3308: Enable ARMv8 crypto and FIT checksum validation

2024-04-22 Thread Kever Yang
On 2024/4/9 02:14, Jonas Karlman wrote: The RK3308 SoC support ARMv8 Cryptography Extensions and use of the ARMv8 crypto extensions help speed up FIT checksum validation in SPL. Imply ARMV8_SET_SMPEN and ARMV8_CRYPTO to take advantage of the crypto extensions for SHA256 when validating

Re: [PATCH v2 02/14] rockchip: rk3308: Sort imply statements alphabetically

2024-04-22 Thread Kever Yang
On 2024/4/9 02:13, Jonas Karlman wrote: Sort imply statements under ROCKCHIP_RK3308 alphabetically and remove the config SPL_SERIAL statement from soc Kconfig file, it is already implyed in arch Kconfig. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: No

Re: [PATCH v2 01/14] board: rockchip: rk3308: Add device tree files and myself to MAINTAINERS

2024-04-22 Thread Kever Yang
On 2024/4/9 02:13, Jonas Karlman wrote: Update MAINTAINERS files for RK3308 boards to include related device tree files. Also add myself as a reviewer for the ROCK Pi S board. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v2: No change ---

[PATCH v2 1/1] efi_loader: improve error handling in try_load_entry()

2024-04-22 Thread Heinrich Schuchardt
The image is not unloaded if a security violation occurs. If efi_set_load_options() fails, we do not free the memory allocated for the optional data. We do not unload the image. * Unload the image if a security violation occurs. * Free load_options if efi_set_load_options() fails. * Unload the

Re: [PATCH v2] mmc: rockchip_sdhci: Fix 4 blocks PIO mode read limit for RK35xx

2024-04-22 Thread Kever Yang
On 2024/4/10 22:30, Jonas Karlman wrote: The commit 2cc6cde647e2 ("mmc: rockchip_sdhci: Limit number of blocks read in a single command") introduced a limit of number of blocks to read to fix a Data End Bit Error on RK3568 and RK3588. This had a side affect of significant slowing down reading

Re: [PATCH v3 11/11] rockchip: rk356x: use DRAM banks from ATAGS

2024-04-22 Thread Kever Yang
On 2024/4/15 22:17, Quentin Schulz wrote: From: Quentin Schulz RK356x-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. The CONFIG_NR_DRAM_BANK now defaults to 10 which is a safe bet for reading

Re: [PATCH v3 10/11] rockchip: rk3588: use DRAM banks from ATAGS

2024-04-22 Thread Kever Yang
On 2024/4/15 22:17, Quentin Schulz wrote: From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. The CONFIG_NR_DRAM_BANK now defaults to 10 which is a safe bet for reading

Re: [PATCH v3 09/11] rockchip: turing-rk1-rk3588: use DRAM banks from ATAGS

2024-04-22 Thread Kever Yang
On 2024/4/15 22:17, Quentin Schulz wrote: From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. Since ft_board_setup isn't defined anymore, there's no need for selecting

Re: [PATCH v3 07/11] rockchip: evb_rk3588 et al.: use DRAM banks from ATAGS

2024-04-22 Thread Kever Yang
On 2024/4/15 22:17, Quentin Schulz wrote: From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. Since ft_board_setup isn't defined anymore, there's no need for selecting

Re: [PATCH v3 08/11] rockchip: toybrick_rk3588: use DRAM banks from ATAGS

2024-04-22 Thread Kever Yang
On 2024/4/15 22:17, Quentin Schulz wrote: From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. Since ft_board_setup isn't defined anymore, there's no need for selecting

Re: [PATCH v3 06/11] rockchip: rock5b-rk3588: use DRAM banks from ATAGS

2024-04-22 Thread Kever Yang
On 2024/4/15 22:16, Quentin Schulz wrote: From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. Since ft_board_setup isn't defined anymore, there's no need for selecting

  1   2   >