Re: Apache Guacamole html page edit

2022-06-03 Thread Suat Toksöz
I just use the apache guacamole extension
(guacamole-client-master/doc/guacamole-branding-example) for the html edit.
Is this format ok, I am missing anything?


here is the html replace code:

**

*


{{'SETTINGS_SESSIONS.HELP_SESSIONS' | translate}}



{{'SETTINGS_SESSIONS.ACTION_DELETE' |
translate}}











{{'SETTINGS_SESSIONS.TABLE_HEADER_SESSION_USERNAME' |
translate}}


{{'SETTINGS_SESSIONS.TABLE_HEADER_SESSION_STARTDATE' |
translate}}


{{'SETTINGS_SESSIONS.TABLE_HEADER_SESSION_REMOTEHOST' |
translate}}



{{'SETTINGS_SESSIONS.TABLE_HEADER_SESSION_CONNECTION_NAME' | translate}}









{{wrapper.startDate}}
{{wrapper.activeConnection.remoteHost}}
*{{wrapper.name
}}*




On Wed, Jun 1, 2022 at 8:41 PM Suat Toksöz  wrote:

> Thanks Nick,
>
> Then how can I modify the apache guacamole client , so no one can access
> to active session link from outside.
>
> On 1 Jun 2022, at 20:34, Nick Couchman  wrote:
>
> 
> On Wed, Jun 1, 2022 at 12:54 PM Suat Toksöz  wrote:
>
>> So, what is your suggestion for me to edit admin active session tab?
>>
>>
> Creating a custom extension and using the HTML replace functionality is
> the best way to make sure that your changes are future-proof - the base of
> Guacamole Client can stay unmodified, which means upgrades won't require
> any re-application of changes.
>
> That said, you should be advised that simply hiding the HTML link for the
> admin doesn't mean that that the functionality is disabled - someone with
> knowledge of the Guacamole code and how the links are generated could
> retrieve the link and access the session, anyway. Removing the HTML link is
> just "security by obscurity."
>
> -Nick
>
>>

-- 

Best regards,

*Suat Toksöz*


Re: Apache Guacamole html page edit

2022-06-01 Thread Suat Toksöz
Thanks Nick, 

Then how can I modify the apache guacamole client , so no one can access to 
active session link from outside.

> On 1 Jun 2022, at 20:34, Nick Couchman  wrote:
> 
> 
>> On Wed, Jun 1, 2022 at 12:54 PM Suat Toksöz  wrote:
> 
>> So, what is your suggestion for me to edit admin active session tab?
>> 
> 
> Creating a custom extension and using the HTML replace functionality is the 
> best way to make sure that your changes are future-proof - the base of 
> Guacamole Client can stay unmodified, which means upgrades won't require any 
> re-application of changes.
> 
> That said, you should be advised that simply hiding the HTML link for the 
> admin doesn't mean that that the functionality is disabled - someone with 
> knowledge of the Guacamole code and how the links are generated could 
> retrieve the link and access the session, anyway. Removing the HTML link is 
> just "security by obscurity."
> 
> -Nick


Re: Apache Guacamole html page edit

2022-06-01 Thread Nick Couchman
On Wed, Jun 1, 2022 at 12:54 PM Suat Toksöz  wrote:

> So, what is your suggestion for me to edit admin active session tab?
>
>
Creating a custom extension and using the HTML replace functionality is the
best way to make sure that your changes are future-proof - the base of
Guacamole Client can stay unmodified, which means upgrades won't require
any re-application of changes.

That said, you should be advised that simply hiding the HTML link for the
admin doesn't mean that that the functionality is disabled - someone with
knowledge of the Guacamole code and how the links are generated could
retrieve the link and access the session, anyway. Removing the HTML link is
just "security by obscurity."

-Nick

>


Re: Apache Guacamole html page edit

2022-06-01 Thread Suat Toksöz
So, what is your suggestion for me to edit admin active session tab?

> On 1 Jun 2022, at 19:25, Nick Couchman  wrote:
> 
> 
>> On Wed, Jun 1, 2022 at 12:06 PM Joachim Lindenberg 
>>  wrote:
> 
>> Two questions:
>> 
>> can this be done with an extension rather than a modification?
> Yes, and this would be a better way to do it. You should be able to use the 
>  tag along with "replace", as documented in the guacamole-ext page in 
> the manual, to replace the content that creates the link.
> 
>> didn´t this come up several times earlier and could be a configuration 
>> option that the webapp addresses out-of-the-box?
> I don't think disabling this completely has come up; however, there is a PR 
> in progress, along with a Jira issue, to notify users when someone joins and 
> leaves the connection, so at least there is a visual cue for users that there 
> is someone else on that connection.
> 
> -NIck


Re: Apache Guacamole html page edit

2022-06-01 Thread Nick Couchman
On Wed, Jun 1, 2022 at 12:06 PM Joachim Lindenberg 
wrote:

> Two questions:
>
>- can this be done with an extension rather than a modification?
>
> Yes, and this would be a better way to do it. You should be able to use
the  tag along with "replace", as documented in the guacamole-ext
page in the manual, to replace the content that creates the link.


>-
>- didn´t this come up several times earlier and could be a
>configuration option that the webapp addresses out-of-the-box?
>
> I don't think disabling this completely has come up; however, there is a
PR in progress, along with a Jira issue, to notify users when someone joins
and leaves the connection, so at least there is a visual cue for users that
there is someone else on that connection.

-NIck


AW: Apache Guacamole html page edit

2022-06-01 Thread Joachim Lindenberg
Two questions:

*   can this be done with an extension rather than a modification?
*   didn´t this come up several times earlier and could be a configuration 
option that the webapp addresses out-of-the-box?

Thanks, Joachim

 

Von: Suat Toksöz <> 
Gesendet: Wednesday, 1 June 2022 17:56
An: user@guacamole.apache.org
Betreff: Re: Apache Guacamole html page edit

 

Thanks Nick,

 

So İ need to get the apache guacamole client source code , then change the html 
tag ten compile and generate the war file for tomcat right?

 

The change that we newd is this, admin user should not able to intersep the 
active connections. So the link for each active session should be #. 





On 1 Jun 2022, at 18:05, Nick Couchman mailto:vn...@apache.org> > wrote:



On Wed, Jun 1, 2022 at 10:47 AM Suat Toksöz mailto:stok...@gmail.com> > wrote:

Also, I am not able to find the file location on apache guacamole source code.

https://dlcdn.apache.org/guacamole/1.4.0/source/



 

 

That's the guacamole-server (guacd) source code - the code for the web 
interface is in the guacamole-client source code. For the connection history 
and active sessions, the code is specifically, here:

 

https://github.com/apache/guacamole-client/tree/master/guacamole/src/main/frontend/src/app/settings/templates

 

Please note those are the HTML templates that are used by AngularJS to fill in 
the data. So, whatever modifications you want to do will likely need to be a 
combination of edits to those HTML templates as well as the AngularJS files 
that actually populate data.

 

-NIck



Re: Apache Guacamole html page edit

2022-06-01 Thread Suat Toksöz
Thanks Nick,

So İ need to get the apache guacamole client source code , then change the html 
tag ten compile and generate the war file for tomcat right?

The change that we newd is this, admin user should not able to intersep the 
active connections. So the link for each active session should be #. 

> On 1 Jun 2022, at 18:05, Nick Couchman  wrote:
> 
> 
>> On Wed, Jun 1, 2022 at 10:47 AM Suat Toksöz  wrote:
> 
>> Also, I am not able to find the file location on apache guacamole source 
>> code.
>> 
>> https://dlcdn.apache.org/guacamole/1.4.0/source/
>> 
>> 
> 
> That's the guacamole-server (guacd) source code - the code for the web 
> interface is in the guacamole-client source code. For the connection history 
> and active sessions, the code is specifically, here:
> 
> https://github.com/apache/guacamole-client/tree/master/guacamole/src/main/frontend/src/app/settings/templates
> 
> Please note those are the HTML templates that are used by AngularJS to fill 
> in the data. So, whatever modifications you want to do will likely need to be 
> a combination of edits to those HTML templates as well as the AngularJS files 
> that actually populate data.
> 
> -NIck


Re: Apache Guacamole html page edit

2022-06-01 Thread Tushar Jain
That’s the server code you are looking at. Instead, you have to download the 
client code. Following is the location:

https://github.com/apache/guacamole-client
[https://opengraph.githubassets.com/7090848d7aceb6ab363d51e09d02c07d6fe6b51e0fd4b0fe2d3f9ac66a4b0c2f/apache/guacamole-client]<https://github.com/apache/guacamole-client>
apache/guacamole-client: Mirror of Apache Guacamole Client - 
GitHub<https://github.com/apache/guacamole-client>
Mirror of Apache Guacamole Client. Contribute to apache/guacamole-client 
development by creating an account on GitHub.
github.com


From: Suat Toksöz 
Sent: Wednesday, June 1, 2022 8:17 PM
To: user@guacamole.apache.org 
Subject: Re: Apache Guacamole html page edit

Also, I am not able to find the file location on apache guacamole source code.

https://dlcdn.apache.org/guacamole/1.4.0/source/
[image.png]

On Wed, Jun 1, 2022 at 9:11 AM Suat Toksöz 
mailto:stok...@gmail.com>> wrote:
Thanks Nick for the quick response.

I want to edit WAR file (https://guacamole.apache.org/releases/1.4.0/) and re 
build the WAR file then deploy to the tomcat server. But, I can not able to 
find html section to edit. We want to edit the "Active Session" section of the 
admin page, where I can find the html files for this on the WAR file.

[image.png]
Thanks


On Tue, May 31, 2022 at 5:58 PM Nick Couchman 
mailto:vn...@apache.org>> wrote:
On Tue, May 31, 2022 at 10:13 AM Suat Toksöz 
mailto:stok...@gmail.com>> wrote:
Hi,

I would like to edit apache guacamole admin web site, where I can find the html 
tags?


If you want to edit the admin site, you should edit the source code and 
re-builld it, and not edit the pages directly. As the site is hosted by Tomcat, 
the static pages are deployed from the WAR file, which can be re-deployed at 
any time and will overwrite any changes you make.

To edit the source code, you can either edit the source directly and rebuild 
the war, or you can build an extension module that modifies the HTML code 
dynamically. The second option is the recommended route.

To edit the source code directly, you need to download the source code and then 
find the location that you want to edit in the 
guacamole/src/main/frontend/src/app directory.

If you want to build an extension that modifies the HTML, see the following 
manual page, and the following branding example:
https://guacamole.apache.org/doc/gug/guacamole-ext.html#updating-existing-html
https://github.com/apache/guacamole-client/tree/master/doc/guacamole-branding-example

Feel free to post back here with any further questions or concerns.

-Nick


--

Best regards,

Suat Toksöz


--

Best regards,

Suat Toksöz


Re: Apache Guacamole html page edit

2022-06-01 Thread Nick Couchman
On Wed, Jun 1, 2022 at 10:47 AM Suat Toksöz  wrote:

> Also, I am not able to find the file location on apache guacamole source
> code.
>
> https://dlcdn.apache.org/guacamole/1.4.0/source/
> [image: image.png]
>
>
That's the guacamole-server (guacd) source code - the code for the web
interface is in the guacamole-client source code. For the connection
history and active sessions, the code is specifically, here:

https://github.com/apache/guacamole-client/tree/master/guacamole/src/main/frontend/src/app/settings/templates

Please note those are the HTML templates that are used by AngularJS to fill
in the data. So, whatever modifications you want to do will likely need to
be a combination of edits to those HTML templates as well as the AngularJS
files that actually populate data.

-NIck

>


Re: Apache Guacamole html page edit

2022-06-01 Thread Suat Toksöz
Also, I am not able to find the file location on apache guacamole source
code.

https://dlcdn.apache.org/guacamole/1.4.0/source/
[image: image.png]

On Wed, Jun 1, 2022 at 9:11 AM Suat Toksöz  wrote:

> Thanks Nick for the quick response.
>
> I want to edit WAR file (https://guacamole.apache.org/releases/1.4.0/)
> and re build the WAR file then deploy to the tomcat server. But, I can not
> able to find html section to edit. We want to edit the "Active Session"
> section of the admin page, where I can find the html files for this on the
> WAR file.
>
> [image: image.png]
> Thanks
>
>
> On Tue, May 31, 2022 at 5:58 PM Nick Couchman  wrote:
>
>> On Tue, May 31, 2022 at 10:13 AM Suat Toksöz  wrote:
>>
>>> Hi,
>>>
>>> I would like to edit apache guacamole admin web site, where I can find
>>> the html tags?
>>>
>>>
>> If you want to edit the admin site, you should edit the source code and
>> re-builld it, and not edit the pages directly. As the site is hosted by
>> Tomcat, the static pages are deployed from the WAR file, which can be
>> re-deployed at any time and will overwrite any changes you make.
>>
>> To edit the source code, you can either edit the source directly and
>> rebuild the war, or you can build an extension module that modifies the
>> HTML code dynamically. The second option is the recommended route.
>>
>> To edit the source code directly, you need to download the source code
>> and then find the location that you want to edit in the
>> guacamole/src/main/frontend/src/app directory.
>>
>> If you want to build an extension that modifies the HTML, see the
>> following manual page, and the following branding example:
>>
>> https://guacamole.apache.org/doc/gug/guacamole-ext.html#updating-existing-html
>>
>> https://github.com/apache/guacamole-client/tree/master/doc/guacamole-branding-example
>>
>> Feel free to post back here with any further questions or concerns.
>>
>> -Nick
>>
>>>
>
> --
>
> Best regards,
>
> *Suat Toksöz*
>


-- 

Best regards,

*Suat Toksöz*


Re: Apache Guacamole html page edit

2022-06-01 Thread Suat Toksöz
Thanks Nick for the quick response.

I want to edit WAR file (https://guacamole.apache.org/releases/1.4.0/) and
re build the WAR file then deploy to the tomcat server. But, I can not able
to find html section to edit. We want to edit the "Active Session" section
of the admin page, where I can find the html files for this on the WAR file.

[image: image.png]
Thanks


On Tue, May 31, 2022 at 5:58 PM Nick Couchman  wrote:

> On Tue, May 31, 2022 at 10:13 AM Suat Toksöz  wrote:
>
>> Hi,
>>
>> I would like to edit apache guacamole admin web site, where I can find
>> the html tags?
>>
>>
> If you want to edit the admin site, you should edit the source code and
> re-builld it, and not edit the pages directly. As the site is hosted by
> Tomcat, the static pages are deployed from the WAR file, which can be
> re-deployed at any time and will overwrite any changes you make.
>
> To edit the source code, you can either edit the source directly and
> rebuild the war, or you can build an extension module that modifies the
> HTML code dynamically. The second option is the recommended route.
>
> To edit the source code directly, you need to download the source code and
> then find the location that you want to edit in the
> guacamole/src/main/frontend/src/app directory.
>
> If you want to build an extension that modifies the HTML, see the
> following manual page, and the following branding example:
>
> https://guacamole.apache.org/doc/gug/guacamole-ext.html#updating-existing-html
>
> https://github.com/apache/guacamole-client/tree/master/doc/guacamole-branding-example
>
> Feel free to post back here with any further questions or concerns.
>
> -Nick
>
>>

-- 

Best regards,

*Suat Toksöz*


Re: Apache Guacamole html page edit

2022-05-31 Thread Nick Couchman
On Tue, May 31, 2022 at 10:13 AM Suat Toksöz  wrote:

> Hi,
>
> I would like to edit apache guacamole admin web site, where I can find the
> html tags?
>
>
If you want to edit the admin site, you should edit the source code and
re-builld it, and not edit the pages directly. As the site is hosted by
Tomcat, the static pages are deployed from the WAR file, which can be
re-deployed at any time and will overwrite any changes you make.

To edit the source code, you can either edit the source directly and
rebuild the war, or you can build an extension module that modifies the
HTML code dynamically. The second option is the recommended route.

To edit the source code directly, you need to download the source code and
then find the location that you want to edit in the
guacamole/src/main/frontend/src/app directory.

If you want to build an extension that modifies the HTML, see the following
manual page, and the following branding example:
https://guacamole.apache.org/doc/gug/guacamole-ext.html#updating-existing-html
https://github.com/apache/guacamole-client/tree/master/doc/guacamole-branding-example

Feel free to post back here with any further questions or concerns.

-Nick

>


Apache Guacamole html page edit

2022-05-31 Thread Suat Toksöz
Hi,

I would like to edit apache guacamole admin web site, where I can find the
html tags?

-- 

Best regards,

*Suat Toksöz*