[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension

2017-01-25 Thread Bawolff
Bawolff added a comment. In T149082#2968137, @Addshore wrote: In T149082#2966632, @Bawolff wrote: I assume this is not using the LinkUpdates related hooks because it only wants to deal with new pages not edits (?) However it seems that this still triggers on all edits. Perhaps it should look at

[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension

2017-01-25 Thread gerritbot
gerritbot added a comment. Change 334041 merged by jenkins-bot: Switch to sha256 hash https://gerrit.wikimedia.org/r/334041TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Bawolff,

[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension

2017-01-25 Thread gerritbot
gerritbot added a comment. Change 334032 merged by jenkins-bot: Add note about interwiki lang link assumption to README https://gerrit.wikimedia.org/r/334032TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension

2017-01-25 Thread gerritbot
gerritbot added a comment. Change 334033 merged by jenkins-bot: Adjust index on pages table https://gerrit.wikimedia.org/r/334033TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot,

[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension

2017-01-25 Thread gerritbot
gerritbot added a comment. Change 334031 merged by jenkins-bot: populateCognatePages use mw db layer for IN query https://gerrit.wikimedia.org/r/334031TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension

2017-01-25 Thread Addshore
Addshore added a comment. Everything from the security review now either has a patch linked to this ticket or a subtask has been created. In response to the issue with hash conflicts, pages that create duplicate hashes will simply not be written to the database / ignored, thus it should not be an

[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension

2017-01-25 Thread gerritbot
gerritbot added a comment. Change 334041 had a related patch set uploaded (by Addshore): Switch to sha256 hash https://gerrit.wikimedia.org/r/334041TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension

2017-01-25 Thread Addshore
Addshore added a comment. In T149082#2966632, @Bawolff wrote: I assume this is not using the LinkUpdates related hooks because it only wants to deal with new pages not edits (?) However it seems that this still triggers on all edits. Perhaps it should look at the EDIT_NEW flag in the

[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension

2017-01-25 Thread gerritbot
gerritbot added a comment. Change 334033 had a related patch set uploaded (by Addshore): Adjust index on pages table https://gerrit.wikimedia.org/r/334033TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension

2017-01-25 Thread gerritbot
gerritbot added a comment. Change 334032 had a related patch set uploaded (by Addshore): Add note about interwiki lang link assumption to README https://gerrit.wikimedia.org/r/334032TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T149082: Security review for Cognate Extension

2017-01-25 Thread gerritbot
gerritbot added a comment. Change 334031 had a related patch set uploaded (by Addshore): populateCognatePages use mw db layer for IN query https://gerrit.wikimedia.org/r/334031TASK DETAILhttps://phabricator.wikimedia.org/T149082EMAIL