[xen-unstable test] 185169: regressions - FAIL

2024-03-27 Thread osstest service owner
flight 185169 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185169/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 185162 Tests which are

[linux-5.4 test] 185168: tolerable FAIL - PUSHED

2024-03-27 Thread osstest service owner
flight 185168 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/185168/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit1 14 guest-start fail like 185071 test-armhf-armhf-xl-multivcpu 18

Re: Linux Xen PV CPA W^X violation false-positives

2024-03-27 Thread Jason Andryuk
On Wed, Mar 27, 2024 at 7:46 AM Jürgen Groß wrote: > > On 24.01.24 17:54, Jason Andryuk wrote: > > + > > + return new; > > + } > > + } > > + > > end = start + npg * PAGE_SIZE - 1; > > WARN_ONCE(1, "CPA detected W^X violation: %016llx -> %016llx

[linux-6.1 test] 185167: tolerable FAIL - PUSHED

2024-03-27 Thread osstest service owner
flight 185167 linux-6.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/185167/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185053 test-amd64-amd64-xl-qemuu-win7-amd64

[PATCH v6] RFC: x86/pvh: Make Xen PVH entrypoint PIC for x86-64

2024-03-27 Thread Jason Andryuk
The Xen PVH entrypoint is 32bit non-PIC code running at a default load address of 0x100 (16MB) (CONFIG_PHYSICAL_START). Xen loads the kernel at that physical address inside the PVH container. When running a PVH Dom0, the system reserved addresses are mapped 1-1 into the PVH container. There

[PATCH v6 3/4] libelf: Store maximum PHDR p_align

2024-03-27 Thread Jason Andryuk
While parsing the PHDRs, store the maximum p_align value. This may be consulted for moving a PVH image's load address. Signed-off-by: Jason Andryuk --- v6: New --- xen/common/libelf/libelf-loader.c | 15 +++ xen/include/xen/libelf.h | 1 + 2 files changed, 12

[PATCH v6 1/4] tools/init-xenstore-domain: Replace variable MB() usage

2024-03-27 Thread Jason Andryuk
The local MB() & GB() macros will be replaced with a common implementation, but those only work with constant values. Introduce a static inline mb_to_bytes() in place of the MB() macro to convert the variable values. Signed-off-by: Jason Andryuk --- v4: New ---

[PATCH v6 4/4] x86/PVH: Support relocatable dom0 kernels

2024-03-27 Thread Jason Andryuk
Xen tries to load a PVH dom0 kernel at the fixed guest physical address from the elf headers. For Linux, this defaults to 0x100 (16MB), but it can be configured. Unfortunately there exist firmwares that have reserved regions at this address, so Xen fails to load the dom0 kernel since it's

[PATCH v6 0/4] x86/pvh: Support relocating dom0 kernel

2024-03-27 Thread Jason Andryuk
Xen tries to load a PVH dom0 kernel at the fixed guest physical address from the elf headers. For Linux, this defaults to 0x100 (16MB), but it can be configured. Unfortunately there exist firmwares that have reserved regions at this address, so Xen fails to load the dom0 kernel since it's

[PATCH v6 2/4] tools: Move MB/GB() to common-macros.h

2024-03-27 Thread Jason Andryuk
Consolidate to a single set of common macros for tools. MB() will gain another use in libelf, so this movement makes it available. Requested-by: Jan Beulich Signed-off-by: Jason Andryuk Reviewed-by: Jan Beulich --- v4: New v5: Add Jan's R-b & Req-b --- tools/firmware/hvmloader/util.h

[xen-unstable-smoke test] 185176: tolerable all pass - PUSHED

2024-03-27 Thread osstest service owner
flight 185176 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185176/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[PATCH 5/6] tools/misc: xenwatchdogd enhancements

2024-03-27 Thread leigh
From: Leigh Brown Add enhanced parameter parsing and validation, making use of getopt_long(). Adds usage() function, ability to run in the foreground, and the ability to disarm the watchdog timer when exiting. Now checks the number of parameters are correct, that timeout is at least two seconds

[PATCH 1/6] tools/misc: xenwatchdogd: use EXIT_* constants

2024-03-27 Thread leigh
From: Leigh Brown Use EXIT_SUCCESS/EXIT_FAILURE constants instead of magic numbers. --- tools/misc/xenwatchdogd.c | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/tools/misc/xenwatchdogd.c b/tools/misc/xenwatchdogd.c index

[PATCH 0/6] xenwatchdogd enhancements

2024-03-27 Thread leigh
From: Leigh Brown Following up on Cyril's email. I had been independently looking at this, mainly because xenwatchdogd is simple enough for me to understand. The primary intention of this patch series is to replace the pathologically bad behaviour of rebooting the domain if you run "xenwatchdogd

[PATCH 6/6] docs/man: Add xenwatchdog manual page

2024-03-27 Thread leigh
From: Leigh Brown Add a manual page for xenwatchdogd. --- docs/man/xenwatchdogd.8.pod | 54 + 1 file changed, 54 insertions(+) create mode 100644 docs/man/xenwatchdogd.8.pod diff --git a/docs/man/xenwatchdogd.8.pod b/docs/man/xenwatchdogd.8.pod new file

[PATCH 3/6] tools/misc: xenwatchdogd: make functions static

2024-03-27 Thread leigh
From: Leigh Brown Make all functions except main() static in xenwatchdogd.c. --- tools/misc/xenwatchdogd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/misc/xenwatchdogd.c b/tools/misc/xenwatchdogd.c index d4da0ad0b6..224753e824 100644 ---

[PATCH 4/6] tools/misc: xenwatchdogd: add parse_secs()

2024-03-27 Thread leigh
From: Leigh Brown Create a new parse_secs() function to parse the timeout and sleep parameters. This ensures that non-numeric parameters are not accidentally treated as numbers. --- tools/misc/xenwatchdogd.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff

[PATCH 2/6] tools/misc: rework xenwatchdogd signal handling

2024-03-27 Thread leigh
From: Leigh Brown Rework xenwatchdogd signal handling to do the minimum in the signal handler. This is a very minor enhancement. --- tools/misc/xenwatchdogd.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/tools/misc/xenwatchdogd.c

Re: Serious AMD-Vi(?) issue

2024-03-27 Thread Elliott Mitchell
On Mon, Mar 25, 2024 at 02:43:44PM -0700, Elliott Mitchell wrote: > On Mon, Mar 25, 2024 at 08:55:56AM +0100, Jan Beulich wrote: > > On 22.03.2024 20:22, Elliott Mitchell wrote: > > > On Fri, Mar 22, 2024 at 04:41:45PM +, Kelly Choi wrote: > > >> > > >> I can see you've recently engaged with

Re: [PATCH-for-9.0 v2 16/19] hw/xen/xen_pt: Add missing license

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:12PM +0100, Philippe Mathieu-Daudé wrote: > Commit eaab4d60d3 ("Introduce Xen PCI Passthrough, qdevice") > introduced both xen_pt.[ch], but only added the license to > xen_pt.c. Use the same license for xen_pt.h. > > Suggested-by: David Woodhouse > Signed-off-by:

Re: [PATCH-for-9.0 v2 15/19] hw/xen: Reduce inclusion of 'cpu.h' to target-specific sources

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:11PM +0100, Philippe Mathieu-Daudé wrote: > We rarely need to include "cpu.h" in headers. Including it > 'taint' headers to be target-specific. Here only the i386/arm > implementations requires "cpu.h", so include it there and > remove from the

Re: [PATCH v2 3/3] svm/nestedsvm: Introduce nested capabilities bit

2024-03-27 Thread George Dunlap
On Mon, Mar 18, 2024 at 2:17 PM Jan Beulich wrote: > > On 13.03.2024 13:24, George Dunlap wrote: > > In order to make implementation and testing tractable, we will require > > specific host functionality. Add a nested_virt bit to hvm_funcs.caps, > > and return an error if a domain is created

Re: [RFC PATCH-for-9.0 v2 13/19] hw/xen: Remove use of 'target_ulong' in handle_ioreq()

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:09PM +0100, Philippe Mathieu-Daudé wrote: > Per commit f17068c1c7 ("xen-hvm: reorganize xen-hvm and move common > function to xen-hvm-common"), handle_ioreq() is expected to be > target-agnostic. However it uses 'target_ulong', which is a target > specific definition.

Re: [PATCH v1] tools/ocaml: fix warnings

2024-03-27 Thread Andrew Cooper
On 27/03/2024 4:30 pm, Edwin Török wrote: > Do not rely on the string values of the `Failure` exception, > but use the `_opt` functions instead. > > Signed-off-by: Edwin Török FWIW, Tested-by: Andrew Cooper But I think the subject wants to say "in config.ml" and the commit message gain

[PATCH v1] tools/ocaml: fix warnings

2024-03-27 Thread Edwin Török
Do not rely on the string values of the `Failure` exception, but use the `_opt` functions instead. Signed-off-by: Edwin Török --- tools/ocaml/xenstored/config.ml | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/tools/ocaml/xenstored/config.ml

[xen-unstable-smoke test] 185173: tolerable all pass - PUSHED

2024-03-27 Thread osstest service owner
flight 185173 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185173/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: preparations for 4.17.4

2024-03-27 Thread Christian Lindig
> On 27 Mar 2024, at 14:42, Andrew Cooper wrote: > > On 27/03/2024 2:06 pm, Jan Beulich wrote: >> On 27.03.2024 15:01, Andrew Cooper wrote: >>> It occurs to me that these want considering: >>> >>> b6cf604207fd - tools/oxenstored: Use Map instead of Hashtbl for quotas >>> 098d868e52ac -

Re: [PATCH] tools/oxenstored: Re-format

2024-03-27 Thread Andrew Cooper
On 27/03/2024 3:11 pm, Edwin Torok wrote: > On Mon, Feb 26, 2024 at 10:48 AM Andrew Cooper > wrote: >> Rerun make format. > Looks good, although not sure whether whitespace will be correctly > preserved in email, recommend using git to push the changes. > Reviewed-by: Edwin Török Thanks.  Don't

[PATCH v6 8/8] xen: allow up to 16383 cpus

2024-03-27 Thread Juergen Gross
With lock handling now allowing up to 16384 cpus (spinlocks can handle 65535 cpus, rwlocks can handle 16384 cpus), raise the allowed limit for the number of cpus to be configured to 16383. The new limit is imposed by IOMMU_CMD_BUFFER_MAX_ENTRIES and QINVAL_MAX_ENTRY_NR required to be larger than

[PATCH v6 6/8] xen/spinlock: support higher number of cpus

2024-03-27 Thread Juergen Gross
Allow 16 bits per cpu number, which is the limit imposed by spinlock_tickets_t. This will allow up to 65535 cpus, while increasing only the size of recursive spinlocks in debug builds from 8 to 12 bytes. The current Xen limit of 4095 cpus is imposed by SPINLOCK_CPU_BITS being 12. There are

[PATCH v6 7/8] xen/rwlock: raise the number of possible cpus

2024-03-27 Thread Juergen Gross
The rwlock handling is limiting the number of cpus to 4095 today. The main reason is the use of the atomic_t data type for the main lock handling, which needs 2 bits for the locking state (writer waiting or write locked), 12 bits for the id of a possible writer, and a 12 bit counter for readers.

[PATCH v6 4/8] xen/spinlock: split recursive spinlocks from normal ones

2024-03-27 Thread Juergen Gross
Recursive and normal spinlocks are sharing the same data structure for representation of the lock. This has two major disadvantages: - it is not clear from the definition of a lock, whether it is intended to be used recursive or not, while a mixture of both usage variants needs to be - in

[PATCH v6 2/8] xen/spinlock: add another function level

2024-03-27 Thread Juergen Gross
Add another function level in spinlock.c hiding the spinlock_t layout from the low level locking code. This is done in preparation of introducing rspinlock_t for recursive locks without having to duplicate all of the locking code. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V2: -

[PATCH v6 5/8] xen/spinlock: let all is_locked and trylock variants return bool

2024-03-27 Thread Juergen Gross
Switch the remaining trylock and is_locked variants to return bool. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V5: - new patch (Jan Beulich) --- xen/common/spinlock.c | 4 ++-- xen/include/xen/spinlock.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v6 0/8] xen/spinlock: make recursive spinlocks a dedicated type

2024-03-27 Thread Juergen Gross
Instead of being able to use normal spinlocks as recursive ones, too, make recursive spinlocks a special lock type. This will make the spinlock structure smaller in production builds and add type-safety. This allows to increase the maximum number of physical cpus from 4095 to 65535 without

[PATCH v6 3/8] xen/spinlock: add missing rspin_is_locked() and rspin_barrier()

2024-03-27 Thread Juergen Gross
Add rspin_is_locked() and rspin_barrier() in order to prepare differing spinlock_t and rspinlock_t types. Signed-off-by: Juergen Gross --- V2: - partially carved out from V1 patch, partially new V5: - let rspin_is_locked() return bool (Jan Beulich) V6: - Re-add comment to _spin_is_locked() (Jan

[PATCH v6 1/8] xen/spinlock: add explicit non-recursive locking functions

2024-03-27 Thread Juergen Gross
In order to prepare a type-safe recursive spinlock structure, add explicitly non-recursive locking functions to be used for non-recursive locking of spinlocks, which are used recursively, too. Signed-off-by: Juergen Gross Acked-by: Jan Beulich --- V2: - rename functions (Jan Beulich) - get rid

Re: [PATCH] tools/oxenstored: Re-format

2024-03-27 Thread Edwin Torok
On Mon, Feb 26, 2024 at 10:48 AM Andrew Cooper wrote: > > Rerun make format. Looks good, although not sure whether whitespace will be correctly preserved in email, recommend using git to push the changes. Reviewed-by: Edwin Török > > Signed-off-by: Andrew Cooper > --- > CC: Christian Lindig

Re: [PATCH v5 1/6] Revert "xen/x86: bzImage parse kernel_alignment"

2024-03-27 Thread Jason Andryuk
On 2024-03-27 10:19, Jan Beulich wrote: On 27.03.2024 15:08, Jason Andryuk wrote: On 2024-03-27 04:59, Roger Pau Monné wrote: On Wed, Mar 27, 2024 at 08:22:41AM +0100, Jan Beulich wrote: On 26.03.2024 22:38, Jason Andryuk wrote: A new ELF note will specify the alignment for a relocatable PVH

Re: preparations for 4.17.4

2024-03-27 Thread Andrew Cooper
On 27/03/2024 2:06 pm, Jan Beulich wrote: > On 27.03.2024 15:01, Andrew Cooper wrote: >> It occurs to me that these want considering: >> >> b6cf604207fd - tools/oxenstored: Use Map instead of Hashtbl for quotas >> 098d868e52ac - tools/oxenstored: Make Quota.t pure >> >> while 4.17 is still in

Re: [PATCH-for-9.0 v2 12/19] hw/xen: Merge 'hw/xen/arch_hvm.h' in 'hw/xen/xen-hvm-common.h'

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:08PM +0100, Philippe Mathieu-Daudé wrote: > We don't need a target-specific header for common target-specific > prototypes. Declare xen_arch_handle_ioreq() and xen_arch_set_memory() > in "hw/xen/xen-hvm-common.h". > > Signed-off-by: Philippe Mathieu-Daudé >

Re: [PATCH v5 1/6] Revert "xen/x86: bzImage parse kernel_alignment"

2024-03-27 Thread Jan Beulich
On 27.03.2024 15:08, Jason Andryuk wrote: > On 2024-03-27 04:59, Roger Pau Monné wrote: >> On Wed, Mar 27, 2024 at 08:22:41AM +0100, Jan Beulich wrote: >>> On 26.03.2024 22:38, Jason Andryuk wrote: A new ELF note will specify the alignment for a relocatable PVH kernel. ELF notes are

Re: [PATCH v5] RFC: x86/pvh: Make Xen PVH entrypoint PIC for x86-64

2024-03-27 Thread Jason Andryuk
On 2024-03-27 04:20, Jan Beulich wrote: On 26.03.2024 22:47, Jason Andryuk wrote: --- a/include/xen/interface/elfnote.h +++ b/include/xen/interface/elfnote.h @@ -185,9 +185,25 @@ */ #define XEN_ELFNOTE_PHYS32_ENTRY 18 +/* + * Physical loading constraints for PVH kernels + * + * Used to

Re: [PATCH v5 1/6] Revert "xen/x86: bzImage parse kernel_alignment"

2024-03-27 Thread Jason Andryuk
On 2024-03-27 04:59, Roger Pau Monné wrote: On Wed, Mar 27, 2024 at 08:22:41AM +0100, Jan Beulich wrote: On 26.03.2024 22:38, Jason Andryuk wrote: A new ELF note will specify the alignment for a relocatable PVH kernel. ELF notes are suitable for vmlinux and other ELF files, so this

Re: preparations for 4.17.4

2024-03-27 Thread Jan Beulich
On 27.03.2024 15:01, Andrew Cooper wrote: > It occurs to me that these want considering: > > b6cf604207fd - tools/oxenstored: Use Map instead of Hashtbl for quotas > 098d868e52ac - tools/oxenstored: Make Quota.t pure > > while 4.17 is still in general support.  These came from a performance >

[linux-linus test] 185166: tolerable FAIL - PUSHED

2024-03-27 Thread osstest service owner
flight 185166 linux-linus real [real] flight 185174 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/185166/ http://logs.test-lab.xenproject.org/osstest/logs/185174/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: preparations for 4.17.4

2024-03-27 Thread Andrew Cooper
On 27/03/2024 12:33 pm, Andrew Cooper wrote: > On 27/03/2024 12:23 pm, Jan Beulich wrote: >> All, >> >> the release is due in two to three weeks. Please point out backports you find >> missing from the respective staging branch, but which you consider relevant. >> >> Note that this is going to be

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-27 Thread Julien Grall
On 27/03/2024 13:38, Jan Beulich wrote: On 27.03.2024 14:28, Julien Grall wrote: Hi Carlo, On 27/03/2024 11:10, Carlo Nonato wrote: Hi guys, Question is: How would you justify such a change? IOW I'm not convinced (yet) this wants doing there. You mean in this series? Looking at the

Re: [XEN PATCH 0/6] FF-A mediator reorganisation

2024-03-27 Thread Bertrand Marquis
Hi Jens, > On 25 Mar 2024, at 10:38, Jens Wiklander wrote: > > Hi, > > The FF-A mediator is reorganized into modules for easier maintenance and to > prepare for future changes. This patch set is not expected add any changed > behaviour, except for the "xen/arm: ffa: support FFA_FEATURES"

Re: [XEN PATCH 6/6] xen/arm: ffa: support FFA_FEATURES

2024-03-27 Thread Bertrand Marquis
Hi Jens, > On 25 Mar 2024, at 10:39, Jens Wiklander wrote: > > Add support for the mandatory FF-A ABI function FFA_FEATURES. > > Signed-off-by: Jens Wiklander Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/tee/ffa.c | 57 ++ > 1

Re: [XEN PATCH 5/6] xen/arm: ffa: separate rxtx buffer routines

2024-03-27 Thread Bertrand Marquis
Hi Jens, > On 25 Mar 2024, at 10:39, Jens Wiklander wrote: > > Move rxtx buffer routines into a spearate file for easier navigation in > the source code. > > Add ffa_rxtx_init(), ffa_rxtx_destroy(), and ffa_rxtx_domain_destroy() to > handle the ffa_rxtx internal things on initialization and

Re: [XEN PATCH 4/6] xen/arm: ffa: separate partition info get routines

2024-03-27 Thread Bertrand Marquis
Hi Jens, > On 25 Mar 2024, at 10:39, Jens Wiklander wrote: > > Move partition info get routines into a separate file for easier > navigation in the source code. > > Add ffa_partinfo_init(), ffa_partinfo_domain_init(), and > ffa_partinfo_domain_destroy() to handle the ffa_partinfo internal

Re: [XEN PATCH 3/6] xen/arm: ffa: separate memory sharing routines

2024-03-27 Thread Bertrand Marquis
Hi Jens, > On 25 Mar 2024, at 10:39, Jens Wiklander wrote: > > Move memory sharing routines into a separate file for easier navigation > in the source code. > > Add ffa_shm_domain_destroy() to isolate the ffa_shm things in > ffa_domain_teardown_continue(). > > Signed-off-by: Jens Wiklander

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-27 Thread Jan Beulich
On 27.03.2024 14:28, Julien Grall wrote: > Hi Carlo, > > On 27/03/2024 11:10, Carlo Nonato wrote: >> Hi guys, >> >>> Question is: How would you justify such a change? IOW I'm not convinced >>> (yet) this wants doing there. >> >> You mean in this series? >> >>> Looking at the code, the flag is

Re: [PATCH-for-9.0 v2 11/19] hw/xen/xen_arch_hvm: Rename prototypes using 'xen_arch_' prefix

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:07PM +0100, Philippe Mathieu-Daudé wrote: > Use a common 'xen_arch_' prefix for architecture-specific functions. > Rename xen_arch_set_memory() and xen_arch_handle_ioreq(). > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: David Woodhouse > Reviewed-by:

Re: [RFC PATCH-for-9.0 v2 09/19] hw/block/xen_blkif: Align structs with QEMU_ALIGNED() instead of #pragma

2024-03-27 Thread David Woodhouse
On 27 March 2024 13:31:52 GMT, Anthony PERARD wrote: >On Tue, Nov 14, 2023 at 03:38:05PM +0100, Philippe Mathieu-Daudé wrote: >> Except imported source files, QEMU code base uses >> the QEMU_ALIGNED() macro to align its structures. > >This patch only convert the alignment, but discard pack. We

Re: [XEN PATCH 2/6] xen/arm: ffa: move common things to ffa_private.h

2024-03-27 Thread Bertrand Marquis
Hi Jens, > On 25 Mar 2024, at 10:39, Jens Wiklander wrote: > > Prepare to separate ffa.c into modules by moving common things into the > new internal header file ffa_private.h. > > Signed-off-by: Jens Wiklander Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/tee/ffa.c

Re: [RFC PATCH-for-9.0 v2 09/19] hw/block/xen_blkif: Align structs with QEMU_ALIGNED() instead of #pragma

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:05PM +0100, Philippe Mathieu-Daudé wrote: > Except imported source files, QEMU code base uses > the QEMU_ALIGNED() macro to align its structures. This patch only convert the alignment, but discard pack. We need both or the struct is changed. > --- >

Re: [XEN PATCH 1/6] xen/arm: ffa: rename functions to use ffa_ prefix

2024-03-27 Thread Bertrand Marquis
Hi Jens, > On 25 Mar 2024, at 10:38, Jens Wiklander wrote: > > Prepare to separate into modules by renaming functions that will need > new names when becoming non-static in the following commit. > > Signed-off-by: Jens Wiklander Reviewed-by: Bertrand Marquis Cheers Bertrand > --- >

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-27 Thread Julien Grall
Hi Carlo, On 27/03/2024 11:10, Carlo Nonato wrote: Hi guys, Question is: How would you justify such a change? IOW I'm not convinced (yet) this wants doing there. You mean in this series? Looking at the code, the flag is originally set in alloc_domheap_pages(). So I guess it would make

Re: Xen NIC driver have page_pool memory leaks

2024-03-27 Thread Denis Kirjanov
On 3/27/24 14:27, Jesper Dangaard Brouer wrote: > > > On 25/03/2024 13.33, Paul Durrant wrote: >> On 25/03/2024 12:21, Jesper Dangaard Brouer wrote: >>> Hi Arthur, >>> >>> (Answer inlined below, which is custom on this mailing list) >>> >>> On 23/03/2024 14.23, Arthur Borsboom wrote: Hi

Re: preparations for 4.17.4

2024-03-27 Thread Andrew Cooper
On 27/03/2024 12:23 pm, Jan Beulich wrote: > All, > > the release is due in two to three weeks. Please point out backports you find > missing from the respective staging branch, but which you consider relevant. > > Note that this is going to be the last Xen Project coordinated ordinary stable >

preparations for 4.17.4

2024-03-27 Thread Jan Beulich
All, the release is due in two to three weeks. Please point out backports you find missing from the respective staging branch, but which you consider relevant. Note that this is going to be the last Xen Project coordinated ordinary stable release from this branch; the branch will move into

[PATCH net] xen-netfront: Add missing skb_mark_for_recycle

2024-03-27 Thread Jesper Dangaard Brouer
Notice that skb_mark_for_recycle() is introduced later than fixes tag in 6a5bcd84e886 ("page_pool: Allow drivers to hint on SKB recycling"). It is believed that fixes tag were missing a call to page_pool_release_page() between v5.9 to v5.14, after which is should have used skb_mark_for_recycle().

Re: [PATCH v7 04/14] xen/arm: add Dom0 cache coloring support

2024-03-27 Thread Michal Orzel
On 27/03/2024 12:39, Carlo Nonato wrote: > > > Hi guys, > > On Fri, Mar 22, 2024 at 8:26 AM Jan Beulich wrote: >> >> On 21.03.2024 18:31, Carlo Nonato wrote: >>> On Thu, Mar 21, 2024 at 4:57 PM Jan Beulich wrote: On 21.03.2024 16:04, Carlo Nonato wrote: > On Tue, Mar 19, 2024

Re: [PATCH v7 04/14] xen/arm: add Dom0 cache coloring support

2024-03-27 Thread Julien Grall
Hi, On 27/03/2024 11:39, Carlo Nonato wrote: On Fri, Mar 22, 2024 at 8:26 AM Jan Beulich wrote: On 21.03.2024 18:31, Carlo Nonato wrote: On Thu, Mar 21, 2024 at 4:57 PM Jan Beulich wrote: On 21.03.2024 16:04, Carlo Nonato wrote: On Tue, Mar 19, 2024 at 4:30 PM Jan Beulich wrote: On

Re: [PATCH-for-9.0 v2 08/19] hw/xen: Remove unused Xen stubs

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:04PM +0100, Philippe Mathieu-Daudé wrote: > All these stubs are protected by a 'if (xen_enabled())' check. Are you sure? There's still nothing that prevent a compiler from wanting those, I don't think. Sure, often compilers will remove dead code in `if(0){...}`, but

Re: [PATCH-for-9.0 v2 05/19] hw/display: Restrict xen_register_framebuffer() call to Xen

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:01PM +0100, Philippe Mathieu-Daudé wrote: > Only call xen_register_framebuffer() when Xen is enabled. > > Signed-off-by: Philippe Mathieu-Daudé I don't think this patch is very useful but it's fine, so: Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: Linux Xen PV CPA W^X violation false-positives

2024-03-27 Thread Jürgen Groß
On 24.01.24 17:54, Jason Andryuk wrote: Xen PV domains show CPA W^X violations like: CPA detected W^X violation: 0064 -> 0067 range: 0x8881 - 0x88810fff PFN 10 WARNING: CPU: 0 PID: 30 at arch/x86/mm/pat/set_memory.c:613

Re: [PATCH v7 04/14] xen/arm: add Dom0 cache coloring support

2024-03-27 Thread Carlo Nonato
Hi guys, On Fri, Mar 22, 2024 at 8:26 AM Jan Beulich wrote: > > On 21.03.2024 18:31, Carlo Nonato wrote: > > On Thu, Mar 21, 2024 at 4:57 PM Jan Beulich wrote: > >> > >> On 21.03.2024 16:04, Carlo Nonato wrote: > >>> On Tue, Mar 19, 2024 at 4:30 PM Jan Beulich wrote: > On 15.03.2024

[xen-unstable-smoke test] 185170: tolerable all pass - PUSHED

2024-03-27 Thread osstest service owner
flight 185170 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185170/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: Backport request for 4.17

2024-03-27 Thread Jan Beulich
On 25.03.2024 18:02, Anthony PERARD wrote: > Would it be possible to backport 18a36b4a9b08 ("tools: ipxe: update for > fixing build with GCC12") to Xen 4.17 ? Sure, now done. Jan > This would be to allow building Xen 4.17 on Debian Bookworm, and to allow > osstest to test Xen 4.18 with Debian

Re: Xen NIC driver have page_pool memory leaks

2024-03-27 Thread Andrew Cooper
On 27/03/2024 11:27 am, Jesper Dangaard Brouer wrote: > > > On 25/03/2024 13.33, Paul Durrant wrote: >> On 25/03/2024 12:21, Jesper Dangaard Brouer wrote: >>> Hi Arthur, >>> >>> (Answer inlined below, which is custom on this mailing list) >>> >>> On 23/03/2024 14.23, Arthur Borsboom wrote: Hi

Re: Xen NIC driver have page_pool memory leaks

2024-03-27 Thread Jesper Dangaard Brouer
On 25/03/2024 13.33, Paul Durrant wrote: On 25/03/2024 12:21, Jesper Dangaard Brouer wrote: Hi Arthur, (Answer inlined below, which is custom on this mailing list) On 23/03/2024 14.23, Arthur Borsboom wrote: Hi Jesper, After a recent kernel upgrade 6.7.6 > 6.8.1 all my Xen guests on Arch

Re: xen | Failed pipeline for staging | e3883336

2024-03-27 Thread Andrew Cooper
On 27/03/2024 10:40 am, Jan Beulich wrote: > On 27.03.2024 10:58, GitLab wrote: >> >> Pipeline #1229415063 has failed! >> >> Project: xen ( https://gitlab.com/xen-project/hardware/xen ) >> Branch: staging ( >> https://gitlab.com/xen-project/hardware/xen/-/commits/staging ) >> >> Commit: e3883336

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-27 Thread Carlo Nonato
Hi guys, > Question is: How would you justify such a change? IOW I'm not convinced > (yet) this wants doing there. You mean in this series? > Looking at the code, the flag is originally set in > alloc_domheap_pages(). So I guess it would make sense to do it in > free_domheap_pages(). We don't

Re: [PATCH v6 10/20] xen/riscv: introduce atomic.h

2024-03-27 Thread Jan Beulich
On 27.03.2024 11:28, Oleksii wrote: > On Wed, 2024-03-27 at 08:40 +0100, Jan Beulich wrote: > ... > >>> +/* This is required to provide a full barrier on success. >>> */ >>> +static inline int atomic_add_unless(atomic_t *v, int a, >>> int u) >>> +{ >>> +   int prev,

Re: xen | Failed pipeline for staging | e3883336

2024-03-27 Thread Jan Beulich
On 27.03.2024 10:58, GitLab wrote: > > > Pipeline #1229415063 has failed! > > Project: xen ( https://gitlab.com/xen-project/hardware/xen ) > Branch: staging ( > https://gitlab.com/xen-project/hardware/xen/-/commits/staging ) > > Commit: e3883336 ( >

Re: [PATCH v6 10/20] xen/riscv: introduce atomic.h

2024-03-27 Thread Oleksii
On Wed, 2024-03-27 at 08:40 +0100, Jan Beulich wrote: ... > > > > > > +/* This is required to provide a full barrier on success. > > > > > > */ > > > > > > +static inline int atomic_add_unless(atomic_t *v, int a, > > > > > > int u) > > > > > > +{ > > > > > > +   int prev, rc; > > > > > > + >

Xen Summit Early Bird Rates - Ends 31st March 2024!

2024-03-27 Thread Kelly Choi
Hey everyone, We've just announced our schedule for Xen Summit 2024 and can't wait to see you all. *Make sure to grab your early-rate tickets today, these end on 31st March 2024! * Academics can also attend the event for free. Tickets:

Re: [PATCH v5 1/6] Revert "xen/x86: bzImage parse kernel_alignment"

2024-03-27 Thread Roger Pau Monné
On Wed, Mar 27, 2024 at 08:22:41AM +0100, Jan Beulich wrote: > On 26.03.2024 22:38, Jason Andryuk wrote: > > A new ELF note will specify the alignment for a relocatable PVH kernel. > > ELF notes are suitable for vmlinux and other ELF files, so this > > Linux-specific bzImage parsing in

Re: [PATCH 11/11] xen/arm: List static shared memory regions as /memory nodes

2024-03-27 Thread Michal Orzel
Hi Luca, On 26/03/2024 15:19, Luca Fancellu wrote: > > >> On 25 Mar 2024, at 08:58, Michal Orzel wrote: >> >> Hi Luca, >> > > Hi Michal, > >> On 12/03/2024 14:03, Luca Fancellu wrote: >>> >>> >>> Currently Xen is not exporting the static shared memory regions >>> to the device tree as

Re: [PATCH v5] RFC: x86/pvh: Make Xen PVH entrypoint PIC for x86-64

2024-03-27 Thread Jan Beulich
On 26.03.2024 22:47, Jason Andryuk wrote: > --- a/include/xen/interface/elfnote.h > +++ b/include/xen/interface/elfnote.h > @@ -185,9 +185,25 @@ > */ > #define XEN_ELFNOTE_PHYS32_ENTRY 18 > > +/* > + * Physical loading constraints for PVH kernels > + * > + * Used to place constraints on the

Re: [XEN PATCH 11/11] x86/public: hvm: address violations of MISRA C Rule 20.7

2024-03-27 Thread Jan Beulich
On 22.03.2024 17:02, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

Re: [PATCH v6 10/20] xen/riscv: introduce atomic.h

2024-03-27 Thread Jan Beulich
On 26.03.2024 20:02, Oleksii wrote: > On Mon, 2024-03-25 at 09:18 +0100, Jan Beulich wrote: >> On 22.03.2024 13:25, Oleksii wrote: >>> On Thu, 2024-03-21 at 14:03 +0100, Jan Beulich wrote: On 15.03.2024 19:06, Oleksii Kurochko wrote: > + */ > +static always_inline void

Re: [PATCH v5 4/6] libelf: Expand ELF note printing

2024-03-27 Thread Jan Beulich
On 26.03.2024 22:38, Jason Andryuk wrote: > @@ -145,13 +150,20 @@ elf_errorstatus elf_xen_parse_note(struct elf_binary > *elf, > elf_msg(elf, "ELF: note: %s = \"%s\"\n", note_desc[type].name, str); > parms->elf_notes[type].type = XEN_ENT_STR; >

Re: [PATCH v5 5/6] xen/elfnote: Specify ELF Notes are x86-specific

2024-03-27 Thread Jan Beulich
On 26.03.2024 22:38, Jason Andryuk wrote: > The Xen ELF Notes are only used with x86. libelf's elf_xen_note_check() > exits early for ARM binaries with "ELF: Not bothering with notes on > ARM". > > Add a comment to the top of elfnote.h specifying that Notes are only used > with x86 binaries.

Re: [PATCH v5 1/6] Revert "xen/x86: bzImage parse kernel_alignment"

2024-03-27 Thread Jan Beulich
On 26.03.2024 22:38, Jason Andryuk wrote: > A new ELF note will specify the alignment for a relocatable PVH kernel. > ELF notes are suitable for vmlinux and other ELF files, so this > Linux-specific bzImage parsing in unnecessary. > > This reverts commit c44cac229067faeec8f49247d1cf281723ac2d40.

Re: [PATCH] x86/vcpu: relax VCPUOP_initialise restriction for non-PV vCPUs

2024-03-27 Thread Jan Beulich
On 26.03.2024 23:08, Julien Grall wrote: > Hi Andrew, > > On 20/03/2024 14:39, Andrew Cooper wrote: >> On 20/03/2024 2:26 pm, Roger Pau Monné wrote: >>> On Wed, Mar 20, 2024 at 02:06:27PM +, Andrew Cooper wrote: On 20/03/2024 1:57 pm, Roger Pau Monne wrote: > There's no reason to