Re: [XEN PATCH 04/10] drivers: char: address violation of MISRA C Rule 20.7

On 2024-04-24 09:23, Jan Beulich wrote: On 23.04.2024 17:12, Nicola Vetrini wrote: --- a/xen/drivers/char/omap-uart.c +++ b/xen/drivers/char/omap-uart.c @@ -48,8 +48,9 @@ /* System configuration register */ #define UART_OMAP_SYSC_DEF_CONF 0x0d /* autoidle mode, wakeup is enabled */

Re: [XEN PATCH 04/10] drivers: char: address violation of MISRA C Rule 20.7

On 23.04.2024 17:12, Nicola Vetrini wrote: > --- a/xen/drivers/char/omap-uart.c > +++ b/xen/drivers/char/omap-uart.c > @@ -48,8 +48,9 @@ > /* System configuration register */ > #define UART_OMAP_SYSC_DEF_CONF 0x0d /* autoidle mode, wakeup is enabled > */ > > -#define omap_read(uart, off)

[XEN PATCH 04/10] drivers: char: address violation of MISRA C Rule 20.7

MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly