Re: [XEN PATCH v2 1/9] x86/vlapic: tidy switch statement and address MISRA violation

2024-04-17 Thread Jan Beulich
On 11.04.2024 14:03, Andrew Cooper wrote: > On 09/04/2024 8:45 pm, Nicola Vetrini wrote: >> On 2024-04-08 09:32, Jan Beulich wrote: >>> On 05.04.2024 11:14, Nicola Vetrini wrote: Remove unneded blank lines between switch clauses. >>> >>> "Unneeded" based on what? We're carefully trying to

Re: [XEN PATCH v2 1/9] x86/vlapic: tidy switch statement and address MISRA violation

2024-04-11 Thread Nicola Vetrini
On 2024-04-11 14:03, Andrew Cooper wrote: On 09/04/2024 8:45 pm, Nicola Vetrini wrote: On 2024-04-08 09:32, Jan Beulich wrote: On 05.04.2024 11:14, Nicola Vetrini wrote: Remove unneded blank lines between switch clauses. "Unneeded" based on what? We're carefully trying to improve

Re: [XEN PATCH v2 1/9] x86/vlapic: tidy switch statement and address MISRA violation

2024-04-11 Thread Andrew Cooper
On 09/04/2024 8:45 pm, Nicola Vetrini wrote: > On 2024-04-08 09:32, Jan Beulich wrote: >> On 05.04.2024 11:14, Nicola Vetrini wrote: >>> Remove unneded blank lines between switch clauses. >> >> "Unneeded" based on what? We're carefully trying to improve >> readability of >> large switch()

Re: [XEN PATCH v2 1/9] x86/vlapic: tidy switch statement and address MISRA violation

2024-04-09 Thread Nicola Vetrini
On 2024-04-08 09:32, Jan Beulich wrote: On 05.04.2024 11:14, Nicola Vetrini wrote: Remove unneded blank lines between switch clauses. "Unneeded" based on what? We're carefully trying to improve readability of large switch() statements by adding such blank lines (at least) between non-

Re: [XEN PATCH v2 1/9] x86/vlapic: tidy switch statement and address MISRA violation

2024-04-08 Thread Stefano Stabellini
On Mon, 8 Apr 2024, Jan Beulich wrote: > On 05.04.2024 11:14, Nicola Vetrini wrote: > > Remove unneded blank lines between switch clauses. > > "Unneeded" based on what? We're carefully trying to improve readability of > large switch() statements by adding such blank lines (at least) between non-

Re: [XEN PATCH v2 1/9] x86/vlapic: tidy switch statement and address MISRA violation

2024-04-08 Thread Jan Beulich
On 05.04.2024 11:14, Nicola Vetrini wrote: > Remove unneded blank lines between switch clauses. "Unneeded" based on what? We're carefully trying to improve readability of large switch() statements by adding such blank lines (at least) between non- fall-through case blocks, and you go and remove

[XEN PATCH v2 1/9] x86/vlapic: tidy switch statement and address MISRA violation

2024-04-05 Thread Nicola Vetrini
Remove unneded blank lines between switch clauses. Refactor the last clauses so that a violation of MISRA C Rule 16.2 is resolved (A switch label shall only be used when the most closely-enclosing compound statement is the body of a switch statement). The switch clause ending with the pseudo