Re: [XEN PATCH v2 29/29] tools/ocaml: fix build dependency target

2022-02-25 Thread Edwin Torok
> On 25 Feb 2022, at 16:28, Anthony PERARD wrote: > > On Fri, Feb 25, 2022 at 03:30:59PM +, Christian Lindig wrote: >> >> >>> On 25 Feb 2022, at 15:13, Anthony PERARD wrote: >>> >>> This patch fix ".ocamldep.make" rule by always spelling the variable >>> $(OCAML_TOPLEVEL). >>> >>>

Re: [XEN PATCH v2 29/29] tools/ocaml: fix build dependency target

2022-02-25 Thread Anthony PERARD
On Fri, Feb 25, 2022 at 03:30:59PM +, Christian Lindig wrote: > > > > On 25 Feb 2022, at 15:13, Anthony PERARD wrote: > > > > This patch fix ".ocamldep.make" rule by always spelling the variable > > $(OCAML_TOPLEVEL). > > > > Signed-off-by: Anthony PERARD > > --- > > > > Notes: > >

Re: [XEN PATCH v2 29/29] tools/ocaml: fix build dependency target

2022-02-25 Thread Christian Lindig
> On 25 Feb 2022, at 15:13, Anthony PERARD wrote: > > This patch fix ".ocamldep.make" rule by always spelling the variable > $(OCAML_TOPLEVEL). > > Signed-off-by: Anthony PERARD > --- > > Notes: >v2: >- new patch > > tools/ocaml/libs/eventchn/Makefile | 8 >

[XEN PATCH v2 29/29] tools/ocaml: fix build dependency target

2022-02-25 Thread Anthony PERARD
They are two competiting spelling for the variable holding the path to "tools/ocaml", $(TOPLEVEL) and $(OCAML_TOPLEVEL). The "Makefile.rules" which is included in all ocaml Makefiles have one rule which make use of that variable which is then sometime unset. When building "ocaml/xenstored", make