[xen-unstable test] 185786: tolerable FAIL - PUSHED

2024-04-24 Thread osstest service owner
flight 185786 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185786/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185780

[ovmf test] 185792: all pass - PUSHED

2024-04-24 Thread osstest service owner
flight 185792 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/185792/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 66c24219ade92b85b24f3ce29b988d187a9f6517 baseline version: ovmf

[xen-unstable-smoke test] 185790: tolerable all pass - PUSHED

2024-04-24 Thread osstest service owner
flight 185790 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185790/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[linux-linus test] 185785: regressions - FAIL

2024-04-24 Thread osstest service owner
flight 185785 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/185785/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-raw 8 xen-boot fail REGR. vs. 185768

[ovmf test] 185789: all pass - PUSHED

2024-04-24 Thread osstest service owner
flight 185789 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/185789/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 90b6725562c82ec630d9e0cb19078f4b507db10b baseline version: ovmf

Re: [PATCH 03/15] xen/arm: Always enable IOMMU

2024-04-24 Thread Henry Wang
Hi Julien, On 4/24/2024 9:03 PM, Julien Grall wrote: Hi Henry, On 24/04/2024 04:34, Henry Wang wrote: From: Vikram Garhwal For overlay with iommu functionality to work with running VMs, we need to enable IOMMU by default for the domains. Signed-off-by: Vikram Garhwal Signed-off-by:

Re: [PATCH 14/15] add a domU script to fetch overlays and applying them to linux

2024-04-24 Thread Henry Wang
Hi Jan, On 4/24/2024 2:16 PM, Jan Beulich wrote: On 24.04.2024 05:34, Henry Wang wrote: From: Vikram Garhwal Introduce a shell script that runs in the background and calls get_overlay to retrive overlays and add them (or remove them) to Linux device tree (running as a domU). Signed-off-by:

Re: [PATCH 06/15] rangeset: Move struct range and struct rangeset to headerfile

2024-04-24 Thread Henry Wang
Hi Jan, On 4/24/2024 2:22 PM, Jan Beulich wrote: On 24.04.2024 05:34, Henry Wang wrote: From: Vikram Garhwal Move struct range, rangeset and removed static from first_range and next_range(). NAK, for going against what we do elsewhere (limiting exposure of internals). At least as long as

Re: [PATCH 11/15] tools/helpers: Add get_overlay

2024-04-24 Thread Henry Wang
Hi Jan, On 4/24/2024 2:08 PM, Jan Beulich wrote: On 24.04.2024 05:34, Henry Wang wrote: From: Vikram Garhwal This user level application copies the overlay dtbo shared by dom0 while doing overlay node assignment operation. It uses xenstore to communicate with dom0. More information on the

Re: docs/misra: add R21.6 R21.14 R21.15 R21.16

2024-04-24 Thread Stefano Stabellini
On Thu, 18 Apr 2024, Jan Beulich wrote: > On 16.04.2024 21:27, Stefano Stabellini wrote: > > Also add two specific project-wide deviations for R21.6 and R21.15. > > > > Signed-off-by: Stefano Stabellini > > > > diff --git a/docs/misra/deviations.rst b/docs/misra/deviations.rst > > index

Re: [XEN PATCH 03/10] automation/eclair_analysis: deviate macro count_args_ for MISRA Rule 20.7

2024-04-24 Thread Stefano Stabellini
On Tue, 23 Apr 2024, Nicola Vetrini wrote: > The count_args_ macro violates Rule 20.7, but it can't be made > compliant with Rule 20.7 without breaking its functionality. Since > it's very unlikely for this macro to be misused, it is deviated. That is OK but can't we use the SAF- framework to do

Re: [XEN PATCH] automation/eclair: reorganize pipelines

2024-04-24 Thread Stefano Stabellini
On Tue, 23 Apr 2024, Federico Serafini wrote: > From: Simone Ballarin > > Introduce accepted_guidelines.sh: a script to autogenerate the > configuration file accepted.ecl from docs/misra/rules.rst which enables > all accepted guidelines. > > Introduce monitored.ecl: a manual selection of

Re: [PATCH 3/3] automation: Add arm64 test for running Xen with GICv3

2024-04-24 Thread Stefano Stabellini
On Tue, 23 Apr 2024, Michal Orzel wrote: > At the moment, all the Arm64 Qemu tests use GICv2 which is the default > GIC version used by Qemu. Improve the coverage by adding a new test in > which Qemu will be configured to have GICv3. > > Rename host device tree name to "virt.dtb" to be GIC

Re: [PATCH 2/3] automation: Add arm{64,32} earlyprintk jobs

2024-04-24 Thread Stefano Stabellini
On Tue, 23 Apr 2024, Michal Orzel wrote: > Introduce qemu based Arm earlyprintk test and build jobs to cover this > feature in debug variant. The tests simply check for the presence of the > last message printed by the bootstrap code before entering the C world. > > Signed-off-by: Michal Orzel

Re: [PATCH 1/3] automation: Drop some of the non-debug variants of the same Arm jobs

2024-04-24 Thread Stefano Stabellini
On Tue, 23 Apr 2024, Michal Orzel wrote: > To save some bandwith that can be later on used to increase the test > coverage by adding new tests, drop the following non-debug test/build > jobs existing in both debug and non-debug variants: > - static memory (arm64, arm32) > - static shared memory

[xen-unstable-smoke test] 185788: tolerable all pass - PUSHED

2024-04-24 Thread osstest service owner
flight 185788 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185788/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v3 3/8] gzip: refactor the gunzip window into common state

2024-04-24 Thread Daniel P. Smith
On 4/24/24 12:34, Daniel P. Smith wrote: Begin moving core state, in this case the gunzip window, into struct gunzip_state to allow a per decompression instance. In doing so, drop the define aliasing of window to slide. Signed-off-by: Daniel P. Smith --- xen/common/gzip/gunzip.c | 21

[PATCH 6/7] x86: Make the maximum number of altp2m views configurable

2024-04-24 Thread Petr Beneš
From: Petr Beneš This commit introduces the ability to configure the maximum number of altp2m tables during domain creation. Previously, the limits were hardcoded to a maximum of 10. This change allows for greater flexibility in environments that require more or fewer altp2m views.

[PATCH 3/7] tools/xl: Add max_altp2m parameter

2024-04-24 Thread Petr Beneš
From: Petr Beneš Introduce a new max_altp2m parameter to control the maximum number of altp2m views a domain can use. By default, if max_altp2m is unspecified and altp2m is enabled, the value is set to 10, reflecting the legacy behavior. Signed-off-by: Petr Beneš ---

[PATCH 4/7] tools/ocaml: Add max_altp2m parameter

2024-04-24 Thread Petr Beneš
From: Petr Beneš Allow developers using the OCaml bindings to set the max_altp2m parameter. Signed-off-by: Petr Beneš --- tools/ocaml/libs/xc/xenctrl.ml | 1 + tools/ocaml/libs/xc/xenctrl.mli | 1 + tools/ocaml/libs/xc/xenctrl_stubs.c | 17 ++--- 3 files changed, 12

[PATCH 1/7] x86/p2m: Add braces for better code clarity

2024-04-24 Thread Petr Beneš
From: Petr Beneš No functional change. Signed-off-by: Petr Beneš --- xen/arch/x86/mm/p2m.c | 4 1 file changed, 4 insertions(+) diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index ce742c12e0..eb7996170d 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@

[PATCH 2/7] x86/hap: Refactor boolean field assignments

2024-04-24 Thread Petr Beneš
From: Petr Beneš No functional change. Signed-off-by: Petr Beneš --- xen/arch/x86/mm/hap/hap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c index 9f964c1d87..d2011fde24 100644 --- a/xen/arch/x86/mm/hap/hap.c +++

[PATCH 7/7] x86/hap: Increase the number of initial mempool_size to 1024 pages

2024-04-24 Thread Petr Beneš
From: Petr Beneš This change anticipates scenarios where `max_altp2m` is set to its maximum supported value (i.e., 512), ensuring sufficient memory is allocated upfront to accommodate all altp2m tables without initialization failure. Signed-off-by: Petr Beneš ---

[PATCH 5/7] docs/man: Add max_altp2m parameter to the xl.cfg manual

2024-04-24 Thread Petr Beneš
From: Petr Beneš Update manual pages to include detailed information about the max_altp2m configuration parameter. Signed-off-by: Petr Beneš --- docs/man/xl.cfg.5.pod.in | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in

[PATCH 0/7] x86: Make MAX_ALTP2M configurable

2024-04-24 Thread Petr Beneš
From: Petr Beneš This series introduces the ability to configure the maximum number of altp2m tables during domain creation. Previously, the limits were hardcoded to a maximum of 10. This change allows for greater flexibility in environments that require more or fewer altp2m views. Adjustments

[libvirt test] 185783: tolerable all pass - PUSHED

2024-04-24 Thread osstest service owner
flight 185783 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/185783/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185743 test-amd64-amd64-libvirt 15

[PATCH v3] xen/x86/pvh: handle ACPI RSDT table in PVH Dom0 build

2024-04-24 Thread Daniel P. Smith
From: Stefano Stabellini Xen always generates as XSDT table even if the firmware provided an RSDT table. Copy the RSDT header from the firmware table, adjusting the signature, for the XSDT table when not provided by the firmware. Fixes: 1d74282c455f ('x86: setup PVHv2 Dom0 ACPI tables')

[xen-unstable-smoke test] 185787: tolerable all pass - PUSHED

2024-04-24 Thread osstest service owner
flight 185787 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185787/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v4 4/6] xen/ppc: Enable bootfdt and boot allocator

2024-04-24 Thread Julien Grall
Hi Shawn, On 12/04/2024 04:55, Shawn Anastasio wrote: Enable usage of bootfdt for populating the boot info struct from the firmware-provided device tree. Also enable the Xen boot page allocator. Additionally, modify bootfdt.c's boot_fdt_info() to tolerate the scenario in which the FDT

Re: [PATCH v4 1/6] xen/ppc: Introduce stub asm/static-shmem.h

2024-04-24 Thread Julien Grall
Hi Shawn, On 12/04/2024 04:55, Shawn Anastasio wrote: Required for bootfdt.c to build. AFAIU, this patch is only necessary in #4. So I would consider to fold it there as it doesn't seem to add any value alone. Signed-off-by: Shawn Anastasio --- Changes in v4: none

Re: [PATCH v4 2/6] xen/device-tree: Move Arm's setup.c bootinfo functions to common

2024-04-24 Thread Julien Grall
Hi Shawn, On 12/04/2024 04:55, Shawn Anastasio wrote: diff --git a/xen/common/device-tree/Makefile b/xen/common/device-tree/Makefile new file mode 100644 index 00..947bad979c --- /dev/null +++ b/xen/common/device-tree/Makefile @@ -0,0 +1 @@ +obj-y += bootinfo.init.o diff --git

[linux-5.4 test] 185782: regressions - FAIL

2024-04-24 Thread osstest service owner
flight 185782 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/185782/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvopsbroken in 185433 build-arm64-xsm

Re: [PATCH v3 0/8] Clean up of gzip decompressor

2024-04-24 Thread Daniel P. Smith
On 4/24/24 12:34, Daniel P. Smith wrote: An issue ran into by hyperlaunch was the need to use the gzip decompressor multiple times. The current implementation fails when reused due to tainting of decompressor state from a previous usage. This series seeks to colocate the gzip unit files under a

[PATCH v3 7/8] gzip: move bitbuffer into gunzip state

2024-04-24 Thread Daniel P. Smith
Signed-off-by: Daniel P. Smith --- xen/common/gzip/gunzip.c | 3 +++ xen/common/gzip/inflate.c | 43 ++- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/xen/common/gzip/gunzip.c b/xen/common/gzip/gunzip.c index 95d924d36726..0043ff8ac886

[PATCH v3 8/8] gzip: move crc state into gunzip state

2024-04-24 Thread Daniel P. Smith
Move the crc and its state into struct gunzip_state. In the process, expand the only use of CRC_VALUE as it is hides what is being compared. Signed-off-by: Daniel P. Smith --- xen/common/gzip/gunzip.c | 11 +++ xen/common/gzip/inflate.c | 14 +- 2 files changed, 12

[PATCH v3 5/8] gzip: move input buffer handling into gunzip state

2024-04-24 Thread Daniel P. Smith
Move the input buffer handling, buffer pointer(inbuf), size(insize), and index(inptr), into gunzip state. Adjust functions and macros that consumed the input buffer to accept a struct gunzip_state reference. Signed-off-by: Daniel P. Smith --- xen/common/gzip/gunzip.c | 23 +-

[PATCH v3 6/8] gzip: move output buffer into gunzip state

2024-04-24 Thread Daniel P. Smith
Signed-off-by: Daniel P. Smith --- xen/common/gzip/gunzip.c | 7 --- xen/common/gzip/inflate.c | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/xen/common/gzip/gunzip.c b/xen/common/gzip/gunzip.c index 3fb9589b069e..95d924d36726 100644 --- a/xen/common/gzip/gunzip.c

[PATCH v3 3/8] gzip: refactor the gunzip window into common state

2024-04-24 Thread Daniel P. Smith
Begin moving core state, in this case the gunzip window, into struct gunzip_state to allow a per decompression instance. In doing so, drop the define aliasing of window to slide. Signed-off-by: Daniel P. Smith --- xen/common/gzip/gunzip.c | 21 xen/common/gzip/inflate.c | 68

[PATCH v3 4/8] gzip: move window pointer into gunzip state

2024-04-24 Thread Daniel P. Smith
Move the window pointer, outcnt/wp, into struct gunzip_data. It was erroneously labeled as outcnt and then define aliased to wp, this eliminates the aliasing and only refers to as wp, the window pointer. Signed-off-by: Daniel P. Smith --- xen/common/gzip/gunzip.c | 11 +--

[PATCH v3 1/8] gzip: clean up comments and fix code alignment

2024-04-24 Thread Daniel P. Smith
This commit cleans up the comments and fixes the code alignment using Xen coding style. This is done to make the code more legible before refactoring. Signed-off-by: Daniel P. Smith --- xen/common/gzip/gunzip.c | 14 +- xen/common/gzip/inflate.c | 787 +++--- 2

[PATCH v3 2/8] gzip: refactor and expand macros

2024-04-24 Thread Daniel P. Smith
This commit refactors macros into proper static functions. It in-place expands the `flush_output` macro, allowing the clear removal of the dead code underneath the `underrun` label. Signed-off-by: Daniel P. Smith --- xen/common/gzip/gunzip.c | 14 + xen/common/gzip/inflate.c | 61

[PATCH v3 0/8] Clean up of gzip decompressor

2024-04-24 Thread Daniel P. Smith
An issue ran into by hyperlaunch was the need to use the gzip decompressor multiple times. The current implementation fails when reused due to tainting of decompressor state from a previous usage. This series seeks to colocate the gzip unit files under a single directory similar to the other

[PATCH] arm/vpci: make prefetchable mem 64 bit

2024-04-24 Thread Stewart Hildebrand
The vPCI prefetchable memory range is >= 4GB, so the memory space flags should be set to 64-bit. See IEEE Std 1275-1994 [1] for a definition of the field. [1] https://www.devicetree.org/open-firmware/bindings/pci/pci2_1.pdf Signed-off-by: Stewart Hildebrand --- xen/include/public/arch-arm.h |

Re: [PATCH v4 1/4] xen-livepatch: fix parameter name parsing

2024-04-24 Thread Anthony PERARD
On Wed, Apr 24, 2024 at 10:19:54AM +0200, Roger Pau Monne wrote: > It's incorrect to restrict strncmp to the length of the command line input > parameter, as then a user passing a rune like: > > % xen-livepatch up foo.livepatch > > Would match against the "upload" command, because the string

Re: [XEN PATCH 2/2] x86/msr: add suffix 'U' to MSR_AMD_CSTATE_CFG macro.

2024-04-24 Thread Alessandro Zucchelli
On 2024-04-24 14:53, Teddy Astie wrote: Le 24/04/2024 à 14:11, Alessandro Zucchelli a écrit : This addresses violations of MISRA C:2012 Rule 7.2 which states as following: A “u” or “U” suffix shall be applied to all integer constants that are represented in an unsigned type. No functional

Re: [PATCH v4 6/6] xen/ppc: mm-radix: Allocate all paging structures at runtime

2024-04-24 Thread Jan Beulich
On 12.04.2024 05:55, Shawn Anastasio wrote: > In the initial mm-radix implementation, the in-memory partition and > process tables required to configure the MMU, as well as the page tables > themselves were all allocated statically since the boot allocator was > not yet available. > > Now that it

Re: [XEN PATCH v5 1/3] x86/iommu: Disable IOMMU if cx16 isn't supported

2024-04-24 Thread Jan Beulich
On 18.04.2024 13:57, Teddy Astie wrote: > --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c > +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c > @@ -305,6 +305,12 @@ static int __init cf_check iov_detect(void) > if ( !iommu_enable && !iommu_intremap ) > return 0; > > +if (

Re: [XEN PATCH v5 3/3] x86/iommu: Disable intrerrupt remapping if cx16 is not supported

2024-04-24 Thread Jan Beulich
On 18.04.2024 13:57, Teddy Astie wrote: > All hardware with VT-d/AMD-Vi has CMPXCHG16B support. Check this at > initialisation time, and remove the effectively-dead logic for the non-cx16 > case. > > Suggested-by: Andrew Cooper > Signed-off-by: Teddy Astie Hmm, so this looks to be the code

Re: [XEN PATCH v5 1/3] x86/iommu: Disable IOMMU if cx16 isn't supported

2024-04-24 Thread Jan Beulich
On 18.04.2024 13:57, Teddy Astie wrote: > All hardware with VT-d/AMD-Vi has CMPXCHG16B support. Check this at > initialisation time, and remove the effectively-dead logic for the > non-cx16 case. As before: What about Xen itself running virtualized, and the underlying hypervisor surfacing an

Re: [PATCH] tools/xl: add suspend-to-ram and resume subcommands

2024-04-24 Thread Jason Andryuk
On 2024-02-29 02:00, zithro / Cyril Rébert wrote: The xl command doesn't provide suspend/resume, so add them : xl suspend-to-ram xl resume This patch follows a discussion on XenDevel: when you want the virtualized equivalent of "sleep"-ing a host, it's better to suspend/resume than to

Re: [XEN PATCH 1/2] pci: add suffix 'U' to PCI_CONF_ADDRESS macro.

2024-04-24 Thread Alessandro Zucchelli
On 2024-04-24 14:47, Jan Beulich wrote: On 24.04.2024 14:11, Alessandro Zucchelli wrote: This addresses violations of MISRA C:2012 Rule 7.2 which states as following: A “u” or “U” suffix shall be applied to all integer constants that are represented in an unsigned type. No functional change.

Re: [PATCH v2 1/2] net: Provide MemReentrancyGuard * to qemu_new_nic()

2024-04-24 Thread Thomas Huth
On 24/04/2024 12.41, Prasad Pandit wrote: On Wednesday, 24 April, 2024 at 03:36:01 pm IST, Philippe Mathieu-Daudé wrote: On 1/6/23 05:18, Akihiko Odaki wrote: Recently MemReentrancyGuard was added to DeviceState to record that the device is engaging in I/O. The network device backend needs to

Re: [PATCH 03/15] xen/arm: Always enable IOMMU

2024-04-24 Thread Julien Grall
Hi Henry, On 24/04/2024 04:34, Henry Wang wrote: From: Vikram Garhwal For overlay with iommu functionality to work with running VMs, we need to enable IOMMU by default for the domains. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Signed-off-by: Henry Wang ---

[xen-unstable test] 185780: tolerable FAIL - PUSHED

2024-04-24 Thread osstest service owner
flight 185780 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185780/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185767

Re: [PATCH 3/4] x86/paging: vCPU host mode is always set

2024-04-24 Thread Roger Pau Monné
On Wed, Apr 24, 2024 at 01:41:25PM +0200, Jan Beulich wrote: > On 24.04.2024 11:34, Roger Pau Monné wrote: > > On Tue, Apr 23, 2024 at 04:32:32PM +0200, Jan Beulich wrote: > >> ... thanks to paging_vcpu_init() being part of vCPU creation. Further > >> if paging is enabled on a domain, it's also

Re: [PATCH 4/4] x86/shadow: correct shadow_vcpu_init()'s comment

2024-04-24 Thread Roger Pau Monné
On Wed, Apr 24, 2024 at 01:44:39PM +0200, Jan Beulich wrote: > On 24.04.2024 12:06, Roger Pau Monné wrote: > > On Tue, Apr 23, 2024 at 04:33:09PM +0200, Jan Beulich wrote: > >> As of the commit referenced below the update_paging_modes() hook is per- > >> domain and hence also set (already) during

Re: [PATCH 02/15] xen/arm/gic: Enable interrupt assignment to running VM

2024-04-24 Thread Julien Grall
Hi Henry, On 24/04/2024 04:34, Henry Wang wrote: From: Vikram Garhwal Enable interrupt assign/remove for running VMs in CONFIG_OVERLAY_DTB. Currently, irq_route and mapping is only allowed at the domain creation. Adding exception for CONFIG_OVERLAY_DTB. AFAICT, this is mostly reverting

Re: [XEN PATCH 2/2] x86/msr: add suffix 'U' to MSR_AMD_CSTATE_CFG macro.

2024-04-24 Thread Andrew Cooper
On 24/04/2024 1:51 pm, Jan Beulich wrote: > On 24.04.2024 14:11, Alessandro Zucchelli wrote: >> This addresses violations of MISRA C:2012 Rule 7.2 which states as >> following: A “u” or “U” suffix shall be applied to all integer constants >> that are represented in an unsigned type. >> >> No

Re: [XEN PATCH 2/2] x86/msr: add suffix 'U' to MSR_AMD_CSTATE_CFG macro.

2024-04-24 Thread Teddy Astie
Le 24/04/2024 à 14:11, Alessandro Zucchelli a écrit : > This addresses violations of MISRA C:2012 Rule 7.2 which states as > following: A “u” or “U” suffix shall be applied to all integer constants > that are represented in an unsigned type. > > No functional change. > > Signed-off-by: Alessandro

Re: [XEN PATCH 2/2] x86/msr: add suffix 'U' to MSR_AMD_CSTATE_CFG macro.

2024-04-24 Thread Jan Beulich
On 24.04.2024 14:11, Alessandro Zucchelli wrote: > This addresses violations of MISRA C:2012 Rule 7.2 which states as > following: A “u” or “U” suffix shall be applied to all integer constants > that are represented in an unsigned type. > > No functional change. I'm inclined to suggest Fixes:

Re: [XEN PATCH 1/2] pci: add suffix 'U' to PCI_CONF_ADDRESS macro.

2024-04-24 Thread Jan Beulich
On 24.04.2024 14:11, Alessandro Zucchelli wrote: > This addresses violations of MISRA C:2012 Rule 7.2 which states as > following: A “u” or “U” suffix shall be applied to all integer constants > that are represented in an unsigned type. > > No functional change. > > Signed-off-by: Alessandro

Re: [XEN PATCH] automation/eclair: add deviation of MISRA C:2012 Rule 14.4

2024-04-24 Thread Jan Beulich
On 24.04.2024 14:23, Federico Serafini wrote: > Update ECLAIR configuration to take into account the deviations > agreed during MISRA meetings. > > Amend an existing entry of Rule 14.4 in deviations.rst: > it is not a project-wide deviation. Who / how is it not? ->is_dying is a globally visible

[XEN PATCH] automation/eclair: add deviation of MISRA C:2012 Rule 14.4

2024-04-24 Thread Federico Serafini
Update ECLAIR configuration to take into account the deviations agreed during MISRA meetings. Amend an existing entry of Rule 14.4 in deviations.rst: it is not a project-wide deviation. Signed-off-by: Federico Serafini --- automation/eclair_analysis/ECLAIR/deviations.ecl | 4

[XEN PATCH 1/2] pci: add suffix 'U' to PCI_CONF_ADDRESS macro.

2024-04-24 Thread Alessandro Zucchelli
This addresses violations of MISRA C:2012 Rule 7.2 which states as following: A “u” or “U” suffix shall be applied to all integer constants that are represented in an unsigned type. No functional change. Signed-off-by: Alessandro Zucchelli --- xen/arch/x86/x86_64/pci.c | 2 +- 1 file changed,

[XEN PATCH 0/2] x86: address remaining violation of Rule 7.2

2024-04-24 Thread Alessandro Zucchelli
This patch series addresses the last violations of MISRA C:2012 Rule 7.2. This rule will soon be tagged as clean for ECLAIR in a future patch. Alessandro Zucchelli (2): pci: add suffix 'U' to PCI_CONF_ADDRESS macro. x86/msr: add suffix 'U' to MSR_AMD_CSTATE_CFG macro.

[XEN PATCH 2/2] x86/msr: add suffix 'U' to MSR_AMD_CSTATE_CFG macro.

2024-04-24 Thread Alessandro Zucchelli
This addresses violations of MISRA C:2012 Rule 7.2 which states as following: A “u” or “U” suffix shall be applied to all integer constants that are represented in an unsigned type. No functional change. Signed-off-by: Alessandro Zucchelli --- xen/arch/x86/include/asm/msr-index.h | 2 +- 1

[linux-linus test] 185779: regressions - FAIL

2024-04-24 Thread osstest service owner
flight 185779 linux-linus real [real] flight 185784 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/185779/ http://logs.test-lab.xenproject.org/osstest/logs/185784/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [XEN PATCH v2] automation/eclair: add deviations for MISRA C:2012 Rule 16.4

2024-04-24 Thread Jan Beulich
On 24.04.2024 11:00, Federico Serafini wrote: > On 24/04/24 10:30, Jan Beulich wrote: >> On 24.04.2024 10:25, Federico Serafini wrote: >>> Update ECLAIR configuration to take into account the deviations >>> agreed during MISRA meetings for Rule 16.4. >>> >>> Signed-off-by: Federico Serafini >>>

Re: [PATCH 4/4] x86/shadow: correct shadow_vcpu_init()'s comment

2024-04-24 Thread Jan Beulich
On 24.04.2024 12:06, Roger Pau Monné wrote: > On Tue, Apr 23, 2024 at 04:33:09PM +0200, Jan Beulich wrote: >> As of the commit referenced below the update_paging_modes() hook is per- >> domain and hence also set (already) during domain construction. >> >> Fixes: d0816a9085b5 ("x86/paging: move

Re: [PATCH 3/4] x86/paging: vCPU host mode is always set

2024-04-24 Thread Jan Beulich
On 24.04.2024 11:34, Roger Pau Monné wrote: > On Tue, Apr 23, 2024 at 04:32:32PM +0200, Jan Beulich wrote: >> ... thanks to paging_vcpu_init() being part of vCPU creation. Further >> if paging is enabled on a domain, it's also guaranteed to be either HAP >> or shadow. Drop respective unnecessary

Re: [PATCH 2/4] x86/P2M: un-indent write_p2m_entry()

2024-04-24 Thread Jan Beulich
On 24.04.2024 11:16, Roger Pau Monné wrote: > On Tue, Apr 23, 2024 at 04:32:14PM +0200, Jan Beulich wrote: >> Drop the inner scope that was left from earlier if/else removal. Take >> the opportunity and make the paging_unlock() invocation common to >> success and error paths, though. > > TBH I'm

Re: [PATCH v2 1/2] net: Provide MemReentrancyGuard * to qemu_new_nic()

2024-04-24 Thread Prasad Pandit
On Wednesday, 24 April, 2024 at 03:36:01 pm IST, Philippe Mathieu-Daudé wrote: >On 1/6/23 05:18, Akihiko Odaki wrote: >> Recently MemReentrancyGuard was added to DeviceState to record that the >> device is engaging in I/O. The network device backend needs to update it >> when delivering a packet

Re: [PATCH v3 12/12] xen/arm: List static shared memory regions as /memory nodes

2024-04-24 Thread Luca Fancellu
Hi Julien, > > Rest LGTM: > Reviewed-by: Michal Orzel Thanks, I will send the next one shortly. >>> I don't think there is a need to respin the whole series just for these >>> fixes. >>> You should wait for the committers opinion. >> AFAICT, there are multiple

Re: [PATCH v3 12/12] xen/arm: List static shared memory regions as /memory nodes

2024-04-24 Thread Julien Grall
Hi, On 22/04/2024 11:24, Julien Grall wrote: Hi, On 22/04/2024 10:26, Michal Orzel wrote: On 22/04/2024 10:07, Luca Fancellu wrote: Hi Michal, +    for ( cells = reg, i = 0; cells < reg + nr_cells; i++, cells += reg_size ) +    { +    u64 start = dt_read_number(cells, addrcells);

Re: [XEN PATCH 04/10] drivers: char: address violation of MISRA C Rule 20.7

2024-04-24 Thread Nicola Vetrini
On 2024-04-24 09:23, Jan Beulich wrote: On 23.04.2024 17:12, Nicola Vetrini wrote: --- a/xen/drivers/char/omap-uart.c +++ b/xen/drivers/char/omap-uart.c @@ -48,8 +48,9 @@ /* System configuration register */ #define UART_OMAP_SYSC_DEF_CONF 0x0d /* autoidle mode, wakeup is enabled */

Re: [PATCH 4/4] x86/shadow: correct shadow_vcpu_init()'s comment

2024-04-24 Thread Roger Pau Monné
On Tue, Apr 23, 2024 at 04:33:09PM +0200, Jan Beulich wrote: > As of the commit referenced below the update_paging_modes() hook is per- > domain and hence also set (already) during domain construction. > > Fixes: d0816a9085b5 ("x86/paging: move update_paging_modes() hook") > Signed-off-by: Jan

Re: [XEN PATCH v2 5/5] xen/arm: ffa: support notification

2024-04-24 Thread Julien Grall
Hi Bertrand & Jens, On 24/04/2024 07:53, Bertrand Marquis wrote: Hi Jens, On 23 Apr 2024, at 17:26, Jens Wiklander wrote: Hi Julien, On Mon, Apr 22, 2024 at 1:40 PM Julien Grall wrote: Hi Jens, This is not a full review of the code. I will let Bertrand doing it. On 22/04/2024 08:37,

Re: [PATCH v2 1/2] net: Provide MemReentrancyGuard * to qemu_new_nic()

2024-04-24 Thread Philippe Mathieu-Daudé
Hi, On 1/6/23 05:18, Akihiko Odaki wrote: Recently MemReentrancyGuard was added to DeviceState to record that the device is engaging in I/O. The network device backend needs to update it when delivering a packet to a device. In preparation for such a change, add MemReentrancyGuard * as a

Re: [PATCH 3/4] x86/paging: vCPU host mode is always set

2024-04-24 Thread Roger Pau Monné
On Tue, Apr 23, 2024 at 04:32:32PM +0200, Jan Beulich wrote: > ... thanks to paging_vcpu_init() being part of vCPU creation. Further > if paging is enabled on a domain, it's also guaranteed to be either HAP > or shadow. Drop respective unnecessary (parts of) conditionals. Is there some commit

Re: [PATCH 2/4] x86/P2M: un-indent write_p2m_entry()

2024-04-24 Thread Roger Pau Monné
On Tue, Apr 23, 2024 at 04:32:14PM +0200, Jan Beulich wrote: > Drop the inner scope that was left from earlier if/else removal. Take > the opportunity and make the paging_unlock() invocation common to > success and error paths, though. TBH I'm not sure I prefer the fact to continue function

Re: [XEN PATCH v2] automation/eclair: add deviations for MISRA C:2012 Rule 16.4

2024-04-24 Thread Federico Serafini
On 24/04/24 10:30, Jan Beulich wrote: On 24.04.2024 10:25, Federico Serafini wrote: Update ECLAIR configuration to take into account the deviations agreed during MISRA meetings for Rule 16.4. Signed-off-by: Federico Serafini --- automation/eclair_analysis/ECLAIR/deviations.ecl | 8

Re: [PATCH 1/4] x86/P2M: write_p2m_entry() is HVM-only anyway

2024-04-24 Thread Jan Beulich
On 24.04.2024 08:36, Jan Beulich wrote: > On 23.04.2024 21:29, Andrew Cooper wrote: >> On 23/04/2024 3:31 pm, Jan Beulich wrote: >>> The latest as of e2b2ff677958 ("x86/P2M: split out init/teardown >>> functions") the function is obviously unreachable for PV guests. >> >> This doesn't parse.  Do

Re: [XEN PATCH v2] automation/eclair: add deviations for MISRA C:2012 Rule 16.4

2024-04-24 Thread Jan Beulich
On 24.04.2024 10:25, Federico Serafini wrote: > Update ECLAIR configuration to take into account the deviations > agreed during MISRA meetings for Rule 16.4. > > Signed-off-by: Federico Serafini > --- > automation/eclair_analysis/ECLAIR/deviations.ecl | 8 > docs/misra/deviations.rst

[XEN PATCH v2] automation/eclair: add deviations for MISRA C:2012 Rule 16.4

2024-04-24 Thread Federico Serafini
Update ECLAIR configuration to take into account the deviations agreed during MISRA meetings for Rule 16.4. Signed-off-by: Federico Serafini --- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 docs/misra/deviations.rst| 13 + 2 files changed,

[PATCH v4 2/4] livepatch: introduce --force option

2024-04-24 Thread Roger Pau Monne
Introduce a xen-livepatch tool --force option, that's propagated into the hyerpvisor for livepatch operations. The intention is for the option to be used to bypass some checks that would otherwise prevent the patch from being loaded. Re purpose the pad field in xen_sysctl_livepatch_op to be a

[PATCH v4 4/4] x86/livepatch: perform sanity checks on the payload exception table contents

2024-04-24 Thread Roger Pau Monne
Ensure the entries of a payload exception table only apply to text regions in the payload itself. Since the payload exception table needs to be loaded and active even before a patch is applied (because hooks might already rely on it), make sure the exception table (if any) only contains fixups

[PATCH v4 0/4] livepatch: minor bug fixes and improvements

2024-04-24 Thread Roger Pau Monne
Hello, Following series contain some minor bugfixes and improvements for livepatch logic, both inside the hypervisor and on the command line tool. Thanks, Roger. Roger Pau Monne (4): xen-livepatch: fix parameter name parsing livepatch: introduce --force option livepatch: refuse to resolve

[PATCH v4 3/4] livepatch: refuse to resolve symbols that belong to init sections

2024-04-24 Thread Roger Pau Monne
Livepatch payloads containing symbols that belong to init sections can only lead to page faults later on, as by the time the livepatch is loaded init sections have already been freed. Refuse to resolve such symbols and return an error instead. Note such resolutions are only relevant for symbols

[PATCH v4 1/4] xen-livepatch: fix parameter name parsing

2024-04-24 Thread Roger Pau Monne
It's incorrect to restrict strncmp to the length of the command line input parameter, as then a user passing a rune like: % xen-livepatch up foo.livepatch Would match against the "upload" command, because the string comparison has been truncated to the length of the input argument. Use strcmp

Re: [XEN PATCH] automation/eclair: add deviations for MISRA C:2012 Rule 16.4

2024-04-24 Thread Jan Beulich
On 24.04.2024 09:37, Federico Serafini wrote: > On 23/04/24 18:06, Jan Beulich wrote: >> On 23.04.2024 17:52, Federico Serafini wrote: >>> On 23/04/24 12:26, Jan Beulich wrote: On 23.04.2024 12:02, Federico Serafini wrote: > + > + * - R16.4 > + - A switch statement with a

Re: [XEN PATCH] automation/eclair: add deviations for MISRA C:2012 Rule 16.4

2024-04-24 Thread Federico Serafini
On 23/04/24 18:06, Jan Beulich wrote: On 23.04.2024 17:52, Federico Serafini wrote: On 23/04/24 12:26, Jan Beulich wrote: On 23.04.2024 12:02, Federico Serafini wrote: + + * - R16.4 + - A switch statement with a single switch clause and no default label may + be used in place of

Re: [XEN PATCH 10/10] x86/mm: address violations of MISRA C Rule 20.7

2024-04-24 Thread Jan Beulich
On 23.04.2024 17:12, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

Re: [XEN PATCH 09/10] x86/debugreg: address violation of MISRA C Rule 20.7

2024-04-24 Thread Jan Beulich
On 23.04.2024 17:12, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

Re: [XEN PATCH 08/10] x86/hvm: hpet: address violations of MISRA C Rule 20.7

2024-04-24 Thread Jan Beulich
On 23.04.2024 17:12, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

Re: [XEN PATCH 07/10] x86/acpi: power: address violations of MISRA Rule 20.7

2024-04-24 Thread Jan Beulich
On 23.04.2024 17:12, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

Re: [XEN PATCH 06/10] x86/pci: address violation of MISRA C Rule 20.7

2024-04-24 Thread Jan Beulich
On 23.04.2024 17:12, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

Re: [XEN PATCH 05/10] xen/spinlock: address violations of MISRA C Rule 20.7

2024-04-24 Thread Jan Beulich
On 23.04.2024 17:12, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

Re: [XEN PATCH 04/10] drivers: char: address violation of MISRA C Rule 20.7

2024-04-24 Thread Jan Beulich
On 23.04.2024 17:12, Nicola Vetrini wrote: > --- a/xen/drivers/char/omap-uart.c > +++ b/xen/drivers/char/omap-uart.c > @@ -48,8 +48,9 @@ > /* System configuration register */ > #define UART_OMAP_SYSC_DEF_CONF 0x0d /* autoidle mode, wakeup is enabled > */ > > -#define omap_read(uart, off)

Re: [XEN PATCH 02/10] xen/page-defs: address violation of MISRA C Rule 20.7

2024-04-24 Thread Jan Beulich
On 23.04.2024 17:12, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

Re: [XEN PATCH 01/10] libelf: address violations of MISRA C Rule 20.7

2024-04-24 Thread Jan Beulich
On 23.04.2024 17:12, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

  1   2   >