[PATCH] tools/libxs: Open /dev/xen/xenbus fds as O_CLOEXEC

2024-05-03 Thread Andrew Cooper
The header description for xs_open() goes as far as to suggest that the fd is O_CLOEXEC, but it isn't actually. `xl devd` has been observed leaking /dev/xen/xenbus into children. Link: https://github.com/QubesOS/qubes-issues/issues/8292 Reported-by: Demi Marie Obenour Signed-off-by: Andrew

Re: [PATCH v6 3/7] x86/hvm: Allow access to registers on the same page as MSI-X table

2024-05-03 Thread Marek Marczykowski-Górecki
On Fri, May 03, 2024 at 10:33:38AM +0200, Roger Pau Monné wrote: > On Fri, Apr 26, 2024 at 07:54:00PM +0200, Marek Marczykowski-Górecki wrote: > > Some devices (notably Intel Wifi 6 AX210 card) keep auxiliary registers > > on the same page as MSI-X table. Device model (especially one in > >

[linux-linus test] 185911: regressions - FAIL

2024-05-03 Thread osstest service owner
flight 185911 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/185911/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 185870

Re: [PATCH v3 9/9] xen/arm64: lib: Use the generic xen/linkage.h macros

2024-05-03 Thread Stefano Stabellini
On Wed, 1 May 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Use the generic xen/linkage.h macros to annotate code symbols. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/arm64/lib/memchr.S | 4 ++-- >

Re: [PATCH v3 8/9] xen/arm64: cache: Use the generic xen/linkage.h macros

2024-05-03 Thread Stefano Stabellini
On Wed, 1 May 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Use the generic xen/linkage.h macros to annotate code symbols. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/arm64/cache.S | 4 ++-- > 1 file changed, 2 insertions(+),

Re: [PATCH v3 7/9] xen/arm64: mmu/head: Add missing code symbol annotations

2024-05-03 Thread Stefano Stabellini
On Wed, 1 May 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Use the generic xen/linkage.h macros to annotate code symbols > and add missing annotations. > > Signed-off-by: Edgar E. Iglesias > --- > xen/arch/arm/arm64/mmu/head.S | 28 ++-- > 1 file

Re: [PATCH v3 6/9] xen/arm64: bpi: Add missing code symbol annotations

2024-05-03 Thread Stefano Stabellini
On Wed, 1 May 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Use the generic xen/linkage.h macros to annotate code symbols > and add missing annotations. > > Signed-off-by: Edgar E. Iglesias > --- > xen/arch/arm/arm64/bpi.S | 20 > 1 file changed, 12

Re: [PATCH v3 5/9] xen/arm64: debug: Add missing code symbol annotations

2024-05-03 Thread Stefano Stabellini
On Wed, 1 May 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Use the generic xen/linkage.h macros to annotate code symbols > and add missing annotations. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/arm64/debug.S | 6 -- > 1

Re: [PATCH v3 4/9] xen/arm64: head: Add missing code symbol annotations

2024-05-03 Thread Stefano Stabellini
On Wed, 1 May 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Use the generic xen/linkage.h macros to annotate code symbols > and add missing annotations. > > Signed-off-by: Edgar E. Iglesias > --- > xen/arch/arm/arm64/head.S | 50 --- > 1

Re: [PATCH v3 2/9] xen/arm64: smc: Add missing code symbol annotations

2024-05-03 Thread Stefano Stabellini
On Wed, 1 May 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Use the generic xen/linkage.h macros to annotate code symbols > and add missing annotations. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/arm64/smc.S | 6 -- > 1

Re: [PATCH v3 3/9] xen/arm64: sve: Add missing code symbol annotations

2024-05-03 Thread Stefano Stabellini
On Wed, 1 May 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Use the generic xen/linkage.h macros to annotate code symbols > and add missing annotations. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/arm64/sve-asm.S | 9 ++---

Re: [XEN PATCH 2/2] automation/eclair: add deviation for Rule 16.4

2024-05-03 Thread Stefano Stabellini
On Fri, 3 May 2024, Federico Serafini wrote: > MISRA C:2012 Rule 16.4 states that "Every switch statement shall have a > default label". > Update ECLAIR configuration to take into account the deviations > agreed during MISRA meetings. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano

Re: [XEN PATCH 1/2] docs/misra: add Terms & Definitions section to rules.rst

2024-05-03 Thread Stefano Stabellini
On Fri, 3 May 2024, Federico Serafini wrote: > Add a section for terms and definitions used by MISRA but expressed > in terms of the C specification. > > Add a definition of "switch clause" to the newly-introduced section. > > Link the first use of the term "switch clause" in the document to its

Re: [XEN PATCH] automation/eclair: hide reports coming from adopted code in scheduled analysis

2024-05-03 Thread Stefano Stabellini
On Fri, 3 May 2024, Federico Serafini wrote: > To improve clarity and ease of navigation do not show reports related > to adopted code in the scheduled analysis. > Configuration options are commented out because they may be useful > in the future. > > Signed-off-by: Simone Ballarin >

Re: [GIT PULL] xen: branch for v6.9-rc7

2024-05-03 Thread pr-tracker-bot
The pull request you sent on Fri, 3 May 2024 14:20:28 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > for-linus-6.9a-rc7-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ddb4c3f25b7b95df3d6932db0b379d768a6ebdf7 Thank you! -- Deet-doot-dot,

[xen-4.15-testing test] 185909: tolerable FAIL - PUSHED

2024-05-03 Thread osstest service owner
flight 185909 xen-4.15-testing real [real] flight 185913 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/185909/ http://logs.test-lab.xenproject.org/osstest/logs/185913/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

[xen-unstable-smoke test] 185912: tolerable all pass - PUSHED

2024-05-03 Thread osstest service owner
flight 185912 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185912/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [REGRESSION] Re: [XEN PATCH 0/3] automation/eclair: do not allow failure for triggered analyses

2024-05-03 Thread Andrew Cooper
On 03/05/2024 9:01 pm, Federico Serafini wrote: > On 03/05/24 21:46, Andrew Cooper wrote: >> On 03/05/2024 8:44 pm, Federico Serafini wrote: >>> On 03/05/24 21:14, Andrew Cooper wrote: On 29/04/2024 4:21 pm, Federico Serafini wrote: > Patch 1/3 does some preparation work. > >

Re: [REGRESSION] Re: [XEN PATCH 0/3] automation/eclair: do not allow failure for triggered analyses

2024-05-03 Thread Federico Serafini
On 03/05/24 21:46, Andrew Cooper wrote: On 03/05/2024 8:44 pm, Federico Serafini wrote: On 03/05/24 21:14, Andrew Cooper wrote: On 29/04/2024 4:21 pm, Federico Serafini wrote: Patch 1/3 does some preparation work. Patch 2/3, as the title says, removes allow_failure = true for triggered

Re: [REGRESSION] Re: [XEN PATCH 0/3] automation/eclair: do not allow failure for triggered analyses

2024-05-03 Thread Andrew Cooper
On 03/05/2024 8:44 pm, Federico Serafini wrote: > On 03/05/24 21:14, Andrew Cooper wrote: >> On 29/04/2024 4:21 pm, Federico Serafini wrote: >>> Patch 1/3 does some preparation work. >>> >>> Patch 2/3, as the title says, removes allow_failure = true for >>> triggered >>> analyses. >>> >>> Patch

Re: [REGRESSION] Re: [XEN PATCH 0/3] automation/eclair: do not allow failure for triggered analyses

2024-05-03 Thread Federico Serafini
On 03/05/24 21:14, Andrew Cooper wrote: On 29/04/2024 4:21 pm, Federico Serafini wrote: Patch 1/3 does some preparation work. Patch 2/3, as the title says, removes allow_failure = true for triggered analyses. Patch 3/3 makes explicit that initally no files are tagged as adopted, this is

[REGRESSION] Re: [XEN PATCH 0/3] automation/eclair: do not allow failure for triggered analyses

2024-05-03 Thread Andrew Cooper
On 29/04/2024 4:21 pm, Federico Serafini wrote: > Patch 1/3 does some preparation work. > > Patch 2/3, as the title says, removes allow_failure = true for triggered > analyses. > > Patch 3/3 makes explicit that initally no files are tagged as adopted, this > is needed by the scheduled analysis.

Re: [PATCH v6 8/8] xen: allow up to 16383 cpus

2024-05-03 Thread Stefano Stabellini
On Fri, 3 May 2024, Julien Grall wrote: > Hi Stefano, > > On 02/05/2024 19:13, Stefano Stabellini wrote: > > On Mon, 29 Apr 2024, Julien Grall wrote: > > > Hi Juergen, > > > > > > On 29/04/2024 12:28, Jürgen Groß wrote: > > > > On 29.04.24 13:04, Julien Grall wrote: > > > > > Hi Juergen, > > > >

Re: [PATCH v8 02/17] xen: introduce generic non-atomic test_*bit()

2024-05-03 Thread Oleksii
On Thu, 2024-04-25 at 17:35 +0200, Jan Beulich wrote: > >   #include > >   > > +#ifndef arch_check_bitop_size > > +#define arch_check_bitop_size(addr) > > Can this really do nothing? Passing the address of an object smaller > than > bitop_uint_t will read past the object in the generic__*_bit()

Xen 4.19 release status tracking list [ May ]

2024-05-03 Thread Oleksii
Hello everyone, I would like to share with you a list for status tracking based on Xen ML and community members comments: *** Arm ***: * Arm cache coloring [ https://lore.kernel.org/xen-devel/20240502165533.319988-1-carlo.non...@minervasys.tech/ ]: - new patch series version [v8] was sent

[RFC PATCH 1/5] tools/libs/light: Add vid field to libxl_device_nic

2024-05-03 Thread Leigh Brown
Add integer member `vid' to libxl_device_nic, to represent the VLAN ID to assign to the VIF when adding it to the bridge device. Update libxl_nic.c to read and write the vid field from the xenstore. This provides the capability for supported operating systems (e.g. Linux) to perform VLAN

[RFC PATCH 0/5] Add bridge VLAN support

2024-05-03 Thread Leigh Brown
For many years I have been configuring VLANs on my Linux Dom0 by creating VLAN interfaces for each VLAN I wanted to connect a domain to and then a corresponding bridge. So I would tend to have things like: enp0s0-> br0 -> vif1, vif2 enp0s0.10 -> br0vl10 -> vif3, vif4 enp0s0.20 -> br0vl20

[RFC PATCH 4/5] docs/man: document VIF vid keyword

2024-05-03 Thread Leigh Brown
Document the new `vid' keyword in xl-network-configuration(5). Signed-off-by: Leigh Brown --- docs/man/xl-network-configuration.5.pod.in | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/man/xl-network-configuration.5.pod.in b/docs/man/xl-network-configuration.5.pod.in index

[RFC PATCH 3/5] tools/hotplug/Linux: Add bridge VLAN support

2024-05-03 Thread Leigh Brown
Update add_to_bridge shell function to read the vid parameter from xenstore and set the bridge LAN for the VID to the given value. This only works when using the iproute2 bridge command, so a warning is issued if using the legacy brctl command and a vid is set. Signed-off-by: Leigh Brown ---

[RFC PATCH 2/5] tools/xl: add vid keyword vif option

2024-05-03 Thread Leigh Brown
Update parse_nic_config() to support a new `vid' keyword. This keyword specifies the numeric VLAN ID to assign to the VIF when attaching it to the bridge port, on operating systems that support the capability (e.g. Linux). Signed-off-by: Leigh Brown --- tools/xl/xl_parse.c | 2 ++ 1 file

[RFC PATCH 5/5] tools/examples: Examples Linux bridge VLAN config

2024-05-03 Thread Leigh Brown
Add a new directory linux-bridge-vlan showing how to configure systemd-networkd to support a bridge VLAN configuration. Signed-off-by: Leigh Brown --- tools/examples/linux-bridge-vlan/README | 52 +++ tools/examples/linux-bridge-vlan/br0.netdev | 7 +++

Re: [XEN PATCH v4 5/5] xen/arm: ffa: support notification

2024-05-03 Thread Julien Grall
Hi Jens, On 03/05/2024 14:54, Jens Wiklander wrote: +static int ffa_setup_irq_callback(struct notifier_block *nfb, + unsigned long action, void *hcpu) +{ +unsigned int cpu = (unsigned long)hcpu; +struct notif_irq_info irq_info = { }; + +switch (

[linux-linus test] 185907: regressions - FAIL

2024-05-03 Thread osstest service owner
flight 185907 linux-linus real [real] flight 185910 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/185907/ http://logs.test-lab.xenproject.org/osstest/logs/185910/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [RFC PATCH v3 3/5] KVM: x86: Add notifications for Heki policy configuration and violation

2024-05-03 Thread Sean Christopherson
On Fri, May 03, 2024, Mickaël Salaün wrote: > Add an interface for user space to be notified about guests' Heki policy > and related violations. > > Extend the KVM_ENABLE_CAP IOCTL with KVM_CAP_HEKI_CONFIGURE and > KVM_CAP_HEKI_DENIAL. Each one takes a bitmask as first argument that can >

Re: [PATCH v2 01/12] VT-d: correct ATS checking for root complex integrated devices

2024-05-03 Thread Roger Pau Monné
On Thu, Feb 15, 2024 at 11:13:24AM +0100, Jan Beulich wrote: > Spec version 4.1 says > > "The ATSR structures identifies PCI Express Root-Ports supporting > Address Translation Services (ATS) transactions. Software must enable > ATS on endpoint devices behind a Root Port only if the Root Port

[libvirt test] 185908: tolerable all pass - PUSHED

2024-05-03 Thread osstest service owner
flight 185908 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/185908/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185891 test-amd64-amd64-libvirt 15

Re: [XEN PATCH v4 5/5] xen/arm: ffa: support notification

2024-05-03 Thread Jens Wiklander
Hi Julien, On Fri, May 3, 2024 at 11:59 AM Julien Grall wrote: > > Hi Jens, > > On 02/05/2024 15:56, Jens Wiklander wrote: > > -static bool ffa_probe(void) > > +static int __init ffa_init(void) > > { > > uint32_t vers; > > unsigned int major_vers; > > @@ -460,16 +511,16 @@ static

Re: [RFC PATCH v3 0/5] Hypervisor-Enforced Kernel Integrity - CR pinning

2024-05-03 Thread Sean Christopherson
On Fri, May 03, 2024, Mickaël Salaün wrote: > Hi, > > This patch series implements control-register (CR) pinning for KVM and > provides an hypervisor-agnostic API to protect guests. It includes the > guest interface, the host interface, and the KVM implementation. > > It's not ready for

[RFC PATCH v3 1/5] virt: Introduce Hypervisor Enforced Kernel Integrity (Heki)

2024-05-03 Thread Mickaël Salaün
From: Madhavan T. Venkataraman Hypervisor Enforced Kernel Integrity (Heki) is a feature that will use the hypervisor to enhance guest virtual machine security. Implement minimal code to introduce Heki: - Define the config variables. - Define a kernel command line parameter "heki" to turn the

[RFC PATCH v3 5/5] virt: Add Heki KUnit tests

2024-05-03 Thread Mickaël Salaün
The new CONFIG_HEKI_KUNIT_TEST option enables to run tests in a a kernel module. The minimal required configuration is listed in the virt/heki-test/.kunitconfig file. test_cr_disable_smep checks control-register pinning by trying to disable SMEP. This test should then failed on a non-protected

[RFC PATCH v3 3/5] KVM: x86: Add notifications for Heki policy configuration and violation

2024-05-03 Thread Mickaël Salaün
Add an interface for user space to be notified about guests' Heki policy and related violations. Extend the KVM_ENABLE_CAP IOCTL with KVM_CAP_HEKI_CONFIGURE and KVM_CAP_HEKI_DENIAL. Each one takes a bitmask as first argument that can contains KVM_HEKI_EXIT_REASON_CR0 and KVM_HEKI_EXIT_REASON_CR4.

[RFC PATCH v3 4/5] heki: Lock guest control registers at the end of guest kernel init

2024-05-03 Thread Mickaël Salaün
The hypervisor needs to provide some functions to support Heki. These form the Heki-Hypervisor API. Define a heki_hypervisor structure to house the API functions. A hypervisor that supports Heki must instantiate a heki_hypervisor structure and pass it to the Heki common code. This allows the

[RFC PATCH v3 2/5] KVM: x86: Add new hypercall to lock control registers

2024-05-03 Thread Mickaël Salaün
This enables guests to lock their CR0 and CR4 registers with a subset of X86_CR0_WP, X86_CR4_SMEP, X86_CR4_SMAP, X86_CR4_UMIP, X86_CR4_FSGSBASE and X86_CR4_CET flags. The new KVM_HC_LOCK_CR_UPDATE hypercall takes three arguments. The first is to identify the control register, the second is a bit

[RFC PATCH v3 0/5] Hypervisor-Enforced Kernel Integrity - CR pinning

2024-05-03 Thread Mickaël Salaün
Hi, This patch series implements control-register (CR) pinning for KVM and provides an hypervisor-agnostic API to protect guests. It includes the guest interface, the host interface, and the KVM implementation. It's not ready for mainline yet (see the current limitations), but we think the

[XEN PATCH] automation/eclair: hide reports coming from adopted code in scheduled analysis

2024-05-03 Thread Federico Serafini
To improve clarity and ease of navigation do not show reports related to adopted code in the scheduled analysis. Configuration options are commented out because they may be useful in the future. Signed-off-by: Simone Ballarin Signed-off-by: Federico Serafini ---

Re: [PATCH for-4.19? 0/2] xen/x86: support foreign mappings for HVM

2024-05-03 Thread Roger Pau Monné
On Tue, Apr 30, 2024 at 06:58:43PM +0200, Roger Pau Monne wrote: > Hello, > > The following series attempts to solve a shortcoming of HVM/PVH guests > with the lack of support for foreign mappings. Such lack of support > prevents using PVH based guests as stubdomains for example. > > Add

Re: [PATCH] xen/Kconfig: Drop the final remnants of ---help---

2024-05-03 Thread Oleksii
On Thu, 2024-05-02 at 19:10 +0100, Andrew Cooper wrote: > We deprecated the use of ---help--- a while ago, but a lot of new > content > copy bad examples.  Convert the remaining instances, and > update > Kconfig's parser to no longer recongise it. > > This now causes builds to fail with: > >  

Re: [PATCH v1.1] xen/commom/dt-overlay: Fix missing lock when remove the device

2024-05-03 Thread Julien Grall
Hi Henry, On 26/04/2024 02:55, Henry Wang wrote: If CONFIG_DEBUG=y, below assertion will be triggered: (XEN) Assertion 'rw_is_locked(_host_lock)' failed at drivers/passthrough/device_tree.c:146 (XEN) [ Xen-4.19-unstable  arm64  debug=y  Not tainted ] (XEN) CPU:    0 (XEN) PC:

[GIT PULL] xen: branch for v6.9-rc7

2024-05-03 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.9a-rc7-tag xen: branch for v6.9-rc7 It contains two fixes when running as Xen PV guests for issues introduced in the 6.9 merge window, both related to apic id handling. Thanks.

Re: Referencing domain struct from interrupt handler

2024-05-03 Thread Jan Beulich
On 03.05.2024 09:45, Jens Wiklander wrote: > Hi Xen maintainers, > > In my patch series [XEN PATCH v4 0/5] FF-A notifications [1] I need to > get a reference to a domain struct from a domain ID and keep it from > being destroyed while using it in the interrupt handler > notif_irq_handler()

Re: [XEN PATCH v2 1/3] drivers: char: address violation of MISRA C Rule 20.7

2024-05-03 Thread Nicola Vetrini
On 2024-05-03 12:10, Jan Beulich wrote: On 03.05.2024 09:29, Nicola Vetrini wrote: On 2024-05-01 21:57, Stefano Stabellini wrote: On Tue, 30 Apr 2024, Nicola Vetrini wrote: MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in

Re: [XEN PATCH v2 1/3] drivers: char: address violation of MISRA C Rule 20.7

2024-05-03 Thread Jan Beulich
On 03.05.2024 09:29, Nicola Vetrini wrote: > On 2024-05-01 21:57, Stefano Stabellini wrote: >> On Tue, 30 Apr 2024, Nicola Vetrini wrote: >>> MISRA C Rule 20.7 states: "Expressions resulting from the expansion >>> of macro parameters shall be enclosed in parentheses". Therefore, some >>> macro

Re: [XEN PATCH v4 5/5] xen/arm: ffa: support notification

2024-05-03 Thread Julien Grall
Hi Jens, On 02/05/2024 15:56, Jens Wiklander wrote: -static bool ffa_probe(void) +static int __init ffa_init(void) { uint32_t vers; unsigned int major_vers; @@ -460,16 +511,16 @@ static bool ffa_probe(void) printk(XENLOG_ERR "ffa: unsupported SMCCC

[XEN PATCH 1/2] docs/misra: add Terms & Definitions section to rules.rst

2024-05-03 Thread Federico Serafini
Add a section for terms and definitions used by MISRA but expressed in terms of the C specification. Add a definition of "switch clause" to the newly-introduced section. Link the first use of the term "switch clause" in the document to its definition. Suggested-by: Jan Beulich Signed-off-by:

[XEN PATCH 2/2] automation/eclair: add deviation for Rule 16.4

2024-05-03 Thread Federico Serafini
MISRA C:2012 Rule 16.4 states that "Every switch statement shall have a default label". Update ECLAIR configuration to take into account the deviations agreed during MISRA meetings. Signed-off-by: Federico Serafini --- automation/eclair_analysis/ECLAIR/deviations.ecl | 8

[XEN PATCH 0/2] misra: deviations of Rule 16.4

2024-05-03 Thread Federico Serafini
Define "switch-clause" in terms of the C specification. Deviate Rule 16.4. Federico Serafini (2): docs/misra: add Terms & Definitions section to rules.rst automation/eclair: add deviation for Rule 16.4 automation/eclair_analysis/ECLAIR/deviations.ecl | 8 docs/misra/deviations.rst

Re: [PATCH v6 8/8] xen: allow up to 16383 cpus

2024-05-03 Thread Julien Grall
Hi Stefano, On 02/05/2024 19:13, Stefano Stabellini wrote: On Mon, 29 Apr 2024, Julien Grall wrote: Hi Juergen, On 29/04/2024 12:28, Jürgen Groß wrote: On 29.04.24 13:04, Julien Grall wrote: Hi Juergen, Sorry for the late reply. On 29/04/2024 11:33, Juergen Gross wrote: On 08.04.24

Re: [XEN PATCH] xen/mem_access: address violations of MISRA C: 2012 Rule 8.4

2024-05-03 Thread Julien Grall
Hi, On 03/05/2024 08:09, Alessandro Zucchelli wrote: On 2024-04-29 17:58, Jan Beulich wrote: On 29.04.2024 17:45, Alessandro Zucchelli wrote: Change #ifdef CONFIG_MEM_ACCESS by OR-ing defined(CONFIG_ARM), allowing asm/mem_access.h to be included in all ARM build configurations. This is to

[xen-unstable test] 185906: tolerable FAIL

2024-05-03 Thread osstest service owner
flight 185906 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185906/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 185897 Tests which did not

Re: [PATCH v6 3/7] x86/hvm: Allow access to registers on the same page as MSI-X table

2024-05-03 Thread Roger Pau Monné
On Fri, Apr 26, 2024 at 07:54:00PM +0200, Marek Marczykowski-Górecki wrote: > Some devices (notably Intel Wifi 6 AX210 card) keep auxiliary registers > on the same page as MSI-X table. Device model (especially one in > stubdomain) cannot really handle those, as direct writes to that page is >

Referencing domain struct from interrupt handler

2024-05-03 Thread Jens Wiklander
Hi Xen maintainers, In my patch series [XEN PATCH v4 0/5] FF-A notifications [1] I need to get a reference to a domain struct from a domain ID and keep it from being destroyed while using it in the interrupt handler notif_irq_handler() (introduced in the last patch "[XEN PATCH v4 5/5] xen/arm:

Re: [XEN PATCH v2 1/3] drivers: char: address violation of MISRA C Rule 20.7

2024-05-03 Thread Nicola Vetrini
On 2024-05-01 21:57, Stefano Stabellini wrote: On Tue, 30 Apr 2024, Nicola Vetrini wrote: MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure

Re: [XEN PATCH] xen/mem_access: address violations of MISRA C: 2012 Rule 8.4

2024-05-03 Thread Alessandro Zucchelli
On 2024-04-29 17:58, Jan Beulich wrote: On 29.04.2024 17:45, Alessandro Zucchelli wrote: Change #ifdef CONFIG_MEM_ACCESS by OR-ing defined(CONFIG_ARM), allowing asm/mem_access.h to be included in all ARM build configurations. This is to address the violation of MISRA C: 2012 Rule 8.4 which