As discussed in depth with Andreas,
The overall plan is to move to Type* when it is ready, but unfortunately the
representation distinction in that type system is not yet complete, and we
are
sloppy everywhere w.r.t to representations.
As in the original CL description, we are actually getting closer to a
single
unified type system with this change.
https://codereview.chromium.org/470593002/diff/20001/test/cctest/compiler/test-run-machops.cc
File test/cctest/compiler/test-run-machops.cc (right):
https://codereview.chromium.org/470593002/diff/20001/test/cctest/compiler/test-run-machops.cc#newcode14
test/cctest/compiler/test-run-machops.cc:14: #define CHECK_UINT32_EQ(x,
y) \
On 2014/08/13 19:42:07, Benedikt Meurer wrote:
CheckEqualsHelper for unsigned.
I tried that. C++ doesn't like ambiguous overloads, but it can't resolve
an overload for unsigned integers. O_o
https://codereview.chromium.org/470593002/diff/60001/src/compiler/machine-type.h
File src/compiler/machine-type.h (right):
https://codereview.chromium.org/470593002/diff/60001/src/compiler/machine-type.h#newcode19
src/compiler/machine-type.h:19: rBit = 1 << 0,
On 2014/08/13 19:42:07, Benedikt Meurer wrote:
Urghs, WTF? Revival of the hungarian notation? Can we please just
follow the
decision to adopt the C++ style guide instead of adding just another
custom
naming scheme?
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Constant_Names
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Enumerator_Names
I've changed the names to match the recommended k* prefix.
It's important that we keep the distinction between types and
representations in the code to prevent confusion, so these are now:
kRepX for specific representations
kTypeX for specific types
kMachX for specific type/representation combos
https://codereview.chromium.org/470593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
