https://codereview.chromium.org/470593002/diff/80001/src/compiler/machine-type.h
File src/compiler/machine-type.h (right):
https://codereview.chromium.org/470593002/diff/80001/src/compiler/machine-type.h#newcode8
src/compiler/machine-type.h:8: #include "src/ostreams.h"
On 2014/08/14 07:57:02, Benedikt Meurer wrote:
Please avoid including "src/ostreams.h" in headers. See below.
Done.
https://codereview.chromium.org/470593002/diff/80001/src/compiler/machine-type.h#newcode9
src/compiler/machine-type.h:9: #include "src/v8.h"
On 2014/08/14 07:57:01, Benedikt Meurer wrote:
Same for "src/v8.h". Include what you need instead to avoid further
slowing down
compilation.
It needs kPointerSize to define the kMachPtr type.
https://codereview.chromium.org/470593002/diff/80001/src/compiler/machine-type.h#newcode47
src/compiler/machine-type.h:47: inline void
PrintMachineTypeUnionTo(OStream& os, MachineTypeUnion type) {
On 2014/08/14 07:57:02, Benedikt Meurer wrote:
Please use regular stream syntax:
OStream& operator<<(OStream& os, const MachineTypeUnion&);
and ideally move the implementation to the .cc file and forward
declare OStream
in the .h file.
Done.
https://codereview.chromium.org/470593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
