If it isn’t it should be considering how many times I’ve had a cq- come from an AppleWin build that is in no way affected by my patch.
From: Geoffrey Garen via webkit-dev <webkit-dev@lists.webkit.org> Sent: Monday, June 6, 2022 10:40 AM To: Mark Lam <mark....@apple.com> Cc: Darin Adler <da...@apple.com>; webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Deployment of new EWS Non-Unified builder As such, I also think that the non-unified EWS being green should not be a blocker to landing a patch. But I think having it there for information will help the situation. At minimum, even if every engineer simply ignores the non-unified EWS, it also makes it easier for someone trying to fix a trim missing include build issue to scan through PRs to look for this EWS failure in order to narrow down on which patches (and therefore possible includes) to focus on. Is this the proposal on the table — to have an EWS bot, but also not block patches on it? That’s surprising to me, and not how EWS bots usually work. If we just want an optional record of where a particular build configuration started failing, Isn’t that just… a not-EWS bot? Thanks, Geoff
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
