On 30/01/2024 11:00 pm, Shawn Anastasio wrote: > Hi Andrew, > > On 1/30/24 4:28 PM, Andrew Cooper wrote: >> All architectures have copy&pasted bad logic from x86. >> >> OFFSET() having a trailing semi-colon within the macro expansion can be a >> problematic pattern. It's benign in this case, but fix it anyway. >> >> Perform style fixes for the other macros, and tame the mess of BLANK() >> position to be consistent (one BLANK() after each block) so the intermediate >> form is legible too. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> >> --- >> CC: Jan Beulich <jbeul...@suse.com> >> CC: Roger Pau Monné <roger....@citrix.com> >> CC: Wei Liu <w...@xen.org> >> CC: Stefano Stabellini <sstabell...@kernel.org> >> CC: Julien Grall <jul...@xen.org> >> CC: Volodymyr Babchuk <volodymyr_babc...@epam.com> >> CC: Bertrand Marquis <bertrand.marq...@arm.com> >> CC: Michal Orzel <michal.or...@amd.com> >> CC: Bob Eshleman <bobbyeshle...@gmail.com> >> CC: Alistair Francis <alistair.fran...@wdc.com> >> CC: Connor Davis <connojda...@gmail.com> >> CC: Shawn Anastasio <sanasta...@raptorengineering.com> >> >> Why does PPC have a local copy of ilog2() here? Especially as it's not used, >> and there's a perfectly good one in <xen/bitops.h> > I believe this was a carryover from before we had asm/bitops.h > implemented on PPC. Now that we have bitops implemented (and we don't > define any offsets that use log2 anymore anyways), this is fine to > remove. Will submit a patch to do so.
Ah - good to know. Thanks. > As for the actual contents of this patch, > > Acked-by: Shawn Anastasio <sanasta...@raptorengineering.com> and thanks also. ~Andrew
