On 30.01.2024 23:28, Andrew Cooper wrote: > --- a/xen/arch/x86/x86_64/asm-offsets.c > +++ b/xen/arch/x86/x86_64/asm-offsets.c > @@ -18,11 +18,11 @@ > > #define DEFINE(_sym, _val) \ > asm volatile ("\n.ascii\"==>#define " #_sym " %0 /* " #_val " */<==\"" \ > - : : "i" (_val) ) > + :: "i" (_val))
The removal of the last blank is against our style; instead a blank wants insertion after the opening parenthesis. > #define BLANK() \ > - asm volatile ( "\n.ascii\"==><==\"" : : ) > + asm volatile ("\n.ascii\"==><==\"") Similarly here while dropping the colons is fine, the blanks next to the parentheses want keeping. With that adjusted throughout Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan