Hi Oleksii,
On 26/02/2024 17:38, Oleksii Kurochko wrote:
These functions can be useful for architectures that don't
have corresponding arch-specific instructions.
Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com>
---
Changes in V5:
- new patch
---
xen/include/asm-generic/bitops/fls.h | 18 ++++++++++++++++++
xen/include/asm-generic/bitops/flsl.h | 10 ++++++++++
One header per function seems a little bit excessive to me. Do you have
any pointer where this request is coming from?
Why not using the pattern.
In arch implementation:
#define fls
static inline ...
In the generic header (asm-generic or xen/):
#ifndef fls
static inline ...
#endif
2 files changed, 28 insertions(+)
create mode 100644 xen/include/asm-generic/bitops/fls.h
create mode 100644 xen/include/asm-generic/bitops/flsl.h
diff --git a/xen/include/asm-generic/bitops/fls.h
b/xen/include/asm-generic/bitops/fls.h
new file mode 100644
index 0000000000..369a4c790c
--- /dev/null
+++ b/xen/include/asm-generic/bitops/fls.h
@@ -0,0 +1,18 @@
+/* SPDX-License-Identifier: GPL-2.0 */
You should use GPL-2.0-only.
+#ifndef _ASM_GENERIC_BITOPS_FLS_H_
+#define _ASM_GENERIC_BITOPS_FLS_H_
+
+/**
+ * fls - find last (most-significant) bit set
+ * @x: the word to search
+ *
+ * This is defined the same way as ffs.
+ * Note fls(0) = 0, fls(1) = 1, fls(0x80000000) = 32.
+ */
+
+static inline int fls(unsigned int x)
+{
+ return generic_fls(x);
+}
+
+#endif /* _ASM_GENERIC_BITOPS_FLS_H_ */
Missing emacs magic. I am probably not going to repeat this remark and
the one above again. So please have a look.
diff --git a/xen/include/asm-generic/bitops/flsl.h
b/xen/include/asm-generic/bitops/flsl.h
new file mode 100644
index 0000000000..d0a2e9c729
--- /dev/null
+++ b/xen/include/asm-generic/bitops/flsl.h
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _ASM_GENERIC_BITOPS_FLSL_H_
+#define _ASM_GENERIC_BITOPS_FLSL_H_
+
+static inline int flsl(unsigned long x)
+{
+ return generic_flsl(x);
+}
+
+#endif /* _ASM_GENERIC_BITOPS_FLSL_H_ */
Cheers,
--
Julien Grall
