Hi Jan,
On 29/02/2024 14:03, Jan Beulich wrote:
On 29.02.2024 14:54, Julien Grall wrote:
On 26/02/2024 17:38, Oleksii Kurochko wrote:
These functions can be useful for architectures that don't
have corresponding arch-specific instructions.
Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com>
---
Changes in V5:
- new patch
---
xen/include/asm-generic/bitops/fls.h | 18 ++++++++++++++++++
xen/include/asm-generic/bitops/flsl.h | 10 ++++++++++
One header per function seems a little bit excessive to me. Do you have
any pointer where this request is coming from?
That's in an attempt to follow Linux'es way of having this, aiui. This way
an arch can mix and match header inclusions and private definitions without
any #ifdef-ary.
Ok. I am not going to oppose it if the goal is to keep the headers in
sync with Linux.
Although, it might have been useful to mention it in the commit message.
Cheers,
--
Julien Grall
