Hi Julien, On Tue, 2024-03-12 at 10:33 +0000, Julien Grall wrote: > Hi Jan, > > On 12/03/2024 10:27, Jan Beulich wrote: > > There's no use of them anymore except in the definitions of the > > non- > > underscore-prefixed aliases. > > > > On Arm convert the (renamed) inline function to a macro. > > > > On x86 rename the inline functions, adjust the virt_to_maddr() > > #define, > > and purge the maddr_to_virt() one, thus eliminating a bogus cast > > which > > would have allowed the passing of a pointer type variable into > > maddr_to_virt() to go silently. > > > > No functional change intended. > > > > Signed-off-by: Jan Beulich <jbeul...@suse.com> > > Reviewed-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com> > > --- > > v2: Avoid aliasing macro on Arm. > > Interesting, I was expecting x86 to follow the same approach. I don't > quite understand the benefit of the aliasing here but at the same > time I > don't maintain it. So for Arm (only): > > Acked-by: Julien Grall <jgr...@amazon.com> > > Also, Oleksii, when you send a patch for RISC-V, can you please avoid > the aliasing on RISC-V? I understand we want to prefer static inline > (and in general I would prefer them), but we also need to balance > with > avoiding aliasing when there are zero benefits. Sure. I wanted to that in the same way after your comment for the first version of this patch.
~ Oleksii
