On 12.03.2024 11:33, Julien Grall wrote: > Hi Jan, > > On 12/03/2024 10:27, Jan Beulich wrote: >> There's no use of them anymore except in the definitions of the non- >> underscore-prefixed aliases. >> >> On Arm convert the (renamed) inline function to a macro. >> >> On x86 rename the inline functions, adjust the virt_to_maddr() #define, >> and purge the maddr_to_virt() one, thus eliminating a bogus cast which >> would have allowed the passing of a pointer type variable into >> maddr_to_virt() to go silently. >> >> No functional change intended. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> >> Reviewed-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com> >> --- >> v2: Avoid aliasing macro on Arm. > > Interesting, I was expecting x86 to follow the same approach. I don't > quite understand the benefit of the aliasing here but at the same time I > don't maintain it.
In the absence of respective feedback from x86 maintainers I had to guess what would be preferred, and my guessing is that retaining inline functions where we can use them would be preferred. If that turned out wrong, I'd then switch to purely a macro on x86 too. > So for Arm (only): > > Acked-by: Julien Grall <jgr...@amazon.com> Thanks. Jan
