Hi Andrew, Looking at the patch from the webrev you sent me via private email, and comparing it to my previous bug6541476-corrections.patch, I have some comments.
The addition of a maxLength parameter to readNullTerminatedString makes sense, as it avoids some problems on malformed input. It is my understanding, however, that all strings read via readNullTerminatedString should in a well formed PNG actually be null terminated. Therefore in my opinion reaching the limit should cause an exception to be thrown, not simply return the string read so far. There was a hunk in my patch changing the possible valies for compressionFlag of an iTXtEntry from 1/0 to TRUE/FALSE. YOu moved this change to your patch for 5082756. That's OK by me, but requires patches to be applied in the corret order. That's the reason I had that change bundled with my patch. Greetings, Martin
signature.asc
Description: OpenPGP digital signature
