Hi Roman,

a comment about the test: would the bug reproduce if you just rendered into a BufferedImage? If so, no need for creating a frame and such.

Regarding the fix, it looks ok - but there are other places in the code where the 'crossings' is accessed - are those safe from an NPE?

  Thanks,
    Dmitri


Roman Kennke wrote:
Hi guys,

This patch here fixes the NPE in Pisces renderer as reported in:

https://bugs.openjdk.java.net/show_bug.cgi?id=100053

The webrev is here:

http://cr.openjdk.java.net/~rkennke/100053/webrev.00/

It basically adds nullchecks in the offending code. As far as I can see
this should be sufficient because these arrays are only accessed in the
scope of endRendering(). A testcase is also included.

Thanks, Roman


Reply via email to