Hi Phil, > The fix looks fine to me.
Good. :-) > One thing. The test is > in closed just because no one got round to moving it to open. > At least I don't see any reason it can't be opened up. > Now would be a good time and it can be included with this > changeset. I'll do that. > Don't forget to tag it with this additional bug ID. Ok. Is this one review enough for committing? Could we agree on a slightly more formal reply like 'Go commit', 'Ok, but wait for one more review', or do we always stick to the 2 reviews rule? Thanks, Roman
