Hi Andrew,
Do you really need the "= NULL" on the declarations? They are
initialized on the following line, that should be good enough for any
compiler or lint processing.
Other than that, the new fix looks good...
...jim
On 12/21/2010 2:57 AM, Steve Poole wrote:
Hi Andrew - please feel free to change the patch :-)
Thanks
Steve
From: Andrew Brygin<andrew.bry...@oracle.com>
To: Steve Poole/UK/i...@ibmgb
Cc: 2d-dev<2d-dev@openjdk.java.net>
Date: 21/12/2010 10:42
Subject: Re: [OpenJDK 2D-Dev]<AWT Dev> 7002627 : JNI Critical Arrays
should be released with the original (unmodified) pointer
Hello Steve,
the fix looks reasonable. However, pMask declaration on line 134
causes a compiler warning:
"../../../src/share/native/sun/awt/../java2d/pipe/BufferedMaskBlit.c",
line 134: warning: declaration can not follow a statement
Would you mind if I modify your fix a bit in order to avoid this warning?
Please take a look at webrev:
http://cr.openjdk.java.net/~bae/7002627/webrev/
Thanks,
Andrew
On 12/21/2010 12:23 PM, Steve Poole wrote:
Thanks Anthony.
Regards
Steve Poole
From: Anthony Petrov<anthony.pet...@oracle.com>
To: Steve Poole/UK/i...@ibmgb
Cc: 2d-dev@openjdk.java.net
Date: 21/12/2010 09:01
Subject: Re: [OpenJDK 2D-Dev]<AWT Dev> 7002627 : JNI Critical Arrays
should be released with the original (unmodified) pointer
Sent by: 2d-dev-boun...@openjdk.java.net
I'm adding the patch attached to the original message on the awt-dev@
list.
--
best regards,
Anthony
On 12/20/2010 3:57 PM, Anthony Petrov wrote:
Hi Steve,
This is a 2D issue, and as such I'm CC'ing 2d-dev@ and BCC'ing awt-...@.
--
best regards,
Anthony
On 12/20/2010 11:04 AM, Steve Poole wrote:
Hi all - please find attached a patch for your consideration. I've
build
and tested the change on Linux and Solaris at head (which is to say
I've
run the automatic jtreg tests ) and the change doesn't seem to have
broken
anything. Its fairly trivial anyway.
Regards
Steve Poole
(See attached file: 7002627.export)
[attachment "7002627.export" deleted by Steve Poole/UK/IBM]
