Hi Vladislav,
the fix looks fine to me.
Please make sure you get a second reviewer.
Thanks,
Andrew
On 19.06.2012 13:41, Vladislav Karnaukhov wrote:
Hi Andrew and all,
please see updated webrev here:
http://cr.openjdk.java.net/~vkarnauk/7027300/webrev.01/
Regards,
- Vlad
On 19.06.12 11:35, Andrew Brygin wrote:
Hello Vladislav,
the fix itself seems to be pretty close to the fix for jdk8,
but introduces different import order, and an additional comment.
From my point of view, we should keep jdk7 and jdk8 sources as close
as it is possible just to reduce the backporting overhead.
In this particular case, I do not see a strong need in mentioned
modifications
so could you please consider to do a direct backport of the jdk8
change?
Thanks,
Andrew
On 18.06.2012 17:31, Vladislav Karnaukhov wrote:
Hello,
please review a fix for CR 7027300: Unsynchronized HashMap access
causes endless loop.
The issue is that SunLayoutEngine.getEngine uses non-synchronized
HashMap, which may cause an endless loop.
The fix is to use ConcurrentHashMap instead of HashMap.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7027300
Webrev: http://cr.openjdk.java.net/~vkarnauk/7027300/webrev.00/
Regards,
- Vlad
