On 10/12/2014 00:41, joe darcy wrote:
Hello,
In support of JEP 212: Resolve Lint and Doclint Warnings
(http://openjdk.java.net/jeps/212), which is targeted to JDK 9, please
review the large but straightforward set of changes in the webrev:
http://cr.openjdk.java.net/~darcy/8066621.0/
Some background of the approach being taken to address this part of
JEP 212 was discussed on core-libs:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-December/030085.html
Briefly, to allow the deprecation warnings to be dealt with and that
sole remaining lint warning category enabled in the build, a two-step
approach is being taken. The first step is to suppress the deprecation
warnings and the second step is for area-experts to examine the
specific uses of deprecated APIs in their code. This webrev only
attempts to cover the first step.
The webrev is based off of the JDK 9 "dev" forest rather than the
"client" forest. Since the change only involves copyright updates and
adding annotations, there would be no functional modification in the
changeset. Therefore, I would strongly prefer to push these changes
directly to dev rather than pushing them to client and waiting for
them to propagate to dev to expedite the time when the build warning
can be enabled. (If a warning is not enabled in the build, new
instances of the warning tend to creep into the code base.)
I've skimmed through the changes and they look okay to me. Clearly it
would be nice to get some of these addresses so that the
@SuppressWarnings can be removed in time. As you've pointed out, the
changes don't impact the generated code.
-Alan.