The fix looks good to me.
Regards, Rajeev Chamyal Subject: Re: [9] RFR JDK-7161283: [macosx]filedialog didn't pop up for awt test InvalidParametersNativeTest Date: Thu, 5 Nov 2015 12:59:32 +0300 From: Sergey Bylokhov HYPERLINK "mailto:[email protected]";<[email protected]> To: prasanta sadhukhan HYPERLINK "mailto:[email protected]";<[email protected]>, HYPERLINK "mailto:[email protected]"[email protected] HYPERLINK "mailto:[email protected]";<[email protected]>, Alexander HYPERLINK "mailto:[email protected]";<[email protected]> The fix looks fine to me. On 09.10.15 10:04, prasanta sadhukhan wrote: > Hi All, > > Please review a fix for jdk9 > > Bug: https://bugs.openjdk.java.net/browse/JDK-7161283 > webrev: http://cr.openjdk.java.net/~psadhukhan/7161283/webrev.00/ > > The bug mentioned that FileDialog is not shown when "Print" button in > applet is pressed (when "Print to File" is being tested) where "ok/save" > option will be shown. > But in standard Apple printer dialog there is no "Print to File" option > so this filedialog cannot be seen. Rather there is a "PDF" option which > allows to save the file, so the instructions should be changed in the > test for Mac. > > However, while investigating this problem, I found that there is a NPE > when no printer is added to the system so PrinterJob.getPrintService() > returns null but copyAttributes() uses this printService object to check > supported category attributes without checking if the object is null or > not. Added the relevant check in PrintJob. > > Regards > Prasanta -- Best regards, Sergey.
