The fix looks good to me. Regards, Rajeev Chamyal
-----Original Message----- From: Phil Race Sent: 24 November 2015 23:55 To: prasanta sadhukhan Cc: 2d-dev@openjdk.java.net; Rajeev Chamyal Subject: Re: [9]RFR: JDK-7063986,,Wrong JNi method call in font scaler approved. -phil. On 11/24/2015 02:22 AM, prasanta sadhukhan wrote: > Hi All, > > Please review a simple fix for jdk9 > Bug: https://bugs.openjdk.java.net/browse/JDK-7063986 > webrev: http://cr.openjdk.java.net/~psadhukhan/7063986/webrev/ > > It is found that the JNI invocation sun.font.Type1Font.readFile() from > freeTypefontScaler.c is wrong. > readFile() type is void but JNI uses CallObjectMethod instead of > CallVoidMethod. > Rectified JNI invocation in native to use correct CallVoidMethod. > > Did not add any reg. testcase as I am not sure how to test this via a > testcase. > > Regards > Prasanta >