Hello Brian,
Thank you.
> Also, if it is common practice to refer to com.sun classes in the tests
It seems there are a lot of tests in jdk/test referring to the internal
packages, but I'm not sure if it is a conventional or legacy practice.
Thanks,
Alexander
On 12/29/2015 9:20 PM, Brian Burkhalter wrote:
Hello Alexander,
On Dec 29, 2015, at 4:44 AM, Alexander Stepanov
<alexander.v.stepa...@oracle.com
<mailto:alexander.v.stepa...@oracle.com>> wrote:
Thank you for the notes, please see the updated webrev:
http://cr.openjdk.java.net/~yan/8145776/webrev.01/
1., 3. - fixed
This looks fine (but you still need approval from an actual Reviewer).
WRT 2.: this import is necessary to use TIFFImageWriter,
TIFFImageWriterSpi. As it follows
fromhttp://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/07ae3247e988, the
majority of new classes (excepting tag sets) were added to
com.sun.imageio.plugins.tiff. Do you mean these classes would be
moved to javax/imageio soon?
There is no intention to move any of the added com.sun classes to the
javax namespace.
Also, if it is common practice to refer to com.sun classes in the
tests, then my comments about referring only to classes in the public
namespace (java.*, javax.*) may be disregarded.
(please note also a @module tag added for compatibility with modular
java).
Yes, I saw that.
Thanks,
Brian
