+1

-phil.

On 02/17/2016 06:36 AM, Brian Burkhalter wrote:

On Feb 16, 2016, at 6:42 PM, Joseph D. Darcy <joe.da...@oracle.com <mailto:joe.da...@oracle.com>> wrote:

1. Line 121: Would prefer “tiff” to “tif” as the former is the format acronym and consistent with the other array elements.

I'm happy to change "tif" to "tiff" here; I verified the test passes under an open-only build as a full Oracle build using "tiff”.

Good - thanks.

2. Line 155: So a write failure appends to a log of failures on System.out as opposed to an actual test failure, or am I mistaken?


Those are the combinations that need to be accommodated to allow open-only Linux build to pass the tests. The relevant messages written out in this case are:

....
Testing jpeg writer for type INT_RGB
Testing jpeg writer for type INT_BGR
Testing jpeg writer for type 3BYTE_BGR
Testing jpeg writer for type USHORT_565_RGB
Testing jpeg writer for type USHORT_555_RGB
Testing jpeg writer for type INT_ARGB
    Can't write a type INT_ARGB BufferedImage!
Testing jpeg writer for type INT_ARGB_PRE
    Can't write a type INT_ARGB_PRE BufferedImage!
Testing jpeg writer for type 4BYTE_ABGR
    Can't write a type 4BYTE_ABGR BufferedImage!
Testing jpeg writer for type 4BYTE_ABGR_PRE
    Can't write a type 4BYTE_ABGR_PRE BufferedImage!

Alpha is not generally supported for JPEG so that looks OK.

Thanks,

Brian

Reply via email to