Should we also test bmp and jpg? You tested a different BI formats, but you do not check that the saved information actually relates to the particular image(all of them have a white color and same size). So you will not notice if the Writer will write the same(first) image in all subsequent calls.

On 25.02.16 18:17, Alexander Stepanov wrote:
Sorry, just a reminder.

Thanks,
Alexander

On 2/12/2016 1:35 PM, Alexander Stepanov wrote:
Hello,

Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8149558/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8149558

Just a single regression test added (still failing), plus minor
correction for other test.

Thanks,
Alexander




--
Best regards, Sergey.

Reply via email to