Hi Phil,

Gentle reminder to review this fix.

Regards
Prasanta
On 3/11/2016 5:36 PM, prasanta sadhukhan wrote:

Please find modified webrev with updated testcase.
http://cr.openjdk.java.net/~psadhukhan/8151590/webrev.01/

Regards
Prasanta
On 3/10/2016 4:04 PM, prasanta sadhukhan wrote:
Hi Phil,

Bug: https://bugs.openjdk.java.net/browse/JDK-8151590
webrev: http://cr.openjdk.java.net/~psadhukhan/8151590/webrev.00/

The issue is if application calls
JobAttributes.setDefaultSelection(JobAttributes.DefaultSelectionType.ALL);
along with
JobAttributes.setFromPage(2);
 JobAttributes.setToPage(5);

then "Page" radio button is selected in windows. In linux and mac, "All" radio button is selected. Although the spec is not very clear as to what should get preference, it seems logically DefaultSelection should hold preference.

This is a regression from 8061267 where PD_PAGENUMS was added to the flags resulting in "Page" radio button getting selected. I added a fix to add PD_PAGENUMS to the flags only if the selection attribute is not "PD_ALLPAGES" [which gets selected when JobAttributes.setDefaultSelection(JobAttributes.DefaultSelectionType.ALL); is called]

I tested 8061267 testcase behaviour is same with this fix.

Regards
Prasanta


Reply via email to