Change is fine. Looks like this is the only place in ImageTypeSpecifier where we are not using short-circuit logical "or".
-----Original Message----- From: prasanta sadhukhan Sent: Tuesday, March 15, 2016 5:36 PM To: Sergey Bylokhov; Jayathirth D V; 2d-dev@openjdk.java.net Subject: [9] RFR: JDK-6379088,,Suboptimal expression in javax.imageio.ImageTypeSpecifier.getBitsPerBand(int) Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-6379088 webrev: http://cr.openjdk.java.net/~psadhukhan/6379088/webrev.00/ Please review a simple fix where we should be using short-circuit logical operators so that if left side of the expression is false, right side will not be evaluated. I intend to put noreg-trivial label for this fix. Regards Prasanta