Hi Prasanta, Changes are working fine. Jtreg comment in test case is not properly indented and add '*' for each multiline as per coding guidelines before pushing the change. Also summary of test case should mention about what is test doing, instead of the problem statement.
Thanks, Jay -----Original Message----- From: prasanta sadhukhan Sent: Thursday, April 14, 2016 7:34 PM To: Philip Race Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-6801613, , Cross-platform pageDialog and printDialog top margin entry broken Hi Jay, Could you please give your +1 on this? Regards Prasanta On 4/13/2016 9:11 PM, Philip Race wrote: > +1 although I think robot may be able to automate this. > > -phil. > > On 4/5/16, 4:08 AM, prasanta sadhukhan wrote: >> Hi All, >> >> Please review a fix for jdk9 >> Bug: https://bugs.openjdk.java.net/browse/JDK-6801613 >> webrev: http://cr.openjdk.java.net/~psadhukhan/6801613/webrev.00/ >> >> The issue was the PrinterJob cross-platform "Page setup dialog" top >> margin entry is broken. >> If you enter a value in the top margin field and hit "OK", the value >> is not updated in the PageFormat instance return value, nor is it >> updated in the attribute set used to call the pageDialog method. >> Tabbing out of the top margin field before hitting OK does not fix >> the problem. >> Likewise, clicking on a different margin entry field before hitting >> OK also does not fix the problem. >> >> The reason was we created topMargin JFormattedTextField once and >> added focusListener and ActionListener to this textfield but we >> overwrote the topMargin textField again by creating another instance >> and in that instance, we failed to add actionListener or >> focusListener, so when we tabbed out of topmargin field, focusLost() >> method was not called which would have called updateMargin() method >> to update the margins. >> >> Fix was to remove this erroneous instance creation and overwriting of >> topMargin textfield. >> >> Regards >> Prasanta
