Hi Prasanta, Changes are working fine. +1.
Thanks, Jay -----Original Message----- From: Phil Race Sent: Thursday, May 19, 2016 3:53 AM To: prasanta sadhukhan; [email protected] Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-6509729: javax.print.ServiceUI.printDialog Border/Margin Evaluation is bugged +1 -phil. On 5/17/2016 5:17 AM, prasanta sadhukhan wrote: > Hi All, > > Please review a fix for jdk9 whereby it is seen that the pagedialog > margin validation is incorrect. > > Bug: https://bugs.openjdk.java.net/browse/JDK-6509729 > webrev: http://cr.openjdk.java.net/~psadhukhan/6509729/webrev.00/ > > It is seen that if we modify right margin to invalid value like 0,0 > and refocus to trigger validation, right margin remains invalid. > Similarly, for bottom margin. > > This is because validateMargin() in ServiceDialog.java does not check > for bottom and right margin unlike top,left margin so these margins > are not validated to correct value. > top/left margin changes back to valid 1.0 value when validateMargin() > finds the margins invalid but right/bottom does not change the value > and remains invalid. > > Added the right and bottom margin invalid check in validateMargin(). > > Regards > Prasanta
