Re: [OpenJDK 2D-Dev] RFR: 8156580: Make TIFFTagSet subclasses final

[Phil Race]

+1

-phil.

On 05/16/2016 05:38 PM, Brian Burkhalter wrote:

Please review at your convenience.

Issue:https://bugs.openjdk.java.net/browse/JDK-8156580
Diff:[1]

Aside from the obvious ‘final’ changes there is a minor verbiage typo correction in the TIFFTagSet class javadoc.

Thanks,

Brian

[1] diff

--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/BaselineTIFFTagSet.java +++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/BaselineTIFFTagSet.java

@@ -58,7 +58,7 @@

-public class BaselineTIFFTagSet extends TIFFTagSet {
+public final class BaselineTIFFTagSet extends TIFFTagSet {

--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifGPSTagSet.java +++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifGPSTagSet.java

@@ -38,7 +38,7 @@
-public class ExifGPSTagSet extends TIFFTagSet {
+public final class ExifGPSTagSet extends TIFFTagSet {

--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifInteroperabilityTagSet.java +++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifInteroperabilityTagSet.java

-public class ExifInteroperabilityTagSet extends TIFFTagSet {
+public final class ExifInteroperabilityTagSet extends TIFFTagSet {

--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifParentTIFFTagSet.java +++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifParentTIFFTagSet.java

-public class ExifParentTIFFTagSet extends TIFFTagSet {
+public final class ExifParentTIFFTagSet extends TIFFTagSet {

--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifTIFFTagSet.java +++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifTIFFTagSet.java

@@ -41,7 +41,7 @@
-public class ExifTIFFTagSet extends TIFFTagSet {
+public final class ExifTIFFTagSet extends TIFFTagSet {

--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/FaxTIFFTagSet.java +++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/FaxTIFFTagSet.java

-public class FaxTIFFTagSet extends TIFFTagSet {
+public final class FaxTIFFTagSet extends TIFFTagSet {

--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/GeoTIFFTagSet.java +++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/GeoTIFFTagSet.java

-public class GeoTIFFTagSet extends TIFFTagSet {
+public final class GeoTIFFTagSet extends TIFFTagSet {

/tiff/TIFFTagSet.java b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFTagSet.java --- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFTagSet.java +++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFTagSet.java

@@ -34,14 +34,13 @@

 /**
- * A class representing a set of TIFF tags.  Each tag in the set must
- * have a unique number (this is a limitation of the TIFF
- * specification itself).

+ * A class representing a set of TIFF tags. Each tag in the set must have + * a unique number (this is a limitation of the TIFF specification itself).

  *
  * <p> This class and its subclasses are responsible for mapping
  * between raw tag numbers and {@code TIFFTag} objects, which
  * contain additional information about each tag, such as the tag's
- * name, legal data types, and mnemonic names for some or all of ts
+ * name, legal data types, and mnemonic names for some or all of its