Hi Volker, thanks for that thorough review, the wrong \ is a really good catch!
I did'nt upload a new webrev, but maybe the incremental diff Is useful: http://cr.openjdk.java.net/~goetz/wr16/8160974-headful/webrev.02/incremental_fixes.patch Best regards, Goetz. > -----Original Message----- > From: Volker Simonis [mailto:volker.simo...@gmail.com] > Sent: Mittwoch, 20. Juli 2016 15:30 > To: Sergey Bylokhov <sergey.bylok...@oracle.com> > Cc: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; awt- > d...@openjdk.java.net; swing-...@openjdk.java.net; 2d-dev <2d- > d...@openjdk.java.net> > Subject: Re: <AWT Dev> [OpenJDK 2D-Dev] RFR(L): 8160974: [TESTBUG] > Mark more headful tests with @key headful. > > Hi Götz, > > your change looks good. Thanks a lot for cleaning up all these tests! > > I only found one problem which you should fix: > > test/java/awt/Frame/MiscUndecorated/RepaintTest.java > > @@ -1,6 +1,6 @@ > -/* > +\/* > > Seems like there's an extra backslash at the beginning of the first line. > > You may also want to '@test' on a line by itself like you've done it > for all the other tests in > test/javax/swing/JTable/7068740/bug7068740.java > > /* @test > - @bug 7068740 > - @summary JTable wrapped in JLayer can't use PGUP/PGDOWN keys > - @author Vladislav Karnaukhov > - @run main bug7068740 > -*/ > + * @key headful > + * @bug 7068740 > + * @summary JTable wrapped in JLayer can't use PGUP/PGDOWN keys > + * @author Vladislav Karnaukhov > + * @run main bug7068740 > + */ > > And correctly indent in the following two cases: > > diff --git a/test/javax/swing/LookAndFeel/6897701/JMenuItemsTest.java > b/test/javax/swing/LookAndFeel/6897701/JMenuItemsTest.java > --- a/test/javax/swing/LookAndFeel/6897701/JMenuItemsTest.java > +++ b/test/javax/swing/LookAndFeel/6897701/JMenuItemsTest.java > @@ -23,6 +23,7 @@ > > /* > * @test > + * @key headful > * @bug 6897701 > > and: > > diff --git a/test/javax/swing/plaf/synth/7158712/bug7158712.java > b/test/javax/swing/plaf/synth/7158712/bug7158712.java > --- a/test/javax/swing/plaf/synth/7158712/bug7158712.java > +++ b/test/javax/swing/plaf/synth/7158712/bug7158712.java > @@ -21,7 +21,9 @@ > * questions. > */ > > -/* @test > +/* > + @test > + @key headful > @bug 7158712 > > > There's no need to prepare a new webrev. I won't go through it one > more time anyway :) > > Regards, > Volker > > > On Tue, Jul 19, 2016 at 9:16 PM, Sergey Bylokhov > <sergey.bylok...@oracle.com> wrote: > > Look fine to me. > > > > On 07.07.16 18:01, Lindenmaier, Goetz wrote: > >> > >> Hi, > >> > >> > >> > >> This change is ‘L’ because there are changes to a lot of files, but the > >> changes > >> > >> are all similar, so it’s rather easy to review. > >> > >> Similar to 8159690 I added @key headful to another around 600 tests. > >> > >> I used different patterns to grep for the headful exceptions. > >> > >> > >> > >> These are now all I could find with grepping and the like. I have around > >> > >> 80 failing tests remaining, where a row will probably also depend on > >> > >> a display, but I want to look at them more closely, so I don’t want > >> > >> to include them here. > >> > >> > >> > >> Please review this change: > >> > >> http://cr.openjdk.java.net/~goetz/wr16/8160974-headful/webrev.01/ > >> > >> > >> > >> Best regards, > >> > >> Goetz. > >> > >> > >> > >> > >> > > > > > > -- > > Best regards, Sergey.
