Hi,
That looks reasonable .. but before an OK I would like to see the
results of running the test case in
the bug report after that fix. Run the test case with
-Dsun.java2d.debugfonts=true so we can see
what the JDK is doing internally. You can add the log to the bug report.
Basically fontconfig is also likely to be subsequently invoked to build
the list of real fonts underlying
the logical font names (eg JDK sansserif which is the equivalent of
fontconfig's sans).
I suspect they will all end up just falling back to the Lucida Sans
Regular font shipped with JDK.
But for OpenJDK that won't be there .. so you may also want to see what
happens if you
then delete (move elsewhere) that font from jdk/lib/fonts. Maybe not a
VM crash but a Java NPE perhaps
as no fonts at all is not a supportable configuration.
So yes, that does mean I think that although avoiding a crash is good,
running graphics tests on
a system that has no font is an unsupported and unsupportable configuration.
Put another way Java even as *headless* has a *hard* requirement on the
fonts being installed
and Solaris 12 not installing any by default means it does not satisfy
the requirements of Java
and that decision should be revisited .. else (and I really, really,
mean this) we can't support Solaris 12.
-phil.
On 07/22/2016 06:54 AM, Martin Walsh wrote:
Hi,
Could I get a review for the simple fix for
https://bugs.openjdk.java.net/browse/JDK-8160664
A webrev of the change is available here:
http://cr.openjdk.java.net/~aivanov/martin.walsh/8160664/jdk9/webrev.00/
Thanks,
Martin
