OK unless there are objections from Sergey tomorrow I will plan to push it as-is.
Thanks, Brian On Aug 23, 2016, at 5:12 PM, Philip Race <philip.r...@oracle.com> wrote: > Still fine with me. > > -phil. > > On 8/23/16, 4:18 PM, Brian Burkhalter wrote: >> >> Hi Sergey, >> >> I have added some comments in both the source and the test: >> >> http://cr.openjdk.java.net/~bpb/8149562/webrev.03/ >> >> Please indicate whether you think this is sufficient. The CCC request has >> been approved therefore pushing this code is pending only review approval. >> >> Thanks, >> >> Brian >> >> On Aug 23, 2016, at 11:45 AM, Sergey Bylokhov <sergey.bylok...@oracle.com> >> wrote: >> >>> On 23.08.16 21:41, Sergey Bylokhov wrote: >>>> Is it possible, just for the record, to provide a comment why NPE was >>>> changed to IAE. >>> I meant the first check node==null. >>> >>> actually this code looks a little bit strange: >>>> 493 } catch (NullPointerException npe) { >>>> 494 throw new IllegalArgumentException(npe); >>>> 495 } >>
